[Bug 16043] New: Use Font Awesome icon in hold confirmation dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16043 Bug ID: 16043 Summary: Use Font Awesome icon in hold confirmation dialog Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/returns.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org There is one stray instance in the returns template of a button in a hold confirmation dialog which should use a Font Awesome icon instead of a background image. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16043 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16043 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48966&action=edit Bug 16043 - Use Font Awesome icon in hold confirmation dialog This patch fixes another instance in the checkin template where a Font Awesome icon should be used instead of a background image. To test, apply the patch and locate an item which is on hold for a patron at your logged in library. - Check in the item. - Confirm the hold. - Check in the item again. - You should get a "Hold found (item is already waiting)" message. The "Print and confirm" button in this dialog should have a Font Awesome icon. - Confirm that the print button still works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16043 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 [Bug 16080] Remove unused images from the staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16043 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48966|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 49191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49191&action=edit Bug 16043 - Use Font Awesome icon in hold confirmation dialog This patch fixes another instance in the checkin template where a Font Awesome icon should be used instead of a background image. To test, apply the patch and locate an item which is on hold for a patron at your logged in library. - Check in the item. - Confirm the hold. - Check in the item again. - You should get a "Hold found (item is already waiting)" message. The "Print and confirm" button in this dialog should have a Font Awesome icon. - Confirm that the print button still works correctly. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16043 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16043 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16043 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49191|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49210&action=edit Bug 16043 - Use Font Awesome icon in hold confirmation dialog This patch fixes another instance in the checkin template where a Font Awesome icon should be used instead of a background image. To test, apply the patch and locate an item which is on hold for a patron at your logged in library. - Check in the item. - Confirm the hold. - Check in the item again. - You should get a "Hold found (item is already waiting)" message. The "Print and confirm" button in this dialog should have a Font Awesome icon. - Confirm that the print button still works correctly. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16043 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org