[Bug 21648] New: Patron Merge needs more flexibility and transparency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Bug ID: 21648 Summary: Patron Merge needs more flexibility and transparency Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The patron merge tool introduced in 18.05 is a great step, but creates some issues. Contact information for the discarded patron is lost even when the kept patron has null values for those fields. Merging patrons with additional patron attributes results in a patron with multiple values for an attribute that is not supposed to be repeatable. The screen that confirms the merge has completed reports counts of transferred data but doesn't allow one to see details of what was transferred from the discarded patron to the kept patron. A good next step here would be an interface similar to what we see when merging bibs -- the opportunity to see values for both patron records and select which will be carried forward to the final record, at least for all fields in the borrowers table and for additional patron attributes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Carlos Lopez <clopez@dml.vic.edu.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clopez@dml.vic.edu.au --- Comment #1 from Carlos Lopez <clopez@dml.vic.edu.au> --- Verified: When we've merged borrower records we've found that the resulting record contains multiple patron attributes (even when these are set as not repeatable). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Depends on| |9302 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 [Bug 9302] Add ability to merge patron records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9302 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Irma Birchall <irma@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |irma@calyx.net.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Bob Birchall <bob@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob@calyx.net.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- This wreaks havoc with our records because of duplicated patron attributes and no easy way to clean up. This should be considered a bug, not an enhancement, IMO. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Summary|Patron Merge needs more |Patron Merge duplicates |flexibility and |patron attributes |transparency | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Renaming and refocusing this bug. I agree the attributes are a more pressing aspect of this, so let's make this specific and therefore more easily addressed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Andrew Fuerste-Henry from comment #3)
Renaming and refocusing this bug. I agree the attributes are a more pressing aspect of this, so let's make this specific and therefore more easily addressed.
+1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|heather_hernandez@nps.gov | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Martha Fuerst <mfuerst@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst@hmcpl.org --- Comment #5 from Martha Fuerst <mfuerst@hmcpl.org> --- It makes sense that these attributes would also merge. Thanks for filing this bug! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical --- Comment #6 from Christopher Brannon <cbrannon@cdalibrary.org> --- Hey folks, I changed the importance on this. We would really like to use this feature, but we have to hide it because it causes problems with the database. This really needs to be addressed! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is only a problem when the patron's attributes cannot be repeatable, right? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Jonathan Druart from comment #7)
This is only a problem when the patron's attributes cannot be repeatable, right?
Correct. I don't know if there can be some kind of Duplicates allowed checkbox in each attribute that can be created that would facilitate this, or if the merge option should review items fields being duplicated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 120103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120103&action=edit Bug 21648: Prevent several non-repeatable attributes to be merged When using the patron merge feature it's possible to generate a patron with several non-repeatable attributes. This patch prevents that. Test plan: Create 2 patron attribute types, one repeatable and one non-repeatable Create 2 patrons and add them repeatable attributes Add a non-repeatable attribute to one of them Merge the 2 patrons => It succeeds, the resulting patron has all the repeatable attribute and the non-repeatable one. Do it again but this time add non-repeatable to both patrons Merge them => It fails, you should see an error on the UI Merge failed! The following error was reported: Tried to add more than one non-repeatable attributes. type=TYPE value=VALUE. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Lowering severity, there is no data loss. Please test! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 --- Comment #11 from Christopher Brannon <cbrannon@cdalibrary.org> --- I really don't like the direction of this plan. It looks like you have it fail the merge rather than review and select one of the non-repeatable attributes, as suggested. As is, this leaves A LOT of work for staff to try and resolve issues. At our library, some of these non-repeatable attributes are required. So, it is not as simple as going to one of the two records and deleting the non-repeatable attribute. This should be resolvable at the time of the merge. Otherwise, the merge is pointless and useless for some libraries. For us, it would fail every single attempt because of required attributes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Christopher, yes I take the easy path, to prevent corrupted data. What you are suggesting is, to me, considered as a new enhancement, not a bug fix. The changes required to implement this behaviour are much more important and can be done on a separate bug report. It will certainly need funding if you want to see it implemented. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 --- Comment #13 from Christopher Brannon <cbrannon@cdalibrary.org> --- I'm not picky about whether it is a bug or an enhancement. If you want to charge to do this, then so be it. It isn't anything we've slated to sponsor at this time. If you want to give an estimate for the work, feel free to put it on the bug, so that we know how much it will cost to sponsor. I just ask that the nature of this request be honored and not changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Christopher Brannon from comment #13)
I'm not picky about whether it is a bug or an enhancement. If you want to charge to do this, then so be it. It isn't anything we've slated to sponsor at this time. If you want to give an estimate for the work, feel free to put it on the bug, so that we know how much it will cost to sponsor. I just ask that the nature of this request be honored and not changed.
In my understanding the scope of the bug report was not correctly defined when first created and has been refined later. I also thought that the main point was about the issue leading to corrupted data (patron with several non-repeatable attributes). As the severity was "critical" I provided a patch to fix this specific issue, as small as possible to ease backport into stable branches. We improved the code in this area recently and it was easy to develop, I wrote the patch in about one hour. The way you want to fix the issue requires a much bigger change, and I agree with you it will be a nice one to have. However we are one month left before the release and it's definitely not my job to provide a new enhancement for this specific need. That's why I talked about funding, but I should not have and I regret it. My point was not to tell you "pay to get it", I don't like either when it's the only answer provided, but this bug report has been opened for a long time already and it is something you should consider if you really need it. I will move the patch to a separate bug report and change the status of this bug report to "new enhancement". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120103|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Depends on| |28217 Severity|major |enhancement Assignee|jonathan.druart@bugs.koha-c |koha-bugs@lists.koha-commun |ommunity.org |ity.org --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #14)
I will move the patch to a separate bug report and change the status of this bug report to "new enhancement".
See bug 28217. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28217 [Bug 28217] Several non-repeatable attributes when merging patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Bug 21648 depends on bug 28217, which changed state. Bug 28217 Summary: Several non-repeatable attributes when merging patrons https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28217 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #12)
Christopher, yes I take the easy path, to prevent corrupted data.
What you are suggesting is, to me, considered as a new enhancement, not a bug fix. The changes required to implement this behaviour are much more important and can be done on a separate bug report. It will certainly need funding if you want to see it implemented.
I agree with Jonathan's plan to prevent corrupted data, and then see how we continue with this. I also agree the feature, to be useful, should provide better feedback and options to solve conflicts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Mark Rogers <marcos.rogers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marcos.rogers@gmail.com --- Comment #17 from Mark Rogers <marcos.rogers@gmail.com> --- I agree that prevention of data loss/corruption is important. It sounds like the implementation of Andrew's suggestion to have a full interface to merge both patrons (though great) is currently a barrier to getting a more functional solution for those of us who have required non-repeating patron attributes. Would it be possible to simply treat the non-repeating patron attributes the same way as the standard patron fields? That is, the default behavior would be to retain those non-repeating attributes belonging to the patron record that was chosen when initiating the merge rather than the values for those attributes provided by the non-selected patron. The screen where the merge is confirmed already has links to both patron records, allowing the differences of patron records and additional patron attributes to be compared, albeit somewhat manually. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29059 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Mark, I've opened bug 29059 to implement your suggestion. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |MOVED Status|NEW |RESOLVED --- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm closing this bug in the interest of clarity. Bug 28217 (pushed to Koha) made it so that Koha will block a patron merge rather than end up with two values for a non-repeatable attribute. Bug 29059 (signed off) would adjust this behavior so that Koha keeps the attribute value from the retained patron, rather than blocking the merge. Bug 30303 (just filed) is for the larger enhancement request of a pull patron merge interface to let one select which values to retain from each patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org