[Bug 31537] New: Elasticsearch - index mapping for 003 control-number-identifier is twice in mappings.yaml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 Bug ID: 31537 Summary: Elasticsearch - index mapping for 003 control-number-identifier is twice in mappings.yaml Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com Hi all! I'm not sure if it's for a specific purpose, but the index mapping for 003 control-number-identifier was added twice in the mappings.yaml file. In Bug 28830 and Bug 11175. If it's not necessary that it be there twice, I propose we remove it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 140351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140351&action=edit Bug 31537: Elasticsearch - index mapping for 003 control-number-identifier is twice in mappings.yaml This patch removes one of the two mappings for the 003 field to the control-number-identifier index (for MARC21). To test: 1) Apply patch 2) reindex with mappings reset 3) try to search for cni:code (for example cni:OSt) --> it should return the desired results 4) try to search for control-number-identifier:code (for example control-number-identifier:OSt) --> it should return the desired results 5) Optionally, try the test plan in Bug 11175 to make sure it still works -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Caroline Cyr La Rose from comment #0)
If it's not necessary that it be there twice, I propose we remove it.
I mean, remove one of the two! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140351|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 140355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140355&action=edit Bug 31537: Elasticsearch - index mapping for 003 control-number-identifier is twice in mappings.yaml This patch removes one of the two mappings for the 003 field to the control-number-identifier index (for MARC21). To test: 1) Apply patch 2) reindex with mappings reset 3) try to search for cni:code (for example cni:OSt) --> it should return the desired results 4) try to search for control-number-identifier:code (for example control-number-identifier:OSt) --> it should return the desired results 5) Optionally, try the test plan in Bug 11175 to make sure it still works Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): - Followed the test plan, but didn't do optional step 5. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140355|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 140398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140398&action=edit Bug 31537: Elasticsearch - index mapping for 003 control-number-identifier is twice in mappings.yaml This patch removes one of the two mappings for the 003 field to the control-number-identifier index (for MARC21). To test: 1) Apply patch 2) reindex with mappings reset 3) try to search for cni:code (for example cni:OSt) --> it should return the desired results 4) try to search for control-number-identifier:code (for example control-number-identifier:OSt) --> it should return the desired results 5) Optionally, try the test plan in Bug 11175 to make sure it still works Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Stared at this quite a while, wondering if one would be the definition for authorities - but it isn't, just a double up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Katrin Fischer from comment #6)
Stared at this quite a while, wondering if one would be the definition for authorities - but it isn't, just a double up.
Yeah, me too! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |28830 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 [Bug 28830] Add CNI (Control Number Identifier) search index (MARC21) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org