http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | Summary|Wrong fieldnames or |Fix crash if incorrect |trailing | in system |fieldnames given in sypref |preference StatisticsFields |StatisticsFields |lead to crash | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 43573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43573&action=edit Bug 12721 - Prevent software error if incorrect fieldnames given in sypref StatisticsFields To reproduce issue: See comment #1 To test: - Apply patch - Leave syspref StatisticsFields empty - Display statistics for an author => Result: Table displays Shelving location, Collection code, Item type (as before) - Change syspref to any combination of location|itype|ccode => Result: Table displays columns as appropriate - Change syspref to some garbage => Result: Same as with empty syspref (was crashing without patch) - Change syspref to valid combination with trailing | => Result: Table displays columns as appropriate (was crashing without patch) - Change syspref to a combination of valid and invalid fields (location|blah|ccode) => Result: Table displays column of valid fields only (was crashing without patch) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 43575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43575&action=edit Bug 12721 - Syspref StatisticsFields: Warning on About page and text change in System preferences This patch adds a warning to the about page if the syspref 'StatisticFields' is misconfigured. Additionally, the text on Home > Administration > SystemPreferences is changed. To test: - Apply patch - Edit syspref 'StatisticFields'. Verify that the explanation makes sense. - Leave field empty => verify that no message appears on About page, tab System information - Insert valid field names, e.g. location|itype => verify that no message appears on the About page - Add trailing char => verify that the warning message appears on the About page - Fill in some garbage or misspell a field name => verify that the warning message appears on the About page -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 44316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44316&action=edit Bug 12721 Prevent entering invalid values in StatisticsFields Using 'multiple' type for StatisticsFields syspref avoid having invalid values in, and so prevent a bug in statistics. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #7 from Marc Véron <veron@veron.ch> --- Frédéric, Thanks for the counter patch. I considered your solution as well, but it would restrict the fields on location,itype and ccode only. But the description says: Show the following fields from the items database table as columns on the statistics tab on the patron record (...) I understand this as 'any' colums, not only location,itype and ccode -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #8 from Frédéric Demians <frederic@tamil.fr> ---

But the description says: Show the following fields from the items database table as columns on the statistics tab on the patron record (...)

I understand this as 'any' colums, not only location,itype and ccode

Sorry, you're correct! My patch would be a severe regression for libraries using other fields from 'items' table. What prevents me from signing your patch is that I don't like the idea of checking the existence of items field (by calling DESCRIBE items) each time the statistics fields are required. Have you explored the possibility using the column setting tool? Here: /cgi-bin/koha/admin/columns_settings.pl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #10 from Marc Véron <veron@veron.ch> --- (In reply to Frédéric Demians from comment #8)

...

But the description says: Show the following fields from the items database table as columns on the statistics tab on the patron record (...)

I understand this as 'any' colums, not only location,itype and ccode

Sorry, you're correct! My patch would be a severe regression for libraries using other fields from 'items' table.

What prevents me from signing your patch is that I don't like the idea of checking the existence of items field (by calling DESCRIBE items) each time the statistics fields are required. Have you explored the possibility using the column setting tool? Here:

/cgi-bin/koha/admin/columns_settings.pl

Hi Frédéric, I have no resources at the moment to implement a solution based on columns_settings.pl Since my patch resolves a bug that leads to a software error, I propose to use it as an immediate solution and then file a new bug for the solution you propose. What do you think about? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #12 from Marc Véron <veron@veron.ch> --- (In reply to Aleisha Amohia from comment #11)

Is this bug still valid? I can't see the StatisticFields syspref in version 3.23

Sorry, that was a typo in the first comment and the test plan. It is StatisticsFields -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #14 from Marc Véron <veron@veron.ch> --- Hmm, it applies here... Applying: Bug 12721 - Prevent software error if incorrect fieldnames given in sypref StatisticsFields Applying: Bug 12721 - Syspref StatisticsFields: Warning on About page and text change in System preferences Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/about.tt Auto-merging about.pl -- You are receiving this mail because: You are watching all bug changes.