[Bug 35574] New: Bookings page should require only manage_bookings permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Bug ID: 35574 Summary: Bookings page should require only manage_bookings permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Currently it requires 'circulate => 1' I believe it should be 'circulate => "manage_bookings"' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159851&action=edit Bug 35574: Bookings tab from biblio details should only require manage_bookings permission TO test: 1 - Find or create a staff user 2 - Grant permissions: circulate: manage_bookings, circ_remaining_permissions catalogue 3 - Open a record details, go to items tab, mark an item as bookable 4 - Sign out and sign in as the patron above (or use a private window to sign in) 5 - Place a booking on the record located above 6 - Success 7 - Try to view the bookings tab 8 - Fail, you don't have permission 9 - Apply patch 10 - Success! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Depends on| |29002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159851|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159852&action=edit Bug 35574: Bookings tab from biblio details should only require manage_bookings permission TO test: 1 - Find or create a staff user 2 - Grant permissions: circulate: manage_bookings, circ_remaining_permissions catalogue 3 - Open a record details, go to items tab, mark an item as bookable 4 - Sign out and sign in as the patron above (or use a private window to sign in) 5 - Place a booking on the record located above 6 - Success 7 - Try to view the bookings tab 8 - Fail, you don't have permission 9 - Apply patch 10 - Success! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159853&action=edit Bug 35574: Correct api permission for listing biblio specific bookings To test: 1 - Follow above plan and apply only first patch 2 - Not the table does not load (403: Forbidden) 3 - Apply this patch 4 - Reload 5 - Success! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159852|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159874&action=edit Bug 35574: Bookings tab from biblio details should only require manage_bookings permission TO test: 1 - Find or create a staff user 2 - Grant permissions: circulate: manage_bookings, circ_remaining_permissions catalogue 3 - Open a record details, go to items tab, mark an item as bookable 4 - Sign out and sign in as the patron above (or use a private window to sign in) 5 - Place a booking on the record located above 6 - Success 7 - Try to view the bookings tab 8 - Fail, you don't have permission 9 - Apply patch 10 - Success! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159875&action=edit Bug 35574:Correct api permission for listing biblio specific bookings To test: 1 - Follow above plan and apply only first patch 2 - Not the table does not load (403: Forbidden) 3 - Apply this patch 4 - Reload 5 - Success! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159876&action=edit Bug 35574: Add unit tests for api change We add the corresponding unit tests for the biblio/bookings endpoint to ensure no regressions in the future. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159853|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159874|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159877&action=edit Bug 35574: Bookings tab from biblio details should only require manage_bookings permission TO test: 1 - Find or create a staff user 2 - Grant permissions: circulate: manage_bookings, circ_remaining_permissions catalogue 3 - Open a record details, go to items tab, mark an item as bookable 4 - Sign out and sign in as the patron above (or use a private window to sign in) 5 - Place a booking on the record located above 6 - Success 7 - Try to view the bookings tab 8 - Fail, you don't have permission 9 - Apply patch 10 - Success! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159878&action=edit Bug 35574: Correct api permission for listing biblio specific bookings To test: 1 - Follow above plan and apply only first patch 2 - Not the table does not load (403: Forbidden) 3 - Apply this patch 4 - Reload 5 - Success! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159876|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159879&action=edit Bug 35574: Add unit tests for api change We add the corresponding unit tests for the biblio/bookings endpoint to ensure no regressions in the future. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159875|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159880&action=edit Bug 35574: Don't show the link either This patch adds the check for permission to the biblio menu item too. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35468 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159877|0 |1 is obsolete| | Attachment #159878|0 |1 is obsolete| | Attachment #159879|0 |1 is obsolete| | Attachment #159880|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159886&action=edit Bug 35574: Bookings tab from biblio details should only require manage_bookings permission TO test: 1 - Find or create a staff user 2 - Grant permissions: circulate: manage_bookings, circ_remaining_permissions catalogue 3 - Open a record details, go to items tab, mark an item as bookable 4 - Sign out and sign in as the patron above (or use a private window to sign in) 5 - Place a booking on the record located above 6 - Success 7 - Try to view the bookings tab 8 - Fail, you don't have permission 9 - Apply patch 10 - Success! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Current status: Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159887&action=edit Bug 35574: Correct api permission for listing biblio specific bookings To test: 1 - Follow above plan and apply only first patch 2 - Not the table does not load (403: Forbidden) 3 - Apply this patch 4 - Reload 5 - Success! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159888&action=edit Bug 35574: Add unit tests for api change We add the corresponding unit tests for the biblio/bookings endpoint to ensure no regressions in the future. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159889&action=edit Bug 35574: Don't show the link either This patch adds the check for permission to the biblio menu item too. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159890&action=edit Bug 35574: Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159886|0 |1 is obsolete| | Attachment #159887|0 |1 is obsolete| | Attachment #159888|0 |1 is obsolete| | Attachment #159889|0 |1 is obsolete| | Attachment #159890|0 |1 is obsolete| | --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159896&action=edit Bug 35574: Bookings tab from biblio details should only require manage_bookings permission TO test: 1 - Find or create a staff user 2 - Grant permissions: circulate: manage_bookings, circ_remaining_permissions catalogue 3 - Open a record details, go to items tab, mark an item as bookable 4 - Sign out and sign in as the patron above (or use a private window to sign in) 5 - Place a booking on the record located above 6 - Success 7 - Try to view the bookings tab 8 - Fail, you don't have permission 9 - Apply patch 10 - Success! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159897&action=edit Bug 35574: Correct api permission for listing biblio specific bookings To test: 1 - Follow above plan and apply only first patch 2 - Not the table does not load (403: Forbidden) 3 - Apply this patch 4 - Reload 5 - Success! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159898&action=edit Bug 35574: Add unit tests for api change We add the corresponding unit tests for the biblio/bookings endpoint to ensure no regressions in the future. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159899&action=edit Bug 35574: Don't show the link either This patch adds the check for permission to the biblio menu item too. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159900&action=edit Bug 35574: Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Trivial fix. QA script happy. Lots of missing tests added. Yay! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #23 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574 Bug 35574 depends on bug 29002, which changed state. Bug 29002 Summary: Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org