https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17500 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56867&action=edit Bug 17500: Implement a very basic patron search -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17500 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56869&action=edit Bug 17500: Display branchname and category description TODO display category_type -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17500 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56871&action=edit Bug 17500: Display correct total values -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17500 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This patchset is a POC and cannot be pushed as it for several reasons: - we will need to rethink the existing code as we would need to index/search something else than bibliographic records. And the code is too bib-centric at the moment - the patron attributes are not indexed and so not searchable - the index is not maintained when a patron record is updated - it makes ES mandatory as it removes the existing MySQL search. We will need to let the ability to choose/switch between both (at least for a given period). It highlights the fact that we need to abstract our Elasticsearch code to make it more powerful and extensive. Moreover there is something hard to fix: at the moment it's possible to sort the table by library name or patron category name. But as we only index the code it is possible to order the results by these 2 fields, and it won't be possible unless we index them. But ofc if we index them, we will have to reindex everything if the description is updated in the admin config. Note that we will have this problematic for bibliographic records very soon as well and we will have to decide what to do. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17500 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17500 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61482&action=edit Bug 17500: Add a script to reindex patrons -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17500 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61484&action=edit Bug 17500: Index category_type to make searchable and display from the ES results -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17500 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61486&action=edit Bug 17500: implement order by -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17500 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit | |y.org | Component|Patrons |Searching - Elasticsearch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17500 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #7)

- we will need to rethink the existing code as we would need to index/search something else than bibliographic records. And the code is too bib-centric at the moment

I think this can be done - I think is a good opportunity to consider accessing ElasticSearch via perl modules from ES and not through catmandu

- the patron attributes are not indexed and so not searchable

Yup

- the index is not maintained when a patron record is updated

Yup

- it makes ES mandatory as it removes the existing MySQL search. We will need to let the ability to choose/switch between both (at least for a given period).

If it replicates close enough I think this is a good opportunity to turn ES on by default, then search testing is possible for all

It highlights the fact that we need to abstract our Elasticsearch code to make it more powerful and extensive. Moreover there is something hard to fix: at the moment it's possible to sort the table by library name or patron category name. But as we only index the code it is possible to order the results by these 2 fields, and it won't be possible unless we index them. But ofc if we index them, we will have to reindex everything if the description is updated in the admin config. Note that we will have this problematic for bibliographic records very soon as well and we will have to decide what to do.

I think the descriptions don't change very often - a warning that things need to be reindexed I think suffices. Bug 18950 proposed allowing user to reindex, however, I think safer is to allow user to request reindex, then handle on server by it staff to check if reindex requested and schedule. Bug 18948 also serves to ease reindexing by doing it in the background and preserving searching while done. Paves the way for allowing changes to mappings/descriptions etc and only committing on reindex -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17500 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Assignee|jonathan.druart+koha@gmail. |koha-bugs@lists.koha-commun |com |ity.org Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.