[Bug 6268] New: Bad Total in basket.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 Bug #: 6268 Summary: Bad Total in basket.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: christophe.croullebois@biblibre.com QAContact: koha-bugs@lists.koha-community.org The total_est_gste or gsti is computed on the total_rrp_gste or gsti. But in the budget this amount is the sum of discounts computed for each line. Due to the rounding to 2 decimal places this produces a difference in Funds view with Total sublevels spent. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 --- Comment #1 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-04-26 08:53:42 UTC --- Created attachment 4005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4005 proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> 2011-05-09 16:02:24 UTC --- Christophe, this patch doesn't apply anymore, can you rebase it pls ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4005|0 |1 is obsolete| | --- Comment #3 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-05-16 10:20:28 UTC --- Created attachment 4124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4124 new proposed patch Paul, I hope this one is ok. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-18 06:03:19 UTC --- When I try to access an existing basket I get following perl error: Global symbol "$i" requires explicit package name at /home/katrin/kohaclone/acqui/basket.pl line 255. Execution of /home/katrin/kohaclone/acqui/basket.pl aborted due to compilation errors. After switching back to my master branch it works ok. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-05-23 09:16:25 UTC --- Step to reproduce: * customer with a discount (10%) * add a line with a decimal price, qty 10 (10.25€, qty 10) * the total is wrong -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-23 09:17:17 UTC --- Paul, there was a perl error - I think we need a new patch first. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff AssignedTo|henridamien@koha-fr.org |paul.poulain@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4124|0 |1 is obsolete| | --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-05-23 09:45:11 UTC --- Created attachment 4223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4223 updated and signed-off patch Please another signoff requested. The total is now the sum of the individual lines, it's no more the discount of the total. Without this patch, the total can be X on basket.pl and a different value on budget pages, resulting in a difference between baskets and budget spended ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-23 20:34:24 UTC --- Created attachment 4240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4240 screenshot 1: adding new order I am not convinced the calculation is right. I tried your example: 10 copies for 10.25 each with a 10% discount from the vendor. I calculated a total of 92.25. What Koha calculates depends: The value calculated on the entry form is 92.25 The value shown in my basket summary table and when modifying my order line is 92.20 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-23 20:35:07 UTC --- Created attachment 4241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4241 screenshot 2: modifying same order -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2011-05-30 11:33:32 UTC --- OK, I think we should investigate a little bit more what should be the behaviour. If you order 10 items, 5.25 each, with a 10% discount, how much will it cost ? Must the rounding be applied on the discounted total, or a discount calculated to the total ? IE : 10*5.25*0.90 is 10*4,72 = 47.2 or 52.50*0.9 = 47.25 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-30 11:37:59 UTC --- Hi Paul, you are right, we have to agree on one calculation and make it work the same everywhere. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2011-05-30 12:01:11 UTC --- I've asked my accountant to know what is the legal rule (at least in France) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> 2011-06-06 12:49:39 UTC --- "bad" news from my accountant : there is no rule, we can choose whatever we want. So, what do we want ? (should I send a mail to koha-dev ?) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-06-15 06:01:46 UTC --- Apparently vendors can do both on their bills, so there is no real solution to this without making it overly complicated. I am not sure, but I think by the way we save prices calculating the discount per book might be easier to realize? So when receiving books prices will always add up correctly to the calculated sum without running into rounding problems. IE : 10*5.25*0.90 is 10*4,72 = 47.2 Could you send a follow-up for the entry form? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4223|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-06-15 07:14:08 UTC --- Created attachment 4469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4469 Signed off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-06-15 07:15:00 UTC --- Created attachment 4470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4470 Screenshot showing wrong totals on basket summary page -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-06-15 07:22:25 UTC --- Patch does what it says - it corrects the totals on the basket summary page. Before patch: Entry form: 9.22, total 92.25 Basket summary page: 9.22, total 92.20 AND 92.25 (!) Budgets on acq home page: 92.20 After patch: Entry form: 9.22, total 92.25 Basket summary page: 9.22, total always 92.20 Budgets on acq home page: 92.20 Still 2 things: 10.25 - 10% is calculated as 9.22 almost everywhere now. Exact price is: 9.225 - why not round to 9.23? The entry form should also calculate 92.20. Follow-up needed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> 2011-06-29 19:11:36 UTC --- Created attachment 4532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4532 follow up patch for the form -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> 2011-06-29 19:12:25 UTC --- katrin, can you sign-off my follow-up too please. it's a one line patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4532|0 |1 is obsolete| | --- Comment #20 from Chris Cormack <chris@bigballofwax.co.nz> 2011-07-04 23:08:26 UTC --- Created attachment 4555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4555 BZ6268 follow-up for the form This follow up fixes cait request to calculate the form like the budget Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch Status|Signed Off |Passed QA --- Comment #21 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-06 11:47:40 UTC --- This patch is minor. I've not written it despite what is stored in the patch owner (written by Christophe) Marking passed QA just before the string freeze, Chris, object if you want -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6268 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #22 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-06 22:11:36 UTC --- Signed off by Katrin, who knows acquisitions well. I have no issues with pushing it -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org