[Bug 27364] New: Making previous patron cardnumbers searchable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 Bug ID: 27364 Summary: Making previous patron cardnumbers searchable Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fiona.borthwick@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 18626 introduced the logging of changes to patron cardnumbers which is great, but this still does not link together previous cardnumbers. Imagine this scenario: A library patron loses their library card. They are issued with a replacement. Old and new cardnumbers are recorded in the Modification log. The old card is found (doesn't matter who finds it) and brought to the library. A member of library staff scan the barcode - get no results. This means they are none the wiser as to who this card belonged to. Would it not be a good idea to allow previous cardnumbers to be searchable? Some libraries may record this information somewhere in the patron record, but a search by cardnumber would be extremely helpful. It would be useful if the cardnumber moved into a linked field automatically when a new cardnumber was entered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39452 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jake.deery@openfifth.co.uk |ity.org | CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 susan.murphy@kcpls.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |susan.murphy@kcpls.org --- Comment #1 from susan.murphy@kcpls.org --- We really don't want them searchable or usable BUT do want staff to be able to see them without giving staff access to the modification logs. Mostly for troubleshooting the eResources where patrons used their old card to set up their accounts and now they have a new card that doesn't recognize them. Hoopla is our biggest issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jake.deery@openfifth.co.uk |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jake.deery@openfifth.co.uk |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 --- Comment #2 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 193836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193836&action=edit Bug 27364: Add historic_cardnumbers to Patron object & API This patch adds an historic_cardnumbers field to the patron object, staff client, and API call (which will return an array of objects containing information about the cardnumber and when it was changed). TO TEST: == APPLY PATCH == a) Ensure 'CardnumberLog' is on in the sysprefs b) Change the koha user's cardnumber from 42 to 67 c) Reverse step b) d) Go to the koha user's details page *) note how there is a historic cardnumbers box *) note how each change is marked, next to the date and time performed *) note how the time is accurate to minutes e) Go to /api/v1/patrons/51 *) notice how the historic_cardnumbers array is populated with two objects *) each object is per cardnumber change *) each object contains the new and old cardnumber, as well as the timestamp of the transaction == RESET_ALL == f) repeat steps d-e *) notice how the historic cardnumbers section is missing if no cardnumber change has occured, on the patron details page *) notice how the historic_cardnumbers array is empty in the api call, if no cardnumber change has occured == SIGN OFF == -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39452 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 [Bug 39452] Log cardnumber changes as distinct action within borrower logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34000 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I think the structure of the logs has changed since this was written, my entries don't have before/after, they look like: action_id: 25 timestamp: 2026-04-21 11:43:37 user: 51 module: MEMBERS action: MODIFY_CARDNUMBER object: 33 info: {"cardnumber":"23529000526047b"} interface: intranet script: NULL trace: NULL diff: {"D":{"cardnumber":{"O":"23529000526047a","N":"23529000526047b"}}} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 Jake Deery (kwenoch) <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193836|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 --- Comment #4 from Jake Deery (kwenoch) <jake.deery@openfifth.co.uk> --- Created attachment 208084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208084&action=edit Bug 27364: Add historic_cardnumbers to Patron object & API This patch adds an historic_cardnumbers field to the patron object, staff client, and API call (which will return an array of objects containing information about the cardnumber and when it was changed). TO TEST: == APPLY PATCH == a) Ensure 'CardnumberLog' is on in the sysprefs b) Change the koha user's cardnumber from 42 to 67 c) Reverse step b) d) Go to the koha user's details page *) note how there is a historic cardnumbers box *) note how each change is marked, next to the date and time performed *) note how the time is accurate to minutes e) Go to /api/v1/patrons/51 *) notice how the historic_cardnumbers array is populated with two objects *) each object is per cardnumber change *) each object contains the new and old cardnumber, as well as the timestamp of the transaction == RESET_ALL == f) repeat steps d-e *) notice how the historic cardnumbers section is missing if no cardnumber change has occured, on the patron details page *) notice how the historic_cardnumbers array is empty in the api call, if no cardnumber change has occured == SIGN OFF == -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 Jake Deery (kwenoch) <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208084|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 --- Comment #5 from Jake Deery (kwenoch) <jake.deery@openfifth.co.uk> --- Created attachment 208092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208092&action=edit Bug 27364: Add historic_cardnumbers to Patron object & API This patch adds an historic_cardnumbers field to the patron object, staff client, and API call (which will return an array of objects containing information about the cardnumber and when it was changed). TO TEST: == APPLY PATCH == a) Ensure 'CardnumberLog' is on in the sysprefs b) Change the koha user's cardnumber from 42 to 67 c) Reverse step b) d) Go to the koha user's details page *) note how there is a historic cardnumbers box *) note how each change is marked, next to the date and time performed *) note how the time is accurate to minutes e) Go to /api/v1/patrons/51 *) notice how the historic_cardnumbers array is populated with two objects *) each object is per cardnumber change *) each object contains the new and old cardnumber, as well as the timestamp of the transaction == RESET_ALL == f) repeat steps d-e *) notice how the historic cardnumbers section is missing if no cardnumber change has occured, on the patron details page *) notice how the historic_cardnumbers array is empty in the api call, if no cardnumber change has occured == SIGN OFF == -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 Jake Deery (kwenoch) <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Jake Deery (kwenoch) <jake.deery@openfifth.co.uk> --- Thanks Nick, This has been updated now, so it should work with the new JSON diff action logs! Ta, Jake -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208092|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 --- Comment #7 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 208407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208407&action=edit Bug 27364: Add historic_cardnumbers to Patron object & API This patch adds an historic_cardnumbers field to the patron object, staff client, and API call (which will return an array of objects containing information about the cardnumber and when it was changed). TO TEST: == APPLY PATCH == a) Ensure 'CardnumberLog' is on in the sysprefs b) Change the koha user's cardnumber from 42 to 67 c) Reverse step b) d) Go to the koha user's details page *) note how there is a historic cardnumbers box *) note how each change is marked, next to the date and time performed *) note how the time is accurate to minutes e) Go to /api/v1/patrons/51 *) notice how the historic_cardnumbers array is populated with two objects *) each object is per cardnumber change *) each object contains the new and old cardnumber, as well as the timestamp of the transaction == RESET_ALL == f) repeat steps d-e *) notice how the historic cardnumbers section is missing if no cardnumber change has occured, on the patron details page *) notice how the historic_cardnumbers array is empty in the api call, if no cardnumber change has occured == SIGN OFF == Signed-off-by: John Vinke <jvinke@austinseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org