[Bug 34601] New: Cannot manage suggestions without CSRF error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Bug ID: 34601 Summary: Cannot manage suggestions without CSRF error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Make a suggestion 2. Try to edit, delete, or manage the suggestion. 3. Error: The form submission failed (Wrong CSRF token). Try to come back, refresh the page, then try again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22990 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- It looks like the params->{module} doesn't get passed so it output_and_exit_if_error exits. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 154719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154719&action=edit Bug 34601: Pass module into params 1. Make a suggestion 2. Try to edit, delete, or manage the suggestion. 3. Error: 4. Apply patch and restart_all 5. Try again and you should not get the error anymore. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Koha |Circulation Group|Koha security | QA Contact| |testopia@bugs.koha-communit | |y.org Product|Koha security |Koha CC| |gmcharlt@gmail.com, | |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Lucas, please remember to run the new perltidy on your changes and the QA test tools! (I amended the patch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154724|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154747&action=edit Bug 34601: Fix edit/delete links on suggestion.tt 1. Make a suggestion 2. Try to edit, delete the suggestion. 3. Error: 4. Apply patch and restart_all 5. Try again and you should not get the error anymore. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154748&action=edit Bug 34601: (QA follow-up) Fix edit/delete links in toolbar We also need to fix the links in the toolbar visible when 'viewing' the suggestion. 1) Create a suggestion 2) Click on the title 3) Click edit > CSRF error 4) Click delete link in toolbar > CSRF error 5) Apply patch and repeat Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 154762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154762&action=edit Bug 34601: [22.11.x]Fix edit/delete links on suggestion.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Lucas, did you see my follow-up? the original patch was incomplete. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #10)
Lucas, did you see my follow-up? the original patch was incomplete.
Yes, I did. Thanks! I squashed those together for the 22.11 one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #11)
(In reply to Katrin Fischer from comment #10)
Lucas, did you see my follow-up? the original patch was incomplete.
Yes, I did. Thanks! I squashed those together for the 22.11 one.
All good then :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Beware.. I think the archive/unarchive links also need the same treatment ;P -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'll look into providing another follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #13)
Beware.. I think the archive/unarchive links also need the same treatment ;P
I just tested the archiving and unarchiving of a suggestion and they still work without any error with the other 2 patches applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154762|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Excellent, that's good news. Thanks for testing it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- The need for the follow-up makes it suspicious. Aren't we over-requiring CSRF tokens here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ich, Typo in commit of master : https://git.koha-community.org/Koha-community/Koha/src/commit/7d5dc65867a550... <a class="deletesuggestion" href="suggestion.pl?op=delete&suggestionid=[% s.suggestionid | html %]"&csrf_token=[% csrf_token | html %]> Double quote misplaced. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #20 from Kelly McElligott <kelly@bywatersolutions.com> --- Can we get this backported? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 154951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154951&action=edit Bug 34601: Fix wrong quote Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Fridolin Somers from comment #19)
Ich,
Typo in commit of master :
Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Joseph Alway <jbalway@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbalway@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34080 CC| |matt.blenkinsop@ptfs-europe | |.com, | |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #23 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 --- Comment #24 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 --- Comment #25 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Thanks for the 22.11 patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 apirak <apirak@punsarn.asia> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |apirak@punsarn.asia --- Comment #26 from apirak <apirak@punsarn.asia> --- It happend on 22.05.15. Can we get this backported? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 --- Comment #27 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 156122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156122&action=edit Bug 34601: [22.05.x] Fix edit/delete links on suggestion.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.04,22.11.10 |23.11.00,23.05.04,22.11.10, released in| |22.05.16 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #28 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34601 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org