[Bug 15899] New: Remove the use of recordpayment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Bug ID: 15899 Summary: Remove the use of recordpayment Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org With recordpayment now simply being a wrapper round Koha::Account::pay, we can remove the calls to recordpayment and replace them with direct calls to Koha::Account::pay. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15895 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15895 [Bug 15895] Add Koha::Account module, use Koha::Account::pay internally for recordpayment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15900 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 [Bug 15900] Remove use of recordpayment in ProcessOfflinePayment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15901 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15901 [Bug 15901] Remove use of recordpayment in C4::SIP::ILS::Transaction::FeePayment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15902 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 [Bug 15902] Remove use of recordpayment in process_koc.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15903 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15903 [Bug 15903] Remove use of recordpayment in paycollect.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 [Bug 15894] Unify all account fine payment functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 48343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48343&action=edit Bug 15899 - Fix up unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 48344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48344&action=edit Bug 15899 - Remove C4::Accounts::recordpayment Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) git grep recordpayment should show no calls to the recordpayment sub -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48344|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 48345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48345&action=edit Bug 15899 - Remove C4::Accounts::recordpayment Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) git grep recordpayment should show no calls to the recordpayment sub -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48343|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52137&action=edit Bug 15899 - Fix up unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52137|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52146&action=edit Bug 15899 - Fix up unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48345|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52147&action=edit Bug 15899 - Remove C4::Accounts::recordpayment Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) git grep recordpayment should show no calls to the recordpayment sub -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52146|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 54749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54749&action=edit Bug 15899 - Fix up unit tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52147|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 54750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54750&action=edit Bug 15899 - Remove C4::Accounts::recordpayment Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) git grep recordpayment should show no calls to the recordpayment sub Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54749|0 |1 is obsolete| | Attachment #54750|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55878&action=edit Bug 15899 - Fix up unit tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55879&action=edit Bug 15899 - Remove C4::Accounts::recordpayment Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) git grep recordpayment should show no calls to the recordpayment sub Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18580 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18580 [Bug 18580] Account-pay does not apply credits / clear old fines as did recordpayment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21915 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 [Bug 21915] Add a way to automatically reconcile balance for patrons -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org