[Bug 23824] New: Add a ‘Save and run’ button to reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Bug ID: 23824 Summary: Add a ‘Save and run’ button to reports Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org It would be really helpful if there was a ‘Save and run’ button when you are editing a report. It would save one click compared to the current ‘Save’ then ‘Run’. If you are developing a report iteratively it adds up... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com --- Comment #1 from Lisette Scheer <lisetteslatah@gmail.com> --- This would be very helpful when writing reports! Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us --- Comment #2 from Rebecca Coert <rcoert@arlingtonva.us> --- This would be a useful feature and I'd like to have it available too! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Jeff Gaines <jgaine@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jgaine@arlingtonva.us --- Comment #3 from Jeff Gaines <jgaine@arlingtonva.us> --- I would like to see this, too. Saving one click does not seem like a lot, but it adds up over time, especially when writing and testing new queries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26437 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26437 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22659 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Michal Urban <michalurban177@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michalurban177@gmail.com Assignee|koha-bugs@lists.koha-commun |michalurban177@gmail.com |ity.org | Status|NEW |Needs Signoff --- Comment #4 from Michal Urban <michalurban177@gmail.com> --- Created attachment 137764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137764&action=edit Bug 23824: Add a Save and Run button to reports Added a setting within the Guided SQL Reports create and edit report interfaces. This allows admins to bypass the need to go to the Edit SQL page to run reports and run a report after saving. To test: 1. Navigate to the reports screen in Koha admin, and create a SQL report 2. Create a report with "Run report after saving" switched to "Yes", save the report (Easy query for testing: "SELECT NOW();") 3. Notice that the report runs after saving 4. Navigate to the edit page for the report, edit the query, set "Run report after saving" to yes and update SQL 5. Notice that the report runs after updating in the Edit SQL page 6. Create a new report with "Run report after saving" set to "No", and save 7. Notice that you are redirected to the Edit SQL page 8. Edit the query with "Run report after saving" set to "No" and update SQL 9. Notice that the SQL updates and does not run -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel like this might be overthinking the issue a bit. The new field on top reqires you to set it every time you open and edit a report, which means extra clicks. It also looks like a field that would be stored in the database - but it isn't. So we might create a wrong impression there. What if we added another button next to 'Update SQL' that is 'Update SQL and run'? Or we could turn the button into a split button with the current behaviour pre-selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 --- Comment #6 from Magnus Enger <magnus@libriotech.no> --- Created attachment 149080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149080&action=edit Bug 23824: Add a "Save and run" button to reports [alternative] This will save one click every time you want to save and then run a report. To test: - Apply this patch - Create a new report - Click the new "Update and run SQL" button - Verify the report was saved and the results are displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Magnus Enger <magnus@libriotech.no> --- I have taken the liberty of making a patch more in line with Katrin's suggestions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Needs Signoff |Patch doesn't apply --- Comment #8 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Magnus Enger from comment #7)
I have taken the liberty of making a patch more in line with Katrin's suggestions.
Patch did not apply. CONFLICT (content): Merge conflict in reports/guided_reports.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 23824: Add a Save and Run button to exports [33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149080|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149080|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137764|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #9 from Magnus Enger <magnus@libriotech.no> --- (In reply to Laura Escamilla from comment #8)
(In reply to Magnus Enger from comment #7)
I have taken the liberty of making a patch more in line with Katrin's suggestions.
Patch did not apply.
CONFLICT (content): Merge conflict in reports/guided_reports.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 23824: Add a Save and Run button to exports [33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m
Hm, it looks like there could be a problem because there were two patches. I have taken the liberty of obsoleting the first patch to test. Could you please try again now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149080|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 149433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149433&action=edit Bug 23824: Add a "Save and run" button to reports [alternative] This will save one click every time you want to save and then run a report. To test: - Apply this patch - Create a new report - Click the new "Update and run SQL" button - Verify the report was saved and the results are displayed Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Summary|Add a ‘Save and run’ button |Add a 'Save and run' button |to reports |to reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|michalurban177@gmail.com |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149724&action=edit Bug 23824: Add a "Save and run" button to reports This will save one click every time you want to save and then run a report. To test: - Apply this patch - Create a new report - Click the new "Update and run SQL" button - Verify the report was saved and the results are displayed Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149433|0 |1 is obsolete| | --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Comment on attachment 149433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149433 Bug 23824: Add a "Save and run" button to reports [alternative] Please obsolete patches that are not needed. This is confusing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It was my fault - I removed the [alternative] - git bz doesn't pick up on that automatically. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |marie-luce.laflamme@inlibro | |.com Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com --- Comment #16 from Andrii Nugged <nugged@gmail.com> --- IMPORTANT: You can not save this form in non-English interfaces anymore. I.e. this breaks how "Update" (saving form) works: in non-English Koha button's text gets translated, what is desired, and because of that also there was hidden: <input type="hidden" name="phase" value="Update SQL" /> which wasn't translated (excluded from translations). And, if the button's content is translated, so in reports/guided_reports.pl contents of the "phase" parameter compared with hardcoded "Update SQL", which is not anymore English. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 --- Comment #17 from Magnus Enger <magnus@libriotech.no> --- Gah! I knew there was a catch here... So, what is the best thing to do? Add an "op" parameter that does not get translated, like we do in lots of other places? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33966 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please report new bugs linked to the original one once the bug has been released. Otherwise it's too easy to miss these and we will always need a new bug anyway. Confirmed :( and reported as: Bug 33966 - "Update and run SQL" for non-English templates Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33966 [Bug 33966] "Update and run SQL" for non-English templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35672 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672 [Bug 35672] Update and Run SQL button should save changes even if report fails to run -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org