https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36528 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36528 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This patch contains changes to global.js automatically applied on commit by prettier. I'm not sure if that's the expected behavior or not. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36528 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164487|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 164492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164492&action=edit Bug 36528: Correct JS assets included in self checkout slip template The self checkout's slip print template includes some assets which it doesn't need (enquire.js) and lacks other that it does (i18n-related files). This patch correct the problem. The patch also wraps some code in global.js with a check that the relevant library has been loaded so that we don't get errors when the asset isn't included. To test, apply the patch and clear your browser cache. - With WebBasedSelfCheck enabled, log in to the self checkout module and check some items out. - Click "Finish" and then "Print receipt..." - Check the browser console on the receipt page. There should be no errors. - Log in to the OPAC and click the "Messaging" tab on the patron summary page. - Test that the "Digests only" table heading icon shows a tooltip. - Test that enquire.js is still loading correctly by performing a catalog search and narrowing your browser. When the window is narrow enough, the facets sidebar should collapse into a "Refine your search" button. Note that the "js_in_body" qa warning is a false positive. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36528 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164492|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166888&action=edit Bug 36528: Correct JS assets included in self checkout slip template The self checkout's slip print template includes some assets which it doesn't need (enquire.js) and lacks other that it does (i18n-related files). This patch correct the problem. The patch also wraps some code in global.js with a check that the relevant library has been loaded so that we don't get errors when the asset isn't included. To test, apply the patch and clear your browser cache. - With WebBasedSelfCheck enabled, log in to the self checkout module and check some items out. - Click "Finish" and then "Print receipt..." - Check the browser console on the receipt page. There should be no errors. - Log in to the OPAC and click the "Messaging" tab on the patron summary page. - Test that the "Digests only" table heading icon shows a tooltip. - Test that enquire.js is still loading correctly by performing a catalog search and narrowing your browser. When the window is narrow enough, the facets sidebar should collapse into a "Refine your search" button. Note that the "js_in_body" qa warning is a false positive. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36528 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Easy fix, well tested, no string changes. QA script failure is noted in the bug as a false positive. Pushing :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36528 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36528 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- In 23.11.x path lib/enquire.min.js is correct but patch still applies to remove this asset and changes in global.js -- You are receiving this mail because: You are watching all bug changes.