[Bug 41931] New: While creating EasyAnalitics empty subfields are created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 Bug ID: 41931 Summary: While creating EasyAnalitics empty subfields are created Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: januszop@gmail.com Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl While creating EasyAnalitics empty subfields are (often) created. In C4::Biblio::PrepHostMarcField a whole set of subfields is addes to the field 773 regardless if a respective value exists or not. This often creates empty subfields and generates warnings. To reproduce: 1. Set EasyAnalyticalRecords to Show. 2. Go to biblio #1, copy the barcode. 3. Go to biblio #2, chose Edit > Link to host record > enter the barcode. 4. Examine the biblio #2: a) a new "virtual" item from biblio #1 is being displayed; b) a 773 field has been inserted, but with empty subfields $d & $x). 5. There should be warnings in plack-intranet-error.log like: [WARN] Use of uninitialized value in join or string at /usr/share/perl5/MARC/Field.pm line 696. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 193858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193858&action=edit Bug 41931: While creating EasyAnalitics empty subfields are (often) created. In C4::Biblio::PrepHostMarcField a whole set of subfields is addes to the field 773 regardless if a respective value exists or not. This often creates empty subfields and generates warnings. Test plan: ========== 1. Set EasyAnalyticalRecords to Show. 2. Go to biblio #1, copy the barcode. 3. Go to biblio #2, chose Edit > Link to host record > enter the barcode. 4. Examine the biblio #2: a) a new "virtual" item from biblio #1 is being displayed; b) a 773 field has been inserted, but with empty subfields $d & $x. 5. There should be warnings in plack-intranet-error.log like: [WARN] Use of uninitialized value in join or string at /usr/share/perl5/MARC/Field.pm line 696. 6. Apply the patch ; restart_all. 7. Go to biblio #3 (!), chose Edit > Link to host record > enter the barcode. 8. Examine the biblio #3: a) a new "virtual" item from biblio #1 is being displayed; b) a 773 field has been inserted, with no empty subfields. 9. No new warnings. Sponsored-by: Ignatianum University in Cracow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 --- Comment #2 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 193859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193859&action=edit Bug 41931: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Ignatianum University in list of Sponsors| |Cracow Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193858|0 |1 is obsolete| | Attachment #193859|0 |1 is obsolete| | --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 193916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193916&action=edit Bug 41931: While creating EasyAnalitics empty subfields are (often) created. In C4::Biblio::PrepHostMarcField a whole set of subfields is addes to the field 773 regardless if a respective value exists or not. This often creates empty subfields and generates warnings. Test plan: ========== 1. Set EasyAnalyticalRecords to Show. 2. Go to biblio #1, copy the barcode. 3. Go to biblio #2, chose Edit > Link to host record > enter the barcode. 4. Examine the biblio #2: a) a new "virtual" item from biblio #1 is being displayed; b) a 773 field has been inserted, but with empty subfields $d & $x. 5. There should be warnings in plack-intranet-error.log like: [WARN] Use of uninitialized value in join or string at /usr/share/perl5/MARC/Field.pm line 696. 6. Apply the patch ; restart_all. 7. Go to biblio #3 (!), chose Edit > Link to host record > enter the barcode. 8. Examine the biblio #3: a) a new "virtual" item from biblio #1 is being displayed; b) a 773 field has been inserted, with no empty subfields. 9. No new warnings. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 --- Comment #4 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 193917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193917&action=edit Bug 41931: Unit tests Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|While creating |While creating |EasyAnalitics empty |EasyAnalytics empty |subfields are created |subfields are created -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Could we please have another signoff here? See wiki, Dvelopment workflow: Preferably, patch writer and patch signer should not be from the same company or organisation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193916|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193917|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 198216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198216&action=edit Bug 41931: While creating EasyAnalitics empty subfields are (often) created. In C4::Biblio::PrepHostMarcField a whole set of subfields is addes to the field 773 regardless if a respective value exists or not. This often creates empty subfields and generates warnings. Test plan: ========== 1. Set EasyAnalyticalRecords to Show. 2. Go to biblio #1, copy the barcode. 3. Go to biblio #2, chose Edit > Link to host record > enter the barcode. 4. Examine the biblio #2: a) a new "virtual" item from biblio #1 is being displayed; b) a 773 field has been inserted, but with empty subfields $d & $x. 5. There should be warnings in plack-intranet-error.log like: [WARN] Use of uninitialized value in join or string at /usr/share/perl5/MARC/Field.pm line 696. 6. Apply the patch ; restart_all. 7. Go to biblio #3 (!), chose Edit > Link to host record > enter the barcode. 8. Examine the biblio #3: a) a new "virtual" item from biblio #1 is being displayed; b) a 773 field has been inserted, with no empty subfields. 9. No new warnings. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 198217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198217&action=edit Bug 41931: Unit tests Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- While I'm not that familiar with analytical records, I muddled my way through. Testing notes (using KTD): 1. I picked two random records, and linked: - Programming Perl (262) - CGI programming with Perl (11) - Linked barcode 39999000011418 (from Programming Perl) to CGI programming with Perl - For CGI programming with Perl, the 773 has a 773$d, but doesn't have a 773$x (Programming Perl has a Place, publisher, and date of publication, but no International Standard Serial Number) 2. There were warning messages in the log: vi /var/log/koha/kohadev/plack-intranet-error.log 3. After the patch, I removed the linked record and then re-linked. 4. The 773 in the host record (CGI programming with Perl) now only had entries for subfields that had values. 5. The tests passed: prove t/db_dependent/Biblio.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #9 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- I get the warning in logs but I have no issue with 773$x or 773$d, does it require the corresponding field to be missing ? (which I have no idea what it is) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43031 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43031 [Bug 43031] Construct more complete 773 content when creating a child record using EasyAnalytics -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 --- Comment #10 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- See bug 43031 which removes PrepHostMarcField -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41931 Bug 41931 depends on bug 43031, which changed state. Bug 43031 Summary: Construct more complete 773 content when creating a child record using EasyAnalytics https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43031 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org