[Bug 41970] New: PA_CLASS does not show in fieldset ID on opac-memberentry.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41970 Bug ID: 41970 Summary: PA_CLASS does not show in fieldset ID on opac-memberentry.pl Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org The PA_CLASS description shows on opac-memberentry.pl but the code doesn't show in the fieldset ID. This leads to each fieldset having the same ID of "aai_". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41970 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41970 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 194369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194369&action=edit Bug 41970: Fix typo in pa_class in template This change fixes a typo from pa_loo to pa_class, so that the ID attribute of the fieldset is properly set when using PA_CLASS to group patron attributes. Test plan: 0. Set up two PA_CLASS values 1. Set up two patron attributes which are viewable/editable on the OPAC and assign them one class each 2. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 3. Look at the HTML and note that fieldsets for both PA classes have the ID of "aai_" 4. Apply the patch 5. Reload the page http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 6. Note that now the fieldsets have ID attributes of "aai_<PA_CLASS code>". 7. Rejoice as now it's easier to use Javascript and CSS and have valid HTML! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41970 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41970 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41970 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194369|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 194370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194370&action=edit Bug 41970: Fix typo in pa_class in template This change fixes a typo from pa_loo to pa_class, so that the ID attribute of the fieldset is properly set when using PA_CLASS to group patron attributes. Test plan: 0. Set up two PA_CLASS values 1. Set up two patron attributes which are viewable/editable on the OPAC and assign them one class each 2. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 3. Look at the HTML and note that fieldsets for both PA classes have the ID of "aai_" 4. Apply the patch 5. Reload the page http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 6. Note that now the fieldsets have ID attributes of "aai_<PA_CLASS code>". 7. Rejoice as now it's easier to use Javascript and CSS and have valid HTML! Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41970 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41970 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194370|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41970 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194371&action=edit Bug 41970: Fix typo in pa_class in template This change fixes a typo from pa_loo to pa_class, so that the ID attribute of the fieldset is properly set when using PA_CLASS to group patron attributes. Test plan: 0. Set up two PA_CLASS values 1. Set up two patron attributes which are viewable/editable on the OPAC and assign them one class each 2. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 3. Look at the HTML and note that fieldsets for both PA classes have the ID of "aai_" 4. Apply the patch 5. Reload the page http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 6. Note that now the fieldsets have ID attributes of "aai_<PA_CLASS code>". 7. Rejoice as now it's easier to use Javascript and CSS and have valid HTML! Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41970 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41970 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41970 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41970 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41970 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #6 from David Cook <dcook@prosentient.com.au> --- *** Bug 38764 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41970 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|26.05.00,25.11.04 |26.05.00,25.11.04,25.05.11 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41970 --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41970 --- Comment #8 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Correction: this was pushed for 25.05.11. --LE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41970 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting Version(s)|26.05.00,25.11.04,25.05.11 |26.05.00,25.11.04,25.05.11, released in| |24.11.16 CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #9 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.16 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org