[Bug 33687] New: Clicking on a sys pref sub-menu item does not scroll to that item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 Bug ID: 33687 Summary: Clicking on a sys pref sub-menu item does not scroll to that item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: pedro.amorim@ptfs-europe.com Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Depends on: 32926 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 [Bug 32926] Cannot expand or collapse some System preference sections after a search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 150740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150740&action=edit Bug 33687: Restore scroll to sub-tab Test plan: Go to sys prefs, click 'Enhanced Content' Click 'OverDrive', notice it doesnt scroll there Apply this patch: Do the same test plan, but notice it does scroll there, like before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150740|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150748&action=edit Bug 33687: Restore scroll to sub-tab Test plan: Go to sys prefs, click 'Enhanced Content' Click 'OverDrive', notice it doesnt scroll there Apply this patch: Do the same test plan, but notice it does scroll there, like before Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Working as expected, fixes the regression from bug 32926 without causing further issues. Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Clicking on a sys pref |Clicking on a system |sub-menu item does not |preference sub-menu item |scroll to that item |does not scroll to that | |item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is it possible this was already fixed elsewhere or is browser dependent? I just tried without the patches applied and it works for me (Enhanced content - Overdrive) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also: patch currently doesn't apply: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 33687: Restore scroll to sub-tab Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 33687: Restore scroll to sub-tab hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-33687-Restore-scroll-to-sub-tab-a82QmL.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 --- Comment #6 from Andreas Roussos <a.roussos@dataly.gr> --- (In reply to Katrin Fischer from comment #4)
Is it possible this was already fixed elsewhere or is browser dependent? Please see earlier Bug 33634, looks like it was fixed there. However, as per the patch Pedro has provided here, the TT filter for the TAB.tab_id variable needs to be 'htmlId' instead of 'html'.
(In reply to Katrin Fischer from comment #5)
Also: patch currently doesn't apply: Looks like the same line (line 200) in the template file was modified by commit 0d1278aa14b from Bug 33634. That would explain why this patch currently doesn't apply.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Thanks everyone, yes this certainly is a duplicate of bug 33634 *** This bug has been marked as a duplicate of bug 33634 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org