[Bug 13853] New: Show waiting hold expiration date for waiting holds in holds ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Bug ID: 13853 Summary: Show waiting hold expiration date for waiting holds in holds ajax datatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com We should show the expiration date for waiting holds in the holds datatable that appears in circulation.pl and moremember.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Depends on| |13030 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36949&action=edit Bug 13853 - Show waiting hold expiration date for waiting holds in holds ajax datatable We should show the expiration date for waiting holds in the holds datatable that appears in circulation.pl and moremember.pl Test Plan: 1) Ensure ReservesMaxPickUpDelay is set 2) Place a hold on a record 3) Place a second hold and set it to waiting by checking it in 4) Place a third hold with an expiration date 5) View the holds tab on circulation.pl and moremember.pl 6) Note the first hold has no expiration date 7) Note the second hold has an expiration date of today + ReservesMaxPickUpDelay days 8) Note the thrid hold has an expiration date of whatever you set it to -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13517 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36949|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36984&action=edit Bug 13853 - Show waiting hold expiration date for waiting holds in holds ajax datatable We should show the expiration date for waiting holds in the holds datatable that appears in circulation.pl and moremember.pl Test Plan: 1) Ensure ReservesMaxPickUpDelay is set 2) Place a hold on a record 3) Place a second hold and set it to waiting by checking it in 4) Place a third hold with an expiration date 5) View the holds tab on circulation.pl and moremember.pl 6) Note the first hold has no expiration date 7) Note the second hold has an expiration date of today + ReservesMaxPickUpDelay days 8) Note the thrid hold has an expiration date of whatever you set it to -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36984|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39748&action=edit Bug 13853 - Show waiting hold expiration date for waiting holds in holds ajax datatable We should show the expiration date for waiting holds in the holds datatable that appears in circulation.pl and moremember.pl Test Plan: 1) Ensure ReservesMaxPickUpDelay is set 2) Place a hold on a record 3) Place a second hold and set it to waiting by checking it in 4) Place a third hold with an expiration date 5) View the holds tab on circulation.pl and moremember.pl 6) Note the first hold has no expiration date 7) Note the second hold has an expiration date of today + ReservesMaxPickUpDelay days 8) Note the thrid hold has an expiration date of whatever you set it to -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39748|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40026&action=edit Bug 13853 - Show waiting hold expiration date for waiting holds in holds ajax datatable We should show the expiration date for waiting holds in the holds datatable that appears in circulation.pl and moremember.pl Test Plan: 1) Ensure ReservesMaxPickUpDelay is set 2) Place a hold on a record 3) Place a second hold and set it to waiting by checking it in 4) Place a third hold with an expiration date 5) View the holds tab on circulation.pl and moremember.pl 6) Note the first hold has no expiration date 7) Note the second hold has an expiration date of today + ReservesMaxPickUpDelay days 8) Note the thrid hold has an expiration date of whatever you set it to -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40026|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40037&action=edit [SIGNED-OFF] Bug 13853 - Show waiting hold expiration date for waiting holds in holds ajax datatable We should show the expiration date for waiting holds in the holds datatable that appears in circulation.pl and moremember.pl Test Plan: 1) Ensure ReservesMaxPickUpDelay is set 2) Place a hold on a record 3) Place a second hold and set it to waiting by checking it in 4) Place a third hold with an expiration date 5) View the holds tab on circulation.pl and moremember.pl 6) Note the first hold has no expiration date 7) Note the second hold has an expiration date of today + ReservesMaxPickUpDelay days 8) Note the thrid hold has an expiration date of whatever you set it to Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Cathi Wiggins <CWIGGINS@ci.arcadia.ca.us> Signed-off-by: Megan Wianecki <mwianecki@mplmain.mtpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40417&action=edit Bug 13853: Add tests for is_waiting -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, Could you please provide tests for Koha::Item? Something else: On this page there are 2 places where the library is displayed. On top ("Holds waiting" block): Time (), by John D Hall Hold placed on 22/04/2015. Waiting at Le Cannet until 05/05/2015 Studio Ciné Live (000), by Philippe Boulnois [791] Hold placed on 18/06/2015. Waiting at Médiathèque Départementale de Prêt until 25/06/2015 In the table: Item is waiting here Item is waiting at Le Cannet Is it expected to have "here" in one case and the library name in the other case? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40037|0 |1 is obsolete| | Attachment #40417|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40673&action=edit Bug 13853 - Show waiting hold expiration date for waiting holds in holds ajax datatable We should show the expiration date for waiting holds in the holds datatable that appears in circulation.pl and moremember.pl Test Plan: 1) Ensure ReservesMaxPickUpDelay is set 2) Place a hold on a record 3) Place a second hold and set it to waiting by checking it in 4) Place a third hold with an expiration date 5) View the holds tab on circulation.pl and moremember.pl 6) Note the first hold has no expiration date 7) Note the second hold has an expiration date of today + ReservesMaxPickUpDelay days 8) Note the thrid hold has an expiration date of whatever you set it to Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Cathi Wiggins <CWIGGINS@ci.arcadia.ca.us> Signed-off-by: Megan Wianecki <mwianecki@mplmain.mtpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40674&action=edit Bug 13853: Add tests for is_waiting -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40675&action=edit Bug 13853 [QA Followup] - Add unit tests for branch getting methods -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> ---
In the table: Item is waiting here Item is waiting at Le Cannet
Is it expected to have "here" in one case and the library name in the other case?
Yes that is existing behavior and remains unchanged. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40673|0 |1 is obsolete| | Attachment #40674|0 |1 is obsolete| | Attachment #40675|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40755&action=edit Bug 13853 - Show waiting hold expiration date for waiting holds in holds ajax datatable We should show the expiration date for waiting holds in the holds datatable that appears in circulation.pl and moremember.pl Test Plan: 1) Ensure ReservesMaxPickUpDelay is set 2) Place a hold on a record 3) Place a second hold and set it to waiting by checking it in 4) Place a third hold with an expiration date 5) View the holds tab on circulation.pl and moremember.pl 6) Note the first hold has no expiration date 7) Note the second hold has an expiration date of today + ReservesMaxPickUpDelay days 8) Note the thrid hold has an expiration date of whatever you set it to Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Cathi Wiggins <CWIGGINS@ci.arcadia.ca.us> Signed-off-by: Megan Wianecki <mwianecki@mplmain.mtpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40756&action=edit Bug 13853: Add tests for is_waiting Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40757&action=edit Bug 13853 [QA Followup] - Add unit tests for branch getting methods Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40758&action=edit Bug 13853: (follow-up) unit tests Specify the reference, we should receive Koha::Object. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org