[Bug 5002] New: No error message if category code already exists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Summary: No error message if category code already exists Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All URL: /admin/categorie.pl OS/Version: All Status: NEW Severity: minor Priority: P5 Component: System Administration AssignedTo: paul.poulain@biblibre.com ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 When adding new patron categories you can save a new category with an existing category code. There is no error message and the new category is not saved. Koha Version: 3.01.00.142 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_2 |master --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-02 15:41:55 UTC --- still relevant -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still valid - Paul, this bug is assigned to you? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to Katrin Fischer from comment #2)
Still valid - Paul, this bug is assigned to you?
Yes, but I can't deal with it, sorry. If someone want it, feel free to take it -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|paul.poulain@biblibre.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Corey <agent.075@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agent.075@gmail.com --- Comment #4 from Corey <agent.075@gmail.com> --- Could not resolve the issue, but someone may be able to investigate further and add an IF & ELSE statement in the categorie.pl document (/koha/admin) In the categorie.pl document, there is an ADD_VALIDATE section that is called by the ADD_FORM, which the rule should be positioned. The IF & ELSE statement should be that IF a category code that the administrator wants to add already exists, then an error message should arise; ELSE, proceed with the new category code. That should help quite a bit, I gave up... :( -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37174&action=edit Bug 5002: Display messages on adding/deleting patron category There are no messages on adding and deleting patron category. If an error occurs and the data is not inserted, the interface does not alert the user. This patch adds a message block to alert the user if something wrong happened. Test plan: 1/ Create a patron category PATCAT. You should get a confirmation message. 2/ Try to create another patron category with the same code. You should get an error message 3/ Delete the patron category PATCAT. You should get a confirmation message. Confirm there is no regression on this form (try update an existing patron category too). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 37226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37226&action=edit [Signed-off] Bug 5002: Display messages on adding/deleting patron category There are no messages on adding and deleting patron category. If an error occurs and the data is not inserted, the interface does not alert the user. This patch adds a message block to alert the user if something wrong happened. Test plan: 1/ Create a patron category PATCAT. You should get a confirmation message. 2/ Try to create another patron category with the same code. You should get an error message 3/ Delete the patron category PATCAT. You should get a confirmation message. Confirm there is no regression on this form (try update an existing patron category too). Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #37174|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, noticed a small problem: - edit an existing patron category - save the change - redirect is to the categories table - but only the edited caegory will show I think it has something to do with a search parameter - visible in the top search. Also some suggestions for the messages: - inserted with success > added successfully - deleteing > deleting - Hm, maybe: The patron category might already exist. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37256&action=edit Bug 5002: Show all patron categories after insert + wording changes. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37256|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37257&action=edit Bug 5002: Show all patron categories after insert + wording changes. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #7)
Hi Jonathan,
noticed a small problem: - edit an existing patron category - save the change - redirect is to the categories table - but only the edited caegory will show
I think it has something to do with a search parameter - visible in the top search.
I thought it was a feature... :) I should have tested on master to confirm.
Also some suggestions for the messages: - inserted with success > added successfully - deleteing > deleting - Hm, maybe: The patron category might already exist.
Fixed. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 37260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37260&action=edit [Signed-off] Bug 5002: Show all patron categories after insert + wording changes. How I tested: - edit an existing patron category - save the change - redirect is to the categories table - it shows all categories OK - wording OK as well Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37257|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37226|0 |1 is obsolete| | Attachment #37260|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37319&action=edit [PASSED QA] Bug 5002: Display messages on adding/deleting patron category There are no messages on adding and deleting patron category. If an error occurs and the data is not inserted, the interface does not alert the user. This patch adds a message block to alert the user if something wrong happened. Test plan: 1/ Create a patron category PATCAT. You should get a confirmation message. 2/ Try to create another patron category with the same code. You should get an error message 3/ Delete the patron category PATCAT. You should get a confirmation message. Confirm there is no regression on this form (try update an existing patron category too). Followed test plan, works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37320&action=edit [PASSED QA] Bug 5002: Show all patron categories after insert + wording changes. How I tested: - edit an existing patron category - save the change - redirect is to the categories table - it shows all categories OK - wording OK as well Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Does not apply on 3.18.x, please rebase if you think it is nessecary -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org