[Bug 36956] New: ERM eUsage reports : only the first 20 data providers are listed when creating a new report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 Bug ID: 36956 Summary: ERM eUsage reports : only the first 20 data providers are listed when creating a new report Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: michaela.sieber@kit.edu CC: jonathan.druart@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com to reproduce: 1.) Go to ERM module and make sure you have more than 21 data providers stored in your database. 2.) Go to eUsage / reports and create new report (cgi-bin/koha/erm/eusage/reports) 3.) Check that only the first 20 data providers are displayed in the drop down -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167217&action=edit Bug 36956: Allow all providers to be displayed in reports This patch fixes an incorrect usage of the API which was only returning 20 results. Test plan: 1) Go to ERM module and make sure you have more than 21 data providers stored in your database. 2) Go to eUsage / reports and create new report (cgi-bin/koha/erm/eusage/reports) 3) Check that only the first 20 data providers are displayed in the drop down 4) Apply patch 5) yarn build or reset_all to rebuild the javascript 6) Repeat steps 1-3, all providers should now be displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167217|0 |1 is obsolete| | --- Comment #2 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 167221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167221&action=edit Bug 36956: Allow all providers to be displayed in reports This patch fixes an incorrect usage of the API which was only returning 20 results. Test plan: 1) Go to ERM module and make sure you have more than 21 data providers stored in your database. 2) Go to eUsage / reports and create new report (cgi-bin/koha/erm/eusage/reports) 3) Check that only the first 20 data providers are displayed in the drop down 4) Apply patch 5) yarn build or reset_all to rebuild the javascript 6) Repeat steps 1-3, all providers should now be displayed Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36392 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167221|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 167933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167933&action=edit Bug 36956: Allow all providers to be displayed in reports This patch fixes an incorrect usage of the API which was only returning 20 results. Test plan: 1) Go to ERM module and make sure you have more than 20 data providers stored in your database. 1) (Optional) Run the following command (k-t-d) to create 21 data providers: perl -MKoha::Database -e ' my $schema = Koha::Database->schema; $schema->resultset("ErmUsageDataProvider")->create({ name => "name ".$_ }) for (1..21) ' 2) Go to eUsage / reports and create new report (cgi-bin/koha/erm/eusage/reports) 3) Check that only the first 20 data providers are displayed in the drop down 4) Apply patch 5) yarn build or reset_all to rebuild the javascript 6) Repeat steps 1-3, all providers should now be displayed PA amended patch: Updated commit message test plan Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ERM eUsage reports : only |ERM eUsage reports: only |the first 20 data providers |the first 20 data providers |are listed when creating a |are listed when creating a |new report |new report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Such a small change, such a big effect :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate, | |rel_24_05_candidate --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Adding backport release keywords, can we please add this to 24.05.x and 23.11.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Keywords|rel_24_05_candidate | Version(s)|24.11.00 |24.11.00,24.05.02 released in| | CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|24.11.00,24.05.02 |24.11.00,24.05.02,23.11.07 released in| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark@catalyst.net.nz --- not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |david@davidnind.com Text to go in the| |This fixes the "Choose data release notes| |provider" dropdown list | |when creating a usage | |report in ERM (ERM > eUsage | |> Reports > Create report) | |so that all providers are | |listed - previously it was | |only displaying 20 data | |providers. Status|Pushed to oldstable |RESOLVED --- Comment #10 from David Nind <david@davidnind.com> --- I have: 1. Added a release note. 2. Removed the rel_23_11_candidate keyword, as it was pushed for 23.11.07. 3. Updated the status to RESOLVED FIXED - not backported to 23.05, no changes to the ERM chapter of the manual are required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the "Choose data |This fixes the "Choose data release notes|provider" dropdown list |provider" dropdown list |when creating a usage |when creating a usage |report in ERM (ERM > eUsage |report in ERM so that all |> Reports > Create report) |providers are listed (ERM > |so that all providers are |eUsage > Reports > Create |listed - previously it was |report). Before this, it |only displaying 20 data |was only listing the first |providers. |20 data providers. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org