[Bug 5806] New: Search results display items for all locations when the SearchMyLibrary first system pref is activated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5806 Bug #: 5806 Summary: Search results display items for all locations when the SearchMyLibrary first system pref is activated Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC Comments AssignedTo: gmcharlt@gmail.com ReportedBy: peter.lorimer@gmail.com QAContact: koha-bugs@lists.koha-community.org When searchMyLibraryFirst system pref is activated, although the results are filtered, the search results show items available in all locations. On the detail page items from all locations are also being displayed. A good enhancement would be an additional pref called SearchMyLibraryOnly where as well as the results, the detail summaries and the locations the item is available (in the search result content) are also filtered. A user should have the ability to choose a library to search or to log in, when the user logs in that users library is selected, other wise the user can select a library or opt to search all libraries If you choose SearchMyLibraryOnly you should only see items from tha selected library and nothing else. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5806 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC Comments |OPAC -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5806 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |colin.campbell@ptfs-europe. | |com Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5806 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |--- --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-30 13:37:41 UTC --- Hi Peter, I have removed the 'Needs Signoff' status, because there is no patch attached and I don't see one on the mailing list. Please feel free to attach your patch and change it back. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5806 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |jwagner@ptfs.com Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5806 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 Patch Status|Needs Signoff |--- -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5806 --- Comment #2 from Peter Lorimer <peter.lorimer@gmail.com> 2011-08-31 10:10:39 UTC --- Created attachment 5237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5237 Patch File for this Bug -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5806 --- Comment #3 from Peter Lorimer <peter.lorimer@gmail.com> 2011-08-31 10:11:07 UTC --- Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5806 --- Comment #4 from Peter Lorimer <peter.lorimer@gmail.com> 2011-08-31 10:12:59 UTC --- Needs Signoff(In reply to comment #1)
Hi Peter, I have removed the 'Needs Signoff' status, because there is no patch attached and I don't see one on the mailing list. Please feel free to attach your patch and change it back.
Hi Katrin I've attached the patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5806 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5806 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-31 10:16:06 UTC --- Hi Peter, only another hint: To set this bug to 'Needs Signoff' change the 'Importance' to 'PATCH-Sent'. By doing that the 'Patch Status' pull down appears and you can select 'Needs Signoff' there. As you have provided a patch for this bug you should also change 'Assigned To' to be your bugzilla account's email address. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5806 Peter Lorimer <peter.lorimer@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored AssignedTo|gmcharlt@gmail.com |peter.lorimer@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5806 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-27 16:43:44 UTC --- I don't have tested the patch, but I mark is "failed QA" because it seems there are many things that are not related to the goal of the patch. Just 3 examples : ModBiblioframework($biblionumber,$frameworkcode); @@ -2730,7 +2732,10 @@ sub EmbedItemsInMarcBiblio { my $item_marc = C4::Items::GetMarcItem($biblionumber, $itemnumber); push @item_fields, $item_marc->field($itemtag); } - $marc->insert_fields_ordered(@item_fields); + if (defined $marc) + { + $marc->insert_fields_ordered(@item_fields); + } } and sub z3950_search_args { my $bibrec = shift; - $bibrec = { title => $bibrec } if !ref $bibrec; + + + if (validate_isbn($bibrec) == 1) + { + $bibrec = { isbn => $bibrec } if !ref $bibrec; +} +else { + $bibrec = { title => $bibrec } if !ref $bibrec; +} and a new index.htm file: diff --git a/index.htm b/index.htm new file mode 100755 index 0000000..30a4b1e --- /dev/null +++ b/index.htm @@ -0,0 +1,131 @@ +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> + +<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en"> + <head> + <title>Scooter Online Library System</title> + + <meta name="MSSmartTagsPreventParsing" content="true" /> + <link id="theme" rel="stylesheet" type="text/css" href="style.css" title="theme" /> +<script type="text/javascript" language="javascript" src="js/addon.js"></script> +<script type="text/javascript" language="javascript" src="js/custom.js"></script> + </head> + <body bgcolor="#E0E0E"> + <!-- top wrapper --> + + <div id="topSlideshowWrapper"> + <div id="sliderContainer"> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5806 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9055 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org