[Bug 13374] New: AllowHoldsOnPatronsPossessions not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13374 Bug ID: 13374 Summary: AllowHoldsOnPatronsPossessions not working Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: jdeca@smfpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We are trying to used AllowHoldsOnPatronsPossessions preference set to "Don't Allow" and it works only some times. opac-reserve.pl calls CheckIfIssuedToPatron($borrowernumber, $biblionumber) in Circulation.pm that calls GetItemsByBiblioitemnumber($biblionumber) in Items.pm that is using a query "SELECT * FROM items WHERE items.biblioitemnumber = ?" The problem is the query is searching for biblioitemnumber but we are passing biblionumber. I don't know if this is not a problem for other libraries but most of our biblioitemnumber DO NOT EQUAL biblionumber. It seems that we should not be using biblioitemnumbers for anything. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13374 --- Comment #1 from Jorge de Cardenas <jdeca@smfpl.org> --- I only found 4 places using GetItemsByBiblioitemnumber() C4/Items.pm - function defined C4/Circulations.pm - called using biblionumber C4/ILSDI/Services.pm - called using biblioitemnumber intranet/cgi-bin/cataloguing/additem.pl - called using biblioitemnumber I propose: 1) renaming function to GetItemsByBiblionumber 2) changing all call to use biblionumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org