[Bug 17171] New: Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Bug ID: 17171 Summary: Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Work to be done: 1) Add new system preference AutoReturnCheckedOutItemForNewCheckout ( or something more terse ) 2) Add new system preference AutoReturnCheckedOutItemForNewCheckoutForgiveFine 3) Modify circulation.pl to accept these new parameters and report what happened (yellow box) instead of prompting for confirmation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- AutoReturnCheckedOutItemForNewCheckoutForgiveFine It looks a bit like all the Koha buzz words in one word :) Could we find something a bit shorter? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick@bywatersolutions.com |kyle@bywatersolutions.com CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 64260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64260&action=edit Bug 17171 - Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Some libraries don't want to force the librarians to manually confirm each checkout when the item is checked out to another. Instead, they would prefer to be alerted after the fact. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref AutoReturnCheckedOutItems 4) Check an item out to a patron 5) Check the same item out to another patron 6) Note you are not prompted to confirm the checkout, but are instead alerted that is had been checked out to another patron! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- Patch does not apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64260|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65924&action=edit Bug 17171 - Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Some libraries don't want to force the librarians to manually confirm each checkout when the item is checked out to another. Instead, they would prefer to be alerted after the fact. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref AutoReturnCheckedOutItems 4) Check an item out to a patron 5) Check the same item out to another patron 6) Note you are not prompted to confirm the checkout, but are instead alerted that is had been checked out to another patron! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- The syspref worked when set to Don't. That was the only confusion in the test plan. Otherwise, works as expected! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 ByWaterSandboxes@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ByWaterSandboxes@gmail.com Status|Needs Signoff |Signed Off --- Comment #6 from ByWaterSandboxes@gmail.com --- Patch tested with a sandbox, by Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 ByWaterSandboxes@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65924|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #7 from ByWaterSandboxes@gmail.com --- Created attachment 65925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65925&action=edit Bug 17171 - Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Some libraries don't want to force the librarians to manually confirm each checkout when the item is checked out to another. Instead, they would prefer to be alerted after the fact. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref AutoReturnCheckedOutItems 4) Check an item out to a patron 5) Check the same item out to another patron 6) Note you are not prompted to confirm the checkout, but are instead alerted that is had been checked out to another patron! Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |josef.moravec@gmail.com --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- The file cash_register_stats.tt is edited probably by accident - it should be removed from this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65925|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70766&action=edit Bug 17171 - Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Some libraries don't want to force the librarians to manually confirm each checkout when the item is checked out to another. Instead, they would prefer to be alerted after the fact. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref AutoReturnCheckedOutItems 4) Check an item out to a patron 5) Check the same item out to another patron 6) Note you are not prompted to confirm the checkout, but are instead alerted that is had been checked out to another patron! Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Josef Moravec from comment #8)
The file cash_register_stats.tt is edited probably by accident - it should be removed from this patch.
Removed and rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70766|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73258&action=edit Bug 17171: Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Some libraries don't want to force the librarians to manually confirm each checkout when the item is checked out to another. Instead, they would prefer to be alerted after the fact. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref AutoReturnCheckedOutItems 4) Check an item out to a patron 5) Check the same item out to another patron 6) Note you are not prompted to confirm the checkout, but are instead alerted that is had been checked out to another patron! Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Had to fix the alphabetic order in sysprefs.sql, but no other complaints ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. It sounds like we should also modify circulation_batch_checkouts.tt 2. Are you sure we want this to apply to SIP and self-checkout? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 73315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73315&action=edit Bug 17171 [QA Followup]: Add message to batch checkout template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #13)
1. It sounds like we should also modify circulation_batch_checkouts.tt
Follow-up submitted!
2. Are you sure we want this to apply to SIP and self-checkout?
Yes, the logic behind this is: if the patron is holding the book, they can check it out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #15)
(In reply to Jonathan Druart from comment #13)
1. It sounds like we should also modify circulation_batch_checkouts.tt
Follow-up submitted!
Thanks
2. Are you sure we want this to apply to SIP and self-checkout?
Yes, the logic behind this is: if the patron is holding the book, they can check it out.
Should not we make it explicit in the syspref's description in that case? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #14)
Created attachment 73315 [details] [review] Bug 17171 [QA Followup]: Add message to batch checkout template
Use patron-title.inc instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #17)
(In reply to Kyle M Hall from comment #14)
Created attachment 73315 [details] [review] [review] Bug 17171 [QA Followup]: Add message to batch checkout template
Use patron-title.inc instead.
in circulation.tt as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73258|0 |1 is obsolete| | Attachment #73315|0 |1 is obsolete| | --- Comment #19 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87302&action=edit Bug 17171: Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Some libraries don't want to force the librarians to manually confirm each checkout when the item is checked out to another. Instead, they would prefer to be alerted after the fact. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref AutoReturnCheckedOutItems 4) Check an item out to a patron 5) Check the same item out to another patron 6) Note you are not prompted to confirm the checkout, but are instead alerted that is had been checked out to another patron! Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #20 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87303&action=edit Bug 17171: (QA Followup) Add message to batch checkout template Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #21 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87304&action=edit Bug 17171: (QA Follow up) Using patron-title.inc for names Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #22 from Liz Rea <wizzyrea@gmail.com> --- Just noting that I resolved a small conflict in the tests (they still pass) and added a follow up to address Jonathan's use patron-title.inc request. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87302|0 |1 is obsolete| | Attachment #87303|0 |1 is obsolete| | Attachment #87304|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87742&action=edit Bug 17171: Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Some libraries don't want to force the librarians to manually confirm each checkout when the item is checked out to another. Instead, they would prefer to be alerted after the fact. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref AutoReturnCheckedOutItems 4) Check an item out to a patron 5) Check the same item out to another patron 6) Note you are not prompted to confirm the checkout, but are instead alerted that is had been checked out to another patron! Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87743&action=edit Bug 17171: (QA follow-up) Add message to batch checkout template Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87744&action=edit Bug 17171: (QA follow-up) Using patron-title.inc for names Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87745&action=edit Bug 17171: (QA follow-up) Remove cardnumber template variable The INCLUDE already takes care of displaying the cardnumber, the extra variable is not needed. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fixed commit messages, please spell: (QA follow-up) (or QA tool will complain) :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED Version(s)| |19.05.00 released in| | CC| |martin.renvoize@ptfs-europe | |.com --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Rather than force release notes| |librarians to manually | |confirm each checkout when | |an item is checked out to | |another patron, this | |enhancement alerts them | |after the checkout is | |completed. This behavior is | |set using a new system | |preference | |"AutoReturnCheckedOutItems" | |. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Rather than force |Some libraries don't want release notes|librarians to manually |to force librarians to |confirm each checkout when |manually confirm each |an item is checked out to |checkout when an item is |another patron, this |checked out to another |enhancement alerts them |patron. Instead, they would |after the checkout is |prefer to be alerted |completed. This behavior is |afterwards. |set using a new system | |preference |This |"AutoReturnCheckedOutItems" |enhancement allows this |. |behavior using a new system | |preference | |"AutoReturnCheckedOutItems" | |. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #30 from David Nind <david@davidnind.com> --- This is bugs is shown as sponsored, but who sponsored it is not shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org