[Bug 21913] New: Clean up payment details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 Bug ID: 21913 Summary: Clean up payment details page Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/accountline-details.pl?accountli nes_id=XXX OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 20654 The payment details page (Patron -> Fines -> Account -> Details) needs some markup corrections and for the grid to be converted to Bootstrap. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82757&action=edit Bug 21913: Clean up payment details page This patch makes various corrections and improvements to the payment details page: - Grid converted to Bootstrap - Correct title tag - Add patron toolbar - Adding missing patron-related JavaScript - Improve some language To test, apply the patch and locate a patron who has one or more payments on their account. - Open Fines -> Account -> Details of a transaction - Confirm that the page looks correct and adjusts well at various browser widths. - Confirm that patron toolbar items work correctly - Confirm that the payments table only appears when there are payments to list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kohadevinim@devinim.com.tr --- Comment #2 from Devinim <kohadevinim@devinim.com.tr> --- İf there isn't any payment, payment section appears. Other functionalities are working as described. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Devinim from comment #2)
İf there isn't any payment, payment section appears. Other functionalities are working as described.
Failing QA for that as it is advertised in the commit message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 --- Comment #4 from Devinim <kohadevinim@devinim.com.tr> --- (In reply to Jonathan Druart from comment #3)
(In reply to Devinim from comment #2)
İf there isn't any payment, payment section appears. Other functionalities are working as described.
Failing QA for that as it is advertised in the commit message.
Hi Jonathan, We didn't understand this :( Can you explain a bit more? Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82757|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 83793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83793&action=edit Bug 21913: Clean up payment details page This patch makes various corrections and improvements to the payment details page: - Grid converted to Bootstrap - Correct title tag - Add patron toolbar - Adding missing patron-related JavaScript - Improve some language To test, apply the patch and locate a patron who has one or more payments on their account. - Open Fines -> Account -> Details of a transaction - Confirm that the page looks correct and adjusts well at various browser widths. - Confirm that patron toolbar items work correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #3)
(In reply to Devinim from comment #2)
İf there isn't any payment, payment section appears. Other functionalities are working as described.
Failing QA for that as it is advertised in the commit message.
I removed those changes. There wasn't a straightforward way to accomplish it with template changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83793|0 |1 is obsolete| | --- Comment #7 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> --- Created attachment 83828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83828&action=edit Bug 21913: Clean up payment details page This patch makes various corrections and improvements to the payment details page: - Grid converted to Bootstrap - Correct title tag - Add patron toolbar - Adding missing patron-related JavaScript - Improve some language To test, apply the patch and locate a patron who has one or more payments on their account. - Open Fines -> Account -> Details of a transaction - Confirm that the page looks correct and adjusts well at various browser widths. - Confirm that patron toolbar items work correctly Signed-off-by: Jose-Mario <jose-mario.monteiro-santos@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83828|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 83848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83848&action=edit Bug 21913: Clean up payment details page This patch makes various corrections and improvements to the payment details page: - Grid converted to Bootstrap - Correct title tag - Add patron toolbar - Adding missing patron-related JavaScript - Improve some language To test, apply the patch and locate a patron who has one or more payments on their account. - Open Fines -> Account -> Details of a transaction - Confirm that the page looks correct and adjusts well at various browser widths. - Confirm that patron toolbar items work correctly Signed-off-by: Jose-Mario <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org