https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394 --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67542&action=edit Bug 19384 - Ability to skip the onboarding tool and then redirect the next user to it To allow IT staff and support vendors to quickly install Koha for clients this patch allows these people to skip the onboarding tool and go straight from the web installer to authenticating to the intranet. As well as allowing these users to install Koha quickly, the other purpose of this patch is that these people are unlikely to know what the library wants set as the library, patron category, administrator patron credentials, item type and circulation rule and so it is better to leave that to a librarian to fill out. The next user to log in (they will have to use the Koha db administrator credentials) after Koha has been installed (and only if the onboarding tool was skipped) is then redirected to login to the web installer to go through the onboarding tool. Test plan: 1. Drop and recreate your Koha database 2. Restart memcached 3. Go through the web installer and notice that on the page which says congradulations that you have successfully installed Koha there is a link to click to load the onboarding tool otherwise if you wait 10 seconds you are redirected anyway. 4. Apply patch 5. Repeat steps 1 and 2 6. Go through the web installer without installing sample patrons and notice on the same page described in step 3 there are now 2 links: one to go to the onboarding tool and one to skip the onboarding process. Also notice that if you wait 10 seconds you are not redirected to the onboarding tool. 7. Click the skip link 8. Notice the intranet login page appears, login using the Koha db adminstrator credentials and notice that the mainpage appears. 9. Now logout and login again and notice that you are redirected to the Web installer login page, login and notice that the onboarding tool is displayed 10. Repeat steps 1 and 2 and this time install sample data including sample patrons 11. On the page described on step 3 click the skip link. 12. Notice that the intranet login page appears, login and then logout 13. Try logging in again and notice that you are redirected to the web installer login page and after authenticating the onboarding tool is displayed. 14. Repeat steps 1 and 2 go through the web installer and on the page described in step 3 click the onboarding link and notice that a page from the onboarding process is displayed. 15. Aftergoing through the onboarding tool login as db administrator and then logout and login again and notice that you are not redirected to the onboarding tool because you have already completed it Sponsored-By: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please don't forget to assign your bugs to yourself :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david.bourgault@inlibro.com --- Comment #5 from David Bourgault <david.bourgault@inlibro.com> --- Hi, Patch does not apply on most recent master. It says the conflict is in koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt David -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394 --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 68117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68117&action=edit Bug 19384 - Ability to skip the onboarding tool and then redirect the next user to it To allow IT staff and support vendors to quickly install Koha for clients this patch allows these people to skip the onboarding tool and go straight from the web installer to authenticating to the intranet. As well as allowing these users to install Koha quickly, the other purpose of this patch is that these people are unlikely to know what the library wants set as the library, patron category, administrator patron credentials, item type and circulation rule and so it is better to leave that to a librarian to fill out. The next user to log in (they will have to use the Koha db administrator credentials) after Koha has been installed (and only if the onboarding tool was skipped) is then redirected to login to the web installer to go through the onboarding tool. Test plan: 1. Drop and recreate your Koha database 2. Restart memcached 3. Go through the web installer and notice that on the page which says congradulations that you have successfully installed Koha there is a link to click to load the onboarding tool otherwise if you wait 10 seconds you are redirected anyway. 4. Apply patch 5. Repeat steps 1 and 2 6. Go through the web installer without installing sample patrons and notice on the same page described in step 3 there are now 2 links: one to go to the onboarding tool and one to skip the onboarding process. Also notice that if you wait 10 seconds you are not redirected to the onboarding tool. 7. Click the skip link 8. Notice the intranet login page appears, login using the Koha db adminstrator credentials and notice that the mainpage appears. 9. Now logout and login again and notice that you are redirected to the Web installer login page, login and notice that the onboarding tool is displayed 10. Repeat steps 1 and 2 and this time install sample data including sample patrons 11. On the page described on step 3 click the skip link. 12. Notice that the intranet login page appears, login and then logout 13. Try logging in again and notice that you are redirected to the web installer login page and after authenticating the onboarding tool is displayed. 14. Repeat steps 1 and 2 go through the web installer and on the page described in step 3 click the onboarding link and notice that a page from the onboarding process is displayed. 15. Aftergoing through the onboarding tool login as db administrator and then logout and login again and notice that you are not redirected to the onboarding tool because you have already completed it Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68116|0 |1 is obsolete| | --- Comment #9 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 68188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68188&action=edit Bug 19394 - Ability to skip the onboarding tool implemented -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68188|0 |1 is obsolete| | --- Comment #11 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 68190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68190&action=edit Bug 19394 - Ability to skip the onboarding tool implemented Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394 --- Comment #13 from David Bourgault <david.bourgault@inlibro.com> --- oops, I forgot to add the signoff line. Patch works as expected. QA tool did say something about a missing blank line before =cut in Koha/Patrons.pm, but I didn't want to fail QA patch for this so I took the liberty of adding the missing line. Hope that's OK. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394 --- Comment #14 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Thanks David -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Hi Alex, Here are a few things you need to change: 1. Remove all occurences of onboardingrequired, it's stored in a bad place, it's badly used and you don't need it (explanation below:) a. userflags contain name and description of user permissions, it's not a place to store arbitrary flags (despite its name) b. if we decide to skip the onboarding tool, the first time the DB user logs in they are not redirected to the onboarding tool because onboardingrequired's value is 0 (it's set to 1 only at this moment), so the user need to reload the page to be redirected to the onboarding tool. Moreover onboardingrequired is still equals to 1 after the onboarding process c. you don't need it because you have another check that is (IMO) enough : if there is at least one user that have permission superlibrarian, it means that someone is gone through the onboarding process (or someone has manually configured Koha, which means the onboarding process is not needed) 2. check_if_patrons_have_flags is not needed: you can replace it by Koha::Patrons->search({flags => { '!=' => undef }}) (and anyway the previous check is enough IMO, so it could be completely removed) 3. I think that changes in installer/onboarding.pl are not needed: a. you changed the redirection to installer/install.pl to mainpage.pl, which then redirects to installer/install.pl, so it adds one more redirection for the same result b. there seems to be no scenario where $op == 'skip', can you confirm that ? Now that's a personal opinion but I believe that a warning message would be better than an automatic redirect. There might be some cases where I don't want to go through the onboarding process at all and this redirect could become annoying -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley@catalyst.net.nz |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.