[Bug 35087] New: Discount rate does not accept comma as decimal separator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Bug ID: 35087 Summary: Discount rate does not accept comma as decimal separator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: thibaud.guillot@biblibre.com QA Contact: testopia@bugs.koha-community.org Hello all, When a comma is used to define the discount rate of a vendor, the data is not recorded (as NULL), it is however recorded if the separator is a point. In the same way that the BZ rectifying the problems linked to the payment of fines (bug 33028) obliges the input with a point I will propose a corrective in this same direction. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33028 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 --- Comment #1 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 157302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157302&action=edit Bug 35087: Discount rate only accepts a point as decimal separator When a comma is used to define the discount rate of a vendor, the data is not recorded (as NULL), it is however recorded if the separator is a point. Test plan: 1) Go to acqui module and edit a vendor 2) Set a discount rate with a comma as decimal separator 3) Edit again or request your database to see that there is no data saved 4) Do it again with a point as decimal and see it works 5) Apply this patch and reloard the build for the templates 6) Repeat step 2 and see the warning to inform you that you must use a point -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157302|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 157626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157626&action=edit Bug 35087: Discount rate only accepts a point as decimal separator When a comma is used to define the discount rate of a vendor, the data is not recorded (as NULL), it is however recorded if the separator is a point. Test plan: 1) Go to acqui module and edit a vendor 2) Set a discount rate with a comma as decimal separator 3) Edit again or request your database to see that there is no data saved 4) Do it again with a point as decimal and see it works 5) Apply this patch and reloard the build for the templates 6) Repeat step 2 and see the warning to inform you that you must use a point Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You removed the "validated" class from the form, this disables all standard validation that already was applied here. An examples: the mandatory field "Name" now uses the standard HTML5 message instead of our own. Email and website no longer validate at all. You need to keep the Validator active and implement your check additionally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157626|0 |1 is obsolete| | --- Comment #4 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 158921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158921&action=edit Bug 35087: Discount rate only accepts a point as decimal separator When a comma is used to define the discount rate of a vendor, the data is not recorded (as NULL), it is however recorded if the separator is a point. Test plan: 1) Go to acqui module and edit a vendor 2) Set a discount rate with a comma as decimal separator 3) Edit again or request your database to see that there is no data saved 4) Do it again with a point as decimal and see it works 5) Apply this patch and reloard the build for the templates 6) Repeat step 2 and see the warning to inform you that you must use a point -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 --- Comment #5 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to Katrin Fischer from comment #3)
You removed the "validated" class from the form, this disables all standard validation that already was applied here.
An examples: the mandatory field "Name" now uses the standard HTML5 message instead of our own. Email and website no longer validate at all.
You need to keep the Validator active and implement your check additionally.
Hello Katrin, Thanks for your comment, sorry for the error. I tried to fix it, but I kept the deleted class, and added a validation for the 'discount' input, I think it's correct for now, but if you see a problem, I'd be happy to hear from you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I confirm that it does on longer break the other validation, but I am not sure if it's the right way to do it. Adding Owen in hope of some guidance. Also: Your hint displays as: % - Example: 7.5 % - that doesn't look quite right yet. I wonder if using a standard class of Validator would be better here? We could use number like we do on Bug 34169 - Add validation for monetary input fields in acquisition module, but maybe with its own class and hint? That would also make it reusable - the discount is also set on the order form and there might be other use cases like the search field weighting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158921|0 |1 is obsolete| | --- Comment #7 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 159831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159831&action=edit Bug 35087: Discount rate only accepts a point as decimal separator When a comma is used to define the discount rate of a vendor, the data is not recorded (as NULL), it is however recorded if the separator is a point. Test plan: 1) Go to acqui module and edit a vendor 2) Set a discount rate with a comma as decimal separator 3) Edit again or request your database to see that there is no data saved 4) Do it again with a point as decimal and see it works 5) Apply this patch and reloard the build for the templates 6) Repeat step 2 and see the warning to inform you that you must use a point Signed-off-by: Sabrina <kiehl@mpis.mpg.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Sabrina Kiehl <kiehl@mpis.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kiehl@mpis.mpg.de Status|Needs Signoff |Signed Off --- Comment #8 from Sabrina Kiehl <kiehl@mpis.mpg.de> --- Tested following the mentioned steps, warning was shown correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #6)
We could use number like we do on Bug 34169
I agree... There doesn't seem to be a reason not to. In similar cases we don't add any kind of hint (e.g. a <div class="hint"> under the input field), so I don't think we have to include that in this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159831|0 |1 is obsolete| | --- Comment #10 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 161128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161128&action=edit Bug 35087: Discount rate only accepts a point as decimal separator When a comma is used to define the discount rate of a vendor, the data is not recorded (as NULL), it is however recorded if the separator is a point. Test plan: 1) Go to acqui module and edit a vendor 2) Set a discount rate with a comma as decimal separator 3) Edit again or request your database to see that there is no data saved 4) Do it again with a point as decimal and see it works 5) Apply this patch and reloard the build for the templates 6) Repeat step 2 and see the warning to inform you that you must use a point -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 --- Comment #11 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Thanks for your feedback, I've modified the code to create a specific class for reuse it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161128|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 161225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161225&action=edit Bug 35087: Discount rate only accepts a point as decimal separator When a comma is used to define the discount rate of a vendor, the data is not recorded (as NULL), it is however recorded if the separator is a point. Test plan: 1) Go to acqui module and edit a vendor 2) Set a discount rate with a comma as decimal separator 3) Edit again or request your database to see that there is no data saved 4) Do it again with a point as decimal and see it works 5) Apply this patch and reloard the build for the templates 6) Repeat step 2 and see the warning to inform you that you must use a point Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161225|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161237&action=edit Bug 35087: Discount rate only accepts a point as decimal separator When a comma is used to define the discount rate of a vendor, the data is not recorded (as NULL), it is however recorded if the separator is a point. Test plan: 1) Go to acqui module and edit a vendor 2) Set a discount rate with a comma as decimal separator 3) Edit again or request your database to see that there is no data saved 4) Do it again with a point as decimal and see it works 5) Apply this patch and reloard the build for the templates 6) Repeat step 2 and see the warning to inform you that you must use a point Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I thought we were attempting to go the other way generally.. i.e. allowing people to input in their local format and translating at our end. This patch works though technically and resolves a problem so I'm happy to PQA.. at some point I'd really like to see a concerted effort to fix these formatting numerics issues globally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Thibaud, thanks for your perseverance! Can you please change these lines a bit so that the string is translatable? Maybe assigning it to a variable first? + decimal_rate: $.validator.addMethod("decimal_rate", $.validator.methods.number, "Please add rate in valid format: 0.00"), -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 --- Comment #16 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 161596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161596&action=edit Bug 35087: (follow-up) string validation is now translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 --- Comment #17 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Hello Katrin, Thanks ;) now normally it's done -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 --- Comment #18 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 161597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161597&action=edit Bug 35087: alternative patch to display validation Same test plan as for the other patch, but here validation impacts the js asset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161597|0 |1 is obsolete| | --- Comment #19 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 161598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161598&action=edit Bug 35087: alternative patch to display validation Same test plan as for the other patch, but here validation impacts the js asset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Are all 3 patches needed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 --- Comment #21 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to Katrin Fischer from comment #20)
Are all 3 patches needed?
Hello Katrin, No, the third is only an alternative way to fix it without touch include (all is done in staff-global.js). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Thibaud, what do we need here, additional feedback or are you still working on the patches? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 --- Comment #23 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Sorry I should have been more exhaustive, the alternative patch doesn't modify the 'validator-string' include so I thought that in terms of integration it would be simpler to have just one modified file. Nevertheless, I'll let you "choose" the best solution for validating the patch and I'll change the solution not chosen to "obsolete". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161237|0 |1 is obsolete| | Attachment #161596|0 |1 is obsolete| | Attachment #161598|0 |1 is obsolete| | --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161704&action=edit Bug 35087: Discount rate only accepts a point as decimal separator When a comma is used to define the discount rate of a vendor, the data is not recorded (as NULL), it is however recorded if the separator is a point. Test plan: 1) Go to acqui module and edit a vendor 2) Set a discount rate with a comma as decimal separator 3) Edit again or request your database to see that there is no data saved 4) Do it again with a point as decimal and see it works 5) Apply this patch and reloard the build for the templates 6) Repeat step 2 and see the warning to inform you that you must use a point Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161705&action=edit Bug 35087: alternative patch to display validation Same test plan as for the other patch, but here validation impacts the js asset Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161706&action=edit Bug 35087: (follow-up) Accept only values which will be saved correctly This patch adds a regex (thanks to Katrin for the help) specific to the range of values which will be accepted by the discount column in the database which has the type "float(6,4)". The patch also removes the format() filter from the template so that values returned from the database won't be truncated: Using "format ('%.1f')", a value in the db of '9.009' would appear in the edit form as '9.0', a change which could be missed if the user was editing some other field in the vendor edit form. To test, apply the patch and clear your browser cache if necessary. - Go to Acquisitions -> Vendors -> Edit vendor. - Under "Ordering information," test entering various values in the "Discount" field. It should accept numbers with up to two digits before the decimal and up to three digits after the decimal: 9, 99, -99, 99.9, 0.99, 99.99, 99.999 - In each of these cases, confirm that a value accepted by the client-side validation is also accepted when you submit the form and is correctly displayed when you edit that vendor again. - It should not accept: 100, 100.001, 100.00001 - The error message has been updated to read, "Please enter a decimal number in the format: 0.0" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161704|0 |1 is obsolete| | --- Comment #27 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 162065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162065&action=edit Bug 35087: Discount rate only accepts a point as decimal separator When a comma is used to define the discount rate of a vendor, the data is not recorded (as NULL), it is however recorded if the separator is a point. Test plan: 1) Go to acqui module and edit a vendor 2) Set a discount rate with a comma as decimal separator 3) Edit again or request your database to see that there is no data saved 4) Do it again with a point as decimal and see it works 5) Apply this patch and reloard the build for the templates 6) Repeat step 2 and see the warning to inform you that you must use a point Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161705|0 |1 is obsolete| | --- Comment #28 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 162066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162066&action=edit Bug 35087: alternative patch to display validation Same test plan as for the other patch, but here validation impacts the js asset Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161706|0 |1 is obsolete| | --- Comment #29 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 162067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162067&action=edit Bug 35087: (follow-up) Accept only values which will be saved correctly This patch adds a regex (thanks to Katrin for the help) specific to the range of values which will be accepted by the discount column in the database which has the type "float(6,4)". The patch also removes the format() filter from the template so that values returned from the database won't be truncated: Using "format ('%.1f')", a value in the db of '9.009' would appear in the edit form as '9.0', a change which could be missed if the user was editing some other field in the vendor edit form. To test, apply the patch and clear your browser cache if necessary. - Go to Acquisitions -> Vendors -> Edit vendor. - Under "Ordering information," test entering various values in the "Discount" field. It should accept numbers with up to two digits before the decimal and up to three digits after the decimal: 9, 99, -99, 99.9, 0.99, 99.99, 99.999 - In each of these cases, confirm that a value accepted by the client-side validation is also accepted when you submit the form and is correctly displayed when you edit that vendor again. - It should not accept: 100, 100.001, 100.00001 - The error message has been updated to read, "Please enter a decimal number in the format: 0.0" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |koha@univ-lyon3.fr --- Comment #30 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- Hi, tested on a sandbox. When we edit a vendor with a discount with no decimal (ex : 10), nothing is added when we saved it. If we try to enter a number with a comma in the discount, a red message appears "Please enter a decimal number in the format: 0.0" It's no more possible to make the discount not recorded because of a wrong input. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- number: _("Please add amount in valid format: 0.00"), + decimal_rate: $.validator.addMethod("decimal_rate", $.validator.methods.number, "Please add rate in valid format: 0.00"), Confusing + <input class="rate" type="text" size="6" id="discount" name="discount" value="[% discount | format ('%.1f') %]" />%</li> .1f linked to 0.00 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- We have 3 patches. And later patches revert stuff from earlier ones. Please squash, explain, fix ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |m.de.rooy@rijksmuseum.nl |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162065|0 |1 is obsolete| | Attachment #162066|0 |1 is obsolete| | --- Comment #33 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 164739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164739&action=edit Bug 35087: Discount rate only accepts a point as decimal separator When a comma is used to define the discount rate of a vendor, the data is not recorded (as NULL), it is however recorded if the separator is a point. Test plan: 1) Go to acqui module and edit a vendor 2) Set a discount rate with a comma as decimal separator 3) Edit again or request your database to see that there is no data saved 4) Do it again with a point as decimal and see it works 5) Apply this patch and reloard the build for the templates 6) Repeat step 2 and see the warning to inform you that you must use a point Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162067|0 |1 is obsolete| | --- Comment #34 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 164740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164740&action=edit Bug 35087: (follow-up) Accept only values which will be saved correctly This patch adds a regex (thanks to Katrin for the help) specific to the range of values which will be accepted by the discount column in the database which has the type "float(6,4)". The patch also removes the format() filter from the template so that values returned from the database won't be truncated: Using "format ('%.1f')", a value in the db of '9.009' would appear in the edit form as '9.0', a change which could be missed if the user was editing some other field in the vendor edit form. To test, apply the patch and clear your browser cache if necessary. - Go to Acquisitions -> Vendors -> Edit vendor. - Under "Ordering information," test entering various values in the "Discount" field. It should accept numbers with up to two digits before the decimal and up to three digits after the decimal: 9, 99, -99, 99.9, 0.99, 99.99, 99.999 - In each of these cases, confirm that a value accepted by the client-side validation is also accepted when you submit the form and is correctly displayed when you edit that vendor again. - It should not accept: 100, 100.001, 100.00001 - The error message has been updated to read, "Please enter a decimal number in the format: 0.0" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 --- Comment #35 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- I just tested it again and it doesn't work. If I put "4,5" in the discount rate of a vendor, then save and edit it again the discount rate hasn't been saved, the discount rate is empty. Sonia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #36 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to Koha Team University Lyon 3 from comment #35)
I just tested it again and it doesn't work. If I put "4,5" in the discount rate of a vendor, then save and edit it again the discount rate hasn't been saved, the discount rate is empty.
Sonia
Normally this should not be possible. I just tested again, the validation of the form imposes a comma, did you rebuild the css ? (This is an option on the sandbox management interface). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Baptiste <baptiste.bayche@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.bayche@inlibro.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164739|0 |1 is obsolete| | --- Comment #37 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167746&action=edit Bug 35087: Discount rate only accepts a point as decimal separator When a comma is used to define the discount rate of a vendor, the data is not recorded (as NULL), it is however recorded if the separator is a point. Test plan: 1) Go to acqui module and edit a vendor 2) Set a discount rate with a comma as decimal separator 3) Edit again or request your database to see that there is no data saved 4) Do it again with a point as decimal and see it works 5) Apply this patch and reloard the build for the templates 6) Repeat step 2 and see the warning to inform you that you must use a point Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164740|0 |1 is obsolete| | --- Comment #38 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167747&action=edit Bug 35087: (follow-up) Accept only values which will be saved correctly This patch adds a regex (thanks to Katrin for the help) specific to the range of values which will be accepted by the discount column in the database which has the type "float(6,4)". The patch also removes the format() filter from the template so that values returned from the database won't be truncated: Using "format ('%.1f')", a value in the db of '9.009' would appear in the edit form as '9.0', a change which could be missed if the user was editing some other field in the vendor edit form. To test, apply the patch and clear your browser cache if necessary. - Go to Acquisitions -> Vendors -> Edit vendor. - Under "Ordering information," test entering various values in the "Discount" field. It should accept numbers with up to two digits before the decimal and up to three digits after the decimal: 9, 99, -99, 99.9, 0.99, 99.99, 99.999 - In each of these cases, confirm that a value accepted by the client-side validation is also accepted when you submit the form and is correctly displayed when you edit that vendor again. - It should not accept: 100, 100.001, 100.00001 - The error message has been updated to read, "Please enter a decimal number in the format: 0.0" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #39 from Owen Leonard <oleonard@myacpl.org> --- Rebased on current main. It looks like it should be "Signed off" but there seems to be some question about whether it's working? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #40 from David Nind <david@davidnind.com> --- It looks like it is working to me. However, these values are rounded when displayed after saving (when edited again it is the value that was entered): - 0.99 => 1.0% - 99.9, 99.99, 99.999 => 100.0% -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Sylvain Def. <s.deflache@ville-caluire.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.deflache@ville-caluire.fr Keywords| |Sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Sylvain Def. <s.deflache@ville-caluire.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #41 from Sylvain Def. <s.deflache@ville-caluire.fr> --- Hi, It still doesn't work for me with trying to save value with a comma in it as a separator. Only numbers separated with a dot are saved When I use a comma, I get a "Please enter a decimal number in the format: 0.0" message. I'm using a french Firefox version, btw. Looks like it's a french problem with commas used as a dot (as common in France). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Sylvain Def. from comment #41)
Hi,
It still doesn't work for me with trying to save value with a comma in it as a separator. Only numbers separated with a dot are saved When I use a comma, I get a "Please enter a decimal number in the format: 0.0" message. I'm using a french Firefox version, btw. Looks like it's a french problem with commas used as a dot (as common in France).
I think it should not work with a comma, that is the point. Koha doesn't support other input formats yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Discount rate does not |Discount rate should only |accept comma as decimal |allow valid input formats |separator | Status|Failed QA |Needs Signoff --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #42)
(In reply to Sylvain Def. from comment #41)
Hi,
It still doesn't work for me with trying to save value with a comma in it as a separator. Only numbers separated with a dot are saved When I use a comma, I get a "Please enter a decimal number in the format: 0.0" message. I'm using a french Firefox version, btw. Looks like it's a french problem with commas used as a dot (as common in France).
I think it should not work with a comma, that is the point. Koha doesn't support other input formats yet.
To explain: the patch makes it impossible to input data that would be invalid. The problem with different input formats needs to be solved separatly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167746|0 |1 is obsolete| | --- Comment #44 from Olivier V <ovezina@inlibro.com> --- Created attachment 171197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171197&action=edit Bug 35087: Discount rate only accepts a point as decimal separator When a comma is used to define the discount rate of a vendor, the data is not recorded (as NULL), it is however recorded if the separator is a point. Test plan: 1) Go to acqui module and edit a vendor 2) Set a discount rate with a comma as decimal separator 3) Edit again or request your database to see that there is no data saved 4) Do it again with a point as decimal and see it works 5) Apply this patch and reloard the build for the templates 6) Repeat step 2 and see the warning to inform you that you must use a point Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167747|0 |1 is obsolete| | --- Comment #45 from Olivier V <ovezina@inlibro.com> --- Created attachment 171198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171198&action=edit Bug 35087: (follow-up) Accept only values which will be saved correctly This patch adds a regex (thanks to Katrin for the help) specific to the range of values which will be accepted by the discount column in the database which has the type "float(6,4)". The patch also removes the format() filter from the template so that values returned from the database won't be truncated: Using "format ('%.1f')", a value in the db of '9.009' would appear in the edit form as '9.0', a change which could be missed if the user was editing some other field in the vendor edit form. To test, apply the patch and clear your browser cache if necessary. - Go to Acquisitions -> Vendors -> Edit vendor. - Under "Ordering information," test entering various values in the "Discount" field. It should accept numbers with up to two digits before the decimal and up to three digits after the decimal: 9, 99, -99, 99.9, 0.99, 99.99, 99.999 - In each of these cases, confirm that a value accepted by the client-side validation is also accepted when you submit the form and is correctly displayed when you edit that vendor again. - It should not accept: 100, 100.001, 100.00001 - The error message has been updated to read, "Please enter a decimal number in the format: 0.0" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |ovezina@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171197|0 |1 is obsolete| | --- Comment #46 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 171594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171594&action=edit Bug 35087: Discount rate only accepts a point as decimal separator When a comma is used to define the discount rate of a vendor, the data is not recorded (as NULL), it is however recorded if the separator is a point. Test plan: 1) Go to acqui module and edit a vendor 2) Set a discount rate with a comma as decimal separator 3) Edit again or request your database to see that there is no data saved 4) Do it again with a point as decimal and see it works 5) Apply this patch and reloard the build for the templates 6) Repeat step 2 and see the warning to inform you that you must use a point Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171198|0 |1 is obsolete| | --- Comment #47 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 171595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171595&action=edit Bug 35087: (follow-up) Accept only values which will be saved correctly This patch adds a regex (thanks to Katrin for the help) specific to the range of values which will be accepted by the discount column in the database which has the type "float(6,4)". The patch also removes the format() filter from the template so that values returned from the database won't be truncated: Using "format ('%.1f')", a value in the db of '9.009' would appear in the edit form as '9.0', a change which could be missed if the user was editing some other field in the vendor edit form. To test, apply the patch and clear your browser cache if necessary. - Go to Acquisitions -> Vendors -> Edit vendor. - Under "Ordering information," test entering various values in the "Discount" field. It should accept numbers with up to two digits before the decimal and up to three digits after the decimal: 9, 99, -99, 99.9, 0.99, 99.99, 99.999 - In each of these cases, confirm that a value accepted by the client-side validation is also accepted when you submit the form and is correctly displayed when you edit that vendor again. - It should not accept: 100, 100.001, 100.00001 - The error message has been updated to read, "Please enter a decimal number in the format: 0.0" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 --- Comment #48 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Wow.. Loads of signoffs.. this is a popular one! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 --- Comment #49 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #50 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #51 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the vendor release notes| |discount field so that it | |now only accepts values | |that will save correctly: | |- | |a decimal number in the | |format 0.0 (if a comma is | |entered, you are now | |prompted to enter a decimal | |point) | |- numbers with up to | |two digits before the | |decimal and up to three | |digits after the decimal, | |for example: 9, 99, -99, | |99.9, 0.99, 99.99, 99.999 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED --- Comment #52 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1069 CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | --- Comment #53 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I thought that was interesting information for the end user to know that the field is limited to a certain format and a number of digits. I proposed a note for the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org