[Bug 30699] New: Several id idx
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 Bug ID: 30699 Summary: Several id idx Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org In koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc there is : <select class="advsearch" name="idx" id="idx"> But this include is used several times, so there are several id="idx". We should remove this id. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27546 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Arf this is now used for id=refiner_idx from Bug 27546 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Got to love these little gotchas... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- This is bad right ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #3)
This is bad right ?
It's not good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Several id idx |Fix various HTML validity | |errors in staff interface | |templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Some other errors I'll submit a fix for: More duplicate id problems, tab WRAPPER errors, invalid "href" attributes on <button>s, mismatched labels and form field ids. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170923&action=edit Bug 30699: Fix various HTML validity errors in staff interface templates This patch fixes several HTML validity issues in various staff interface templates. Most of these changes won't be visible in the interface. - Advanced search: - Remove stray </a> tags - Fix duplicate IDs by adding loop.index to repeated dropdown menus - Circulation - Fix mismatched label and form field id in checkouts table footer - Fix mismatched label and form field id claim returned modal - Remove invalid href attribute from button in claim returned modal - Wrap relatives' checkouts tab in conditional so that panel doesn't appear when tab has been hidden - Fix duplicate id attributes in patron messages-related markup - Remove redundant class attribute from patron messages-related markup - Acquisitions -> Vendor -> Basket -> Add to basket -> From staged file - Remove invalid "size" attribute from hidden form fields - Circulation -> Holds awaiting pickup - Fix mismatched label and form field id - Patron -> Accounting -> Pay fine -> Submit cash amount higher than the charge - Remove invalid href attribute from button in confirmation modal - Fix errors in tab markup WRAPPERs in html_helpers.inc to prevent mismatched aria-labelledby attributes - Footer language selector: - Fix markup to correct errors in aria-controls - Remove invalid href attribute from cookie consent modal Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170923|0 |1 is obsolete| | --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 172679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172679&action=edit Bug 30699: Fix various HTML validity errors in staff interface templates This patch fixes several HTML validity issues in various staff interface templates. Most of these changes won't be visible in the interface. - Advanced search: - Remove stray </a> tags - Fix duplicate IDs by adding loop.index to repeated dropdown menus - Circulation - Fix mismatched label and form field id in checkouts table footer - Fix mismatched label and form field id claim returned modal - Remove invalid href attribute from button in claim returned modal - Wrap relatives' checkouts tab in conditional so that panel doesn't appear when tab has been hidden - Fix duplicate id attributes in patron messages-related markup - Remove redundant class attribute from patron messages-related markup - Acquisitions -> Vendor -> Basket -> Add to basket -> From staged file - Remove invalid "size" attribute from hidden form fields - Circulation -> Holds awaiting pickup - Fix mismatched label and form field id - Patron -> Accounting -> Pay fine -> Submit cash amount higher than the charge - Remove invalid href attribute from button in confirmation modal - Fix errors in tab markup WRAPPERs in html_helpers.inc to prevent mismatched aria-labelledby attributes - Footer language selector: - Fix markup to correct errors in aria-controls - Remove invalid href attribute from cookie consent modal Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172679|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 174064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174064&action=edit Bug 30699: Fix various HTML validity errors in staff interface templates This patch fixes several HTML validity issues in various staff interface templates. Most of these changes won't be visible in the interface. - Advanced search: - Remove stray </a> tags - Fix duplicate IDs by adding loop.index to repeated dropdown menus - Circulation - Fix mismatched label and form field id in checkouts table footer - Fix mismatched label and form field id claim returned modal - Remove invalid href attribute from button in claim returned modal - Wrap relatives' checkouts tab in conditional so that panel doesn't appear when tab has been hidden - Fix duplicate id attributes in patron messages-related markup - Remove redundant class attribute from patron messages-related markup - Acquisitions -> Vendor -> Basket -> Add to basket -> From staged file - Remove invalid "size" attribute from hidden form fields - Circulation -> Holds awaiting pickup - Fix mismatched label and form field id - Patron -> Accounting -> Pay fine -> Submit cash amount higher than the charge - Remove invalid href attribute from button in confirmation modal - Fix errors in tab markup WRAPPERs in html_helpers.inc to prevent mismatched aria-labelledby attributes - Footer language selector: - Fix markup to correct errors in aria-controls - Remove invalid href attribute from cookie consent modal Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |aleisha@catalyst.net.nz |y.org | CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This change broke the selenium tests, but I am not sure if we should fix the template or the tests: <li data-bs-toggle="tooltip" data-bs-placement="left" title="Patron is an adult"> <a class="dropdown-item disabled" aria-disabled="true" id="updatechild" href="#">Update child to adult patron</a> <button class="dropdown-item disabled" aria-disabled="true" id="updatechild">Update child to adult patron</button> prove t/db_dependent/selenium/update_child_to_adult.t t/db_dependent/selenium/update_child_to_adult.t .. STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} /usr/share/perl5/Selenium/Remote/Driver.pm:361 in Try::Tiny::try (eval 2011):1 in Selenium::Remote::Driver::__ANON__ (eval 2013):2 in Selenium::Remote::Driver::__ANON__ /usr/share/perl5/Selenium/Remote/Driver.pm:1340 in Selenium::Remote::Driver::_execute_command /usr/share/perl5/Selenium/Remote/Driver.pm:1340 in (eval) t/db_dependent/selenium/update_child_to_adult.t:141 in Selenium::Remote::Driver::find_element /usr/share/perl/5.36/Test/Builder.pm:374 in main::__ANON__ /usr/share/perl/5.36/Test/Builder.pm:374 in (eval) /usr/share/perl/5.36/Test/More.pm:809 in Test::Builder::subtest t/db_dependent/selenium/update_child_to_adult.t:145 in Test::More::subtest /usr/share/perl/5.36/Test/Builder.pm:374 in main::__ANON__ /usr/share/perl/5.36/Test/Builder.pm:374 in (eval) /usr/share/perl/5.36/Test/More.pm:809 in Test::Builder::subtest t/db_dependent/selenium/update_child_to_adult.t:153 in Test::More::subtest # No tests run! # Failed test 'No tests run for subtest "Cannot update an adult"' # at t/db_dependent/selenium/update_child_to_adult.t line 145. # Looks like you failed 1 test of 3. t/db_dependent/selenium/update_child_to_adult.t .. 1/1 # Failed test 'Update child to patron' # at t/db_dependent/selenium/update_child_to_adult.t line 153. Error while executing command: no such element: Unable to locate element: //a[@id="updatechild"]/.. at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. at /usr/share/perl5/Selenium/Remote/Driver.pm line 356. # Looks like your test exited with 255 just after 1. t/db_dependent/selenium/update_child_to_adult.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/1 subtests Test Summary Report ------------------- t/db_dependent/selenium/update_child_to_adult.t (Wstat: 65280 (exited 255) Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 Files=1, Tests=1, 28 wallclock secs ( 0.02 usr 0.00 sys + 1.72 cusr 0.21 csys = 1.95 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174323&action=edit Bug 30699: (follow-up) Update to fix selenium test Changing an <a> to a <button> breaks test, and changing *all* the a#updatechild's to <button>s also breaks the test, so the simple solution is to change the <button> back to <a>. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Follow-up was pushed to main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to main |RESOLVED --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Too many merge conflicts to try and backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30699 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40042 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40042 [Bug 40042] search_indexes.inc may have undefined index var -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org