https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18681 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 63745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63745&action=edit Bug 18681: Translatability: Get rid of [%% in translation for about.tt Translation tool picks a line %s [%% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || ...due to a line break inside a template directive. This patch fixes it. To test: - Update QA tools (see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675#c2) - Verify that code change makes sense - Apply patch - Run QA tools -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18681 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18681 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63745|0 |1 is obsolete| | --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 63774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63774&action=edit Bug 18681: Translatability: Get rid of [%% in translation for about.tt Translation tool picks a line %s [%% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || ...due to a line break inside a template directive. This patch fixes it. To test: - Update QA tools (see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675#c2) - Verify that code change makes sense - Apply patch - Run QA tools Followed test plan and everything was as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18681 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #4 from Marc Véron <veron@veron.ch> --- Set back to NSO for the followup -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18681 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63774|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63994&action=edit Bug 18681: Translatability: Get rid of [%% in translation for about.tt Translation tool picks a line %s [%% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || ...due to a line break inside a template directive. This patch fixes it. To test: - Update QA tools (see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675#c2) - Verify that code change makes sense - Apply patch - Run QA tools Followed test plan and everything was as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18681 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63837|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63996&action=edit Bug 18681 - (followup) Remove on more [%% in translation for about.tt Test plan same as in previous patch Run QA tools in newest version (test for line breaks in tt directives) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18681 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18681 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.01 -- You are receiving this mail because: You are watching all bug changes.