https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33639 CC| |jonathan.druart+koha@gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 [Bug 33639] Adding item to item group from 'Add item' screen doesn't work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 160994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160994&action=edit Bug 35774: Use itemnumber instead of biblioitemnumber To test: ( SAME PLAN AS BZ 33639) Apply patch 1 - Browse to details page for a record 2 - Create or ensure the record has item group(s) 3 - Click New->New item 4 - Note the bottom of the page has a form to attach to existing group 5 - Note when a group is selected the enumchron field is populated 6 - Confirm item is saved to group when saved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I think I'm missing something for testing this bug. Should I notice any change in behaviour before and after the patch is applied? Everything seems to work the same for me. Also, I'm confused about step 5: 1. If you add a new item, put a value to 952$h, then add to a group, then the 952$h shouldn't change. (This is the behaviour I'm seeing.) OR 2. If existing items have a value in 952$h, then when you add a new item, it should increment? OR 3. Something else? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to David Nind from comment #2)

I think I'm missing something for testing this bug.

Should I notice any change in behaviour before and after the patch is applied? Everything seems to work the same for me.

Also, I'm confused about step 5:

1. If you add a new item, put a value to 952$h, then add to a group, then the 952$h shouldn't change. (This is the behaviour I'm seeing.)

OR

2. If existing items have a value in 952$h, then when you add a new item, it should increment?

OR

3. Something else?

David, this is my fault. I attached the wrong test plan. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774 --- Comment #6 from David Nind <david@davidnind.com> --- (In reply to Lucas Gass from comment #3)

David, this is my fault. I attached the wrong test plan.

No problem! Now signed off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161127|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 161182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161182&action=edit Bug 35774: Use itemnumber instead of biblioitemnumber With Bug 33639 already pushed to master there should be NO change in behavior. To test: 1. APPLY PATCH 2. Create one or more item groups for a bib if needed 3. Create a new item, and at the bottom of the 'Add item' screen, select the item group to which you want this item added. Save. 4. The item should succesffuly be added to the item group. 5. Add a new item and to the same record and this time try the 'Create a new item group' from the dropdown. 6. Name the new item group. 7. Make sure it is correctly added to the item group. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.