[Bug 7355] New: Hidden note subfields are not displayed in TEXTAREA if hidden
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7355 Bug #: 7355 Summary: Hidden note subfields are not displayed in TEXTAREA if hidden Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: frederic@tamil.fr QAContact: ian.walls@bywatersolutions.com In the data entry form, there is a (hidden) functionality for note subfields. MARC21 500-599 and UNIMARC 300-399 subfields are displayed in TEXTAREA rather than INPUT tags. This is good since usually notes can be pretty long. But if one of those fields is marked in the framework as 'hidden', then it isn't displayed at first when you create a record and when you expand the field by clicking on its label the field is displayed in a one-line INPUT tag. To reproduce this bug: - Modify your framework: MARC21: 500$a, hidden=1 UNIMARC: 300$a, hidden=1 - Create a new biblio record with this framework - Open the tab containing 500 or 300 field - 500 or 300 tab is collapsed - Click on 500 or 300 label to expand the field - 500$a or 300$a is displayed in a one-line INPUT tag, not in a TEXTAREA as it should -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7355 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gmcharlt@gmail.com |frederic@tamil.fr -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7355 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hidden note subfields are |Note subfields are not |not displayed in TEXTAREA |displayed in TEXTAREA if |if hidden |hidden -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7355 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> 2011-12-14 07:55:03 UTC --- Created attachment 6776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6776 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7355 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-16 06:48:37 UTC --- Hi Frederic, there is a syntax error in your patch: syntax error at /home/katrin/kohaclone/cataloguing/addbiblio.pl line 471, near "else" Global symbol "$value" requires explicit package name at /home/katrin/kohaclone/cataloguing/addbiblio.pl line 474. Global symbol "$tag" requires explicit package name at /home/katrin/kohaclone/cataloguing/addbiblio.pl line 476. Global symbol "$tag" requires explicit package name at /home/katrin/kohaclone/cataloguing/addbiblio.pl line 477. Global symbol "$subfield" requires explicit package name at /home/katrin/kohaclone/cataloguing/addbiblio.pl line 477. Global symbol "$tag" requires explicit package name at /home/katrin/kohaclone/cataloguing/addbiblio.pl line 478. Global symbol "$tag" requires explicit package name at /home/katrin/kohaclone/cataloguing/addbiblio.pl line 479. Global symbol "%subfield_data" requires explicit package name at /home/katrin/kohaclone/cataloguing/addbiblio.pl line 483. ... Can you check and resubmit? (small typo in the bug number 7335 instead of 7355) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7355 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6776|0 |1 is obsolete| | --- Comment #3 from Frédéric Demians <frederic@tamil.fr> 2011-12-16 07:35:05 UTC --- Created attachment 6830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6830 Proposed patch Thanks Katrin for testing. Rebased on HEAD. No more syntax error... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7355 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6830|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-18 07:20:08 UTC --- Created attachment 6846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6846 [SIGNED-OFF] Bug 7355 Note subfields are not displayed in TEXTAREA if hidden In the data entry form, there is a (hidden) functionality for note subfields. MARC21 500-599 and UNIMARC 300-399 subfields are displayed in TEXTAREA rather than INPUT tags. This is good since usually notes can be pretty long. But if one of those fields is marked in the framework as 'hidden', then it isn't displayed at first when you create a record and when you expand the field by clicking on its label the field is displayed in a one-line INPUT tag. To reproduce this bug: - Modify your framework: MARC21: 500$a, hidden=1 UNIMARC: 300$a, hidden=1 - Create a new biblio record with this framework - Open the tab containing 500 or 300 field - 500 or 300 tab is collapsed - Click on 500 or 300 label to expand the field - 500$a or 300$a is displayed in a one-line INPUT tag, not in a TEXTAREA as it should Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test plan works. Also checked cloning and deleting subfields still works. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7355 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 CC| |m.de.rooy@rijksmuseum.nl QAContact|koha.sekjal@gmail.com |m.de.rooy@rijksmuseum.nl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7355 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-03 10:19:57 UTC --- Created attachment 7434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7434 [PASSED_QA] Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7355 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-03 10:20:43 UTC --- Works as advertised. Simplifies code too. Well documented test plan. Incrementing status.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7355 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6846|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7355 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org