[Bug 11090] New: Bootstrap theme: CSS problem with suggestions toolbar links
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090 Bug ID: 11090 Summary: Bootstrap theme: CSS problem with suggestions toolbar links Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/opac-suggestions.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 10309 The toolbar links on the OPAC suggestions page doesn't look correct in the Bootstrap theme. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 22288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22288&action=edit Bug 11090 - Bootstrap theme: CSS problem with suggestions toolbar links There is a problem with the style on the toolbar on the suggestions page which makes it float incorrectly. This patch corrects the problem. To test, log in to the OPAC as a user who has suggestions. The selections toolbar (which shows the "select all," etc. controls) should look correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090 JD@TeTakere <joanned@tetakere.org.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joanned@tetakere.org.nz --- Comment #2 from JD@TeTakere <joanned@tetakere.org.nz> --- Created attachment 22295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22295&action=edit My Purchase Suggestions toolbar -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090 JD@TeTakere <joanned@tetakere.org.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from JD@TeTakere <joanned@tetakere.org.nz> --- Logged into Sandbox 8, viewed My Purchase Suggestions. Toolbar looks fine (screenshot attached). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090 JD@TeTakere <joanned@tetakere.org.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Pushed for QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed for QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22288|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22348&action=edit Bug 11090 - Bootstrap theme: CSS problem with suggestions toolbar links There is a problem with the style on the toolbar on the suggestions page which makes it float incorrectly. This patch corrects the problem. To test, log in to the OPAC as a user who has suggestions. The selections toolbar (which shows the "select all," etc. controls) should look correct. Signed-off-by: JD@TeTakere <joanned@tetakere.org.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to JD@TeTakere from comment #3)
Logged into Sandbox 8, viewed My Purchase Suggestions. Toolbar looks fine (screenshot attached).
I added your sign off to the patch. Please switch the status to "Signed off" instead of "Pushed for QA" when you sign off a patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11127 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- I discovered a bug on testing this patch, see bug 11127. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org