[Bug 8955] New: Self checkout should degrade gracefully with JavaScript turned off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 Priority: P5 - low Change sponsored?: --- Bug ID: 8955 Assignee: oleonard@myacpl.org Summary: Self checkout should degrade gracefully with JavaScript turned off Severity: normal Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: ASSIGNED Version: master Component: OPAC Product: Koha I see areas in self-checkout which break if JavaScript is turned off. I think an argument could be made that self-checkout can require JavaScript because the library has control over the machine it is running on. However, the problematic JavaScript dependencies I'm seeing shouldn't really require JS so I think a change is warranted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13022&action=edit Bug 8955 - Self checkout should degrade gracefully with JavaScript turned off Several changes in this patch, the largest of which is that the renew/return dialogs no longer require JavaScript in order to properly alter and submit the form. Instead each button uses a separate form. To test, log in to self checkout and submit a barcode which is checked out and can be renewd, and a barcode which is checked out but has reached the checkout limit. On the resulting dialogs each button should function properly. Also changed: I removed some useless JavaScript processing related to a bogus "valid_session" variable which was unused. Similarly removed is template logic based on a "timedout" variable which was not set by the script. Note that the script contains NO server- side handling of timeout. Timeout is dependent on JavaScript. To test these changes, confirm that with JavaScript enabled you are automatically logged out after the time specified in the SelfCheckTimeout preference. Other minor changes: Terminology and capitalization corrections, minor style tweaks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_12 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- String changes. Will hold for post-3.10.0. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13022|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13231&action=edit Bug 8955 - Self checkout should degrade gracefully with JavaScript turned off Several changes in this patch, the largest of which is that the renew/return dialogs no longer require JavaScript in order to properly alter and submit the form. Instead each button uses a separate form. To test, log in to self checkout and submit a barcode which is checked out and can be renewd, and a barcode which is checked out but has reached the checkout limit. On the resulting dialogs each button should function properly. Also changed: I removed some useless JavaScript processing related to a bogus "valid_session" variable which was unused. Similarly removed is template logic based on a "timedout" variable which was not set by the script. Note that the script contains NO server- side handling of timeout. Timeout is dependent on JavaScript. To test these changes, confirm that with JavaScript enabled you are automatically logged out after the time specified in the SelfCheckTimeout preference. Other minor changes: Terminology and capitalization corrections, minor style tweaks. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Renew and cancel buttons work with javascript disabled when scanning the barcode to renew. The renewal button on the main page does not work with javascript disabled. The renewal and checkout limits do not have any 'back' buttons, but they don't in master either. The timeout still works with javascript enabled. I think this is passing based on the test plan provided. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #5)
(In reply to comment #4)
The renewal button on the main page does not work with javascript disabled.
I missed that one. So my patch helps but more work is needed to be able to close this bug.
Yes, it does help. You can still scan a barcode to renew, so the ability to renew isn't completely lost without javascript, but the button should at least be hidden if it won't function with javascript disabled. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13268&action=edit Bug 8955 [Follow-up] Self checkout should degrade gracefully with JavaScript turned off This follow-up fixes some instance of unnecessary JavaScript which I missed the first time around: The renew and check-in buttons on the list of checkouts. The functionality can be easily accomplished without JS. Also corrected: - Capitalization error - Miss-named variable causing the "too many checkouts" not to be displayed - Misplaced [% END %] tags hidding "Return to account" button on some dialogs. - Corrected variable scope error which prevented the "return" button from appearing. To test, log into self checkout using an account which has checkouts. Testing renewing items both by scanning barcodes and by clicking the "renew" button in the list of checkouts. Renew something until it reaches its limit and test checking it out by scanning the barcode. Test the "check in" button. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13231|Bug 8955 - Self checkout |[SIGNED-OFF] Bug 8955 - description|should degrade gracefully |Self checkout should |with JavaScript turned off |degrade gracefully with | |JavaScript turned off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |paul.poulain@biblibre.com Patch complexity|--- |Trivial patch --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * passes koha-qa.pl * I can't see a difference between before and after when I'm js=ON (as expected) * I see that the follow-up has not been signed-off, so back to "need signoff". Kyle can you test this follow-up please ? I'll pass QA once you've done. PS: My feeling is that it's a (minor) enhancement, not a "normal" bugfix. Your opinion ? PS2: on my setup, I don't see the koha logo in "Powered by" (there's nothing) Is it because I'm using the -recent- ccsr theme ? what does the sco-main page look like for you ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> ---
PS2: on my setup, I don't see the koha logo in "Powered by" (there's nothing) Is it because I'm using the -recent- ccsr theme ?
Yes, the CCSR theme includes lots of errors like this in features which I assume were not deemed necessary by the original sponsors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13231|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 13962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13962&action=edit Bug 8955 - Self checkout should degrade gracefully with JavaScript turned off Several changes in this patch, the largest of which is that the renew/return dialogs no longer require JavaScript in order to properly alter and submit the form. Instead each button uses a separate form. To test, log in to self checkout and submit a barcode which is checked out and can be renewd, and a barcode which is checked out but has reached the checkout limit. On the resulting dialogs each button should function properly. Also changed: I removed some useless JavaScript processing related to a bogus "valid_session" variable which was unused. Similarly removed is template logic based on a "timedout" variable which was not set by the script. Note that the script contains NO server- side handling of timeout. Timeout is dependent on JavaScript. To test these changes, confirm that with JavaScript enabled you are automatically logged out after the time specified in the SelfCheckTimeout preference. Other minor changes: Terminology and capitalization corrections, minor style tweaks. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13268|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 13963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13963&action=edit Bug 8955 [Follow-up] Self checkout should degrade gracefully w/o JavaScript This follow-up fixes some instance of unnecessary JavaScript which I missed the first time around: The renew and check-in buttons on the list of checkouts. The functionality can be easily accomplished without JS. Also corrected: - Capitalization error - Miss-named variable causing the "too many checkouts" not to be displayed - Misplaced [% END %] tags hidding "Return to account" button on some dialogs. - Corrected variable scope error which prevented the "return" button from appearing. To test, log into self checkout using an account which has checkouts. Testing renewing items both by scanning barcodes and by clicking the "renew" button in the list of checkouts. Renew something until it reaches its limit and test checking it out by scanning the barcode. Test the "check in" button. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |paul.poulain@biblibre.com --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #8)
QA comment: * passes koha-qa.pl * I can't see a difference between before and after when I'm js=ON (as expected) * I see that the follow-up has not been signed-off, so back to "need signoff". Kyle can you test this follow-up please ? I'll pass QA once you've done.
Thanks chris for the signoff on the follow-up passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13962|0 |1 is obsolete| | Attachment #13963|0 |1 is obsolete| | --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14247&action=edit Bug 8955 - Self checkout should degrade gracefully with JavaScript turned off Several changes in this patch, the largest of which is that the renew/return dialogs no longer require JavaScript in order to properly alter and submit the form. Instead each button uses a separate form. To test, log in to self checkout and submit a barcode which is checked out and can be renewd, and a barcode which is checked out but has reached the checkout limit. On the resulting dialogs each button should function properly. Also changed: I removed some useless JavaScript processing related to a bogus "valid_session" variable which was unused. Similarly removed is template logic based on a "timedout" variable which was not set by the script. Note that the script contains NO server- side handling of timeout. Timeout is dependent on JavaScript. To test these changes, confirm that with JavaScript enabled you are automatically logged out after the time specified in the SelfCheckTimeout preference. Other minor changes: Terminology and capitalization corrections, minor style tweaks. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14248&action=edit Bug 8955 [Follow-up] Self checkout should degrade gracefully w/o JavaScript This follow-up fixes some instance of unnecessary JavaScript which I missed the first time around: The renew and check-in buttons on the list of checkouts. The functionality can be easily accomplished without JS. Also corrected: - Capitalization error - Miss-named variable causing the "too many checkouts" not to be displayed - Misplaced [% END %] tags hidding "Return to account" button on some dialogs. - Corrected variable scope error which prevented the "return" button from appearing. To test, log into self checkout using an account which has checkouts. Testing renewing items both by scanning barcodes and by clicking the "renew" button in the list of checkouts. Renew something until it reaches its limit and test checking it out by scanning the barcode. Test the "check in" button. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org