[Bug 17993] New: Do not use modal authentication with CAS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Bug ID: 17993 Summary: Do not use modal authentication with CAS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in other links leading to authentication like for lists and tags. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12046 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 [Bug 12046] Authentication using CAS - bootstrap -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 59549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59549&action=edit Bug 17993 - Do not use modal authentication with CAS - lists Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link of lists popup : "Log in to create your own lists" Test plan : - Enable syspref casAuthentication - Go to OPAC - Click on Lists > Log in to create your own lists => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 59550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59550&action=edit Bug 17993 - Do not use modal authentication with CAS - tags Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link for tags in detail page : "Log in to add tags" Test plan : - Enable syspref casAuthentication - Go to OPAC - Go to a record detail page opac-detail.pl - Click on "Log in to add tags" => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59549|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59719&action=edit Bug 17993 - Do not use modal authentication with CAS - lists Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link of lists popup : "Log in to create your own lists" Test plan : - Enable syspref casAuthentication - Go to OPAC - Click on Lists > Log in to create your own lists => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59550|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59720&action=edit Bug 17993 - Do not use modal authentication with CAS - tags Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link for tags in detail page : "Log in to add tags" Test plan : - Enable syspref casAuthentication - Go to OPAC - Go to a record detail page opac-detail.pl - Click on "Log in to add tags" => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |In Discussion --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Missed a spot: opac-tags.pl Is that fixed elsewhere, or should it be fixed here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to M. Tompsett from comment #5)
Missed a spot: opac-tags.pl Is that fixed elsewhere, or should it be fixed here?
Indeed, I'll fix this -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 61642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61642&action=edit Bug 17993 - Do not use modal authentication with CAS - tags bis Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link for tags in detail tags page : "Log in to see your own saved tags." Test plan : - Enable syspref casAuthentication - Go to OPAC, not authenticated - Click on "Tag cloud" - Click on "Log in to see your own saved tags" => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- "tags bis" needs sign off. Mark, thanks a lot for your help. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61642|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 62296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62296&action=edit [SIGNED-OFF] Bug 17993 - Do not use modal authentication with CAS - tags bis Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link for tags in detail tags page: "Log in to see your own saved tags." Test plan : - Enable syspref casAuthentication - Go to OPAC, not authenticated - Click on "Tag cloud" - Click on "Log in to see your own saved tags" => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59719|0 |1 is obsolete| | Attachment #59720|0 |1 is obsolete| | Attachment #62296|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62867&action=edit Bug 17993 - Do not use modal authentication with CAS - lists Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link of lists popup : "Log in to create your own lists" Test plan : - Enable syspref casAuthentication - Go to OPAC - Click on Lists > Log in to create your own lists => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62868&action=edit Bug 17993 - Do not use modal authentication with CAS - tags Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link for tags in detail page : "Log in to add tags" Test plan : - Enable syspref casAuthentication - Go to OPAC - Go to a record detail page opac-detail.pl - Click on "Log in to add tags" => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62869&action=edit Bug 17993 - Do not use modal authentication with CAS - tags bis Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link for tags in detail tags page: "Log in to see your own saved tags." Test plan : - Enable syspref casAuthentication - Go to OPAC, not authenticated - Click on "Tag cloud" - Click on "Log in to see your own saved tags" => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Frido! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #15 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org