https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92241&action=edit Bug 23464: Update the process of quick spine label printing This patch makes changes to the way quick spine label printing works, either from the bibliographic details page or the Quick spine label creator page. To test, apply the patch and go to Tools -> Quick spine label creator. - Type or scan a barcode. Submitting the form should trigger a popup window with the spine label print page. The "print" button should be centered at the bottom of the window in a footer-like container. - If you have SpineLabelAutoPrint enabled, the print dialog should appear automatically. - After printing, the pop-up window should close and and focus should be returned to the barcode field. Enable the SpineLabelShowPrintOnBibDetails system preference. View the bibliographic details page for a record in the catalog. - In the holdings table, a "Spine label" column should appear as the second-to-last column. The column should contain "Print label" Bootstrap-style buttons. - Clicking a "Print label" button should trigger a pop-up window with the spine label print page. The behavior of the window should be the same as above. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |maryse.simard@inlibro.com --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- For me, even with SpineLabelAutoPrint enabled, the print dialog doesn't show automatically. It seems to be because the test for the syspref is inside an [% IF ( IntranetUserJS ) %] block. As a matter of fact, when I try putting some code in IntranetUserJS, the SpineLabelAutoPrint syspref then works as expected. Also, when I search for a barcode that doesn't exist, the pop-up tells me the barcode is not found with a link to go back to the previous page. I think it would be nicer and make more sense if the link would be replaced by a close button (or even removed altogether) since we don't want to go back to the page in the popup window. Maybe a close button looking just like the one for printing when the barcode is found? (I like that button, I think it looks really good) Everything else works perfectly! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92445&action=edit Bug 23464: (follow-up) QA fixes This patch corrects two issues raised during testing: - Move JavaScript out of template check for IntranetUserJS so that SpineLabelAutoPrint behavior works correctly. - Add "close" button to pop-up window for cases when the barcode was not found. Also changed: - Added "required" attribute to barcode input on quick spine label printing page so that submitting an empty form will not work. - Tweaked CSS slightly to fix alignment of spine label form and submit button. (You must rebuild the staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92445|0 |1 is obsolete| | --- Comment #5 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 92460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92460&action=edit Bug 23464: (follow-up) QA fixes This patch corrects two issues raised during testing: - Move JavaScript out of template check for IntranetUserJS so that SpineLabelAutoPrint behavior works correctly. - Add "close" button to pop-up window for cases when the barcode was not found. Also changed: - Added "required" attribute to barcode input on quick spine label printing page so that submitting an empty form will not work. - Tweaked CSS slightly to fix alignment of spine label form and submit button. (You must rebuild the staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am testing this with the sample data and the callnumber is not showing up for me in the print preview: 3999900000018 005.13/3 Can someone confirm? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92460|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92532&action=edit Bug 23464: (follow-up) QA fixes This patch corrects two issues raised during testing: - Move JavaScript out of template check for IntranetUserJS so that SpineLabelAutoPrint behavior works correctly. - Add "close" button to pop-up window for cases when the barcode was not found. Also changed: - Added "required" attribute to barcode input on quick spine label printing page so that submitting an empty form will not work. - Tweaked CSS slightly to fix alignment of spine label form and submit button. (You must rebuild the staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.