[Bug 32693] New: The 'About Koha' page loads slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Bug ID: 32693 Summary: The 'About Koha' page loads slowly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org The 'About Koha' page in the staff interface is noticeably slower to load than other pages in the staff interface (for me, anyway). Using the browser web developer network tools, it shows it took about 4-5 seconds to load the first time (after a flush_memcached, restart_all, and a browser with a cleared cache). Subsequent loads are a lot quicker (about 1-2 seconds). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161832&action=edit Bug 32693: Proof of concept This is a PoC for discussion. Now, only the tab being viewed is processed and loaded. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #2 from David Nind <david@davidnind.com> --- Thanks Pedro! I was keen to test your PoC, but got this when trying to apply the patch: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 32693: Proof of concept .git/rebase-apply/patch:65: trailing whitespace. error: sha1 information is lacking or useless (about.pl). error: could not build fake ancestor Patch failed at 0001 Bug 32693: Proof of concept -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161832|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161881&action=edit Bug 32693: Proof of concept This is a PoC for discussion. Now, only the tab being viewed is processed and loaded. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to David Nind from comment #2)
Thanks Pedro!
I was keen to test your PoC, but got this when trying to apply the patch:
Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 32693: Proof of concept .git/rebase-apply/patch:65: trailing whitespace.
error: sha1 information is lacking or useless (about.pl). error: could not build fake ancestor Patch failed at 0001 Bug 32693: Proof of concept
Apologies, this was written on top of other work unintentionally. I've rebased and should apply nicely now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161881|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161883&action=edit Bug 32693: Proof of concept This is a PoC for discussion. Now, only the tab being viewed is processed and loaded. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34063 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36039 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36039 [Bug 36039] Output of database_audit.pl should be accessible through UI -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #6 from David Nind <david@davidnind.com> --- Notes from testing (using KTD) ============================== I would say this makes a really good difference - apart from the System information tab, every other tab feels faster to load. I'm assuming for the system information tab that there is a lot to check, and this will depend on the Koha instance configuration. Before the patch ~~~~~~~~~~~~~~~~ - Initial: 19 requests 1.23 MB / 59.46 kB transferred Finish: 3.77 s DOMContentLoaded: 3.75 s load: 3.75 s - Reload (go somewhere else, such as the home page, then go back to the Abut Koha page): 18 requests 875.75 kB / 59.45 kB transferred Finish: 1.28 s DOMContentLoaded: 1.26 s load: 1.27 s - Refresh the page (Shift + Refresh button): 30 requests 1.78 MB / 389.59 kB transferred Finish: 1.38 s DOMContentLoaded: 1.37 s load: 1.39 s Note: With a refresh, a recurring error is (Bug 34973): downloadable font: Glyph bbox was incorrect (glyph ids 1 2 3 .......) (font-family: "Font Awesome 6 Free" style:normal weight:900 stretch:100 src index:0) source: http://127.0.0.1:8081/intranet-tmpl/lib/fontawesome/webfonts/fa-solid-900.wo... After applying the PoC patch ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (plus a flush_memcached, restart_all, and a fresh browser) Server information tab: - Initial: 19 requests 382.89 kB / 6.41 kB transferred Finish: 636 ms DOMContentLoaded: 612 ms load: 613 ms - Reload: 19 requests 165.26 kB / 29.78 kB transferred Finish: 653 ms DOMContentLoaded: 643 ms load: 652 ms - Refresh: 29 requests 891.46 kB / 336.53 kB transferred Finish: 603 ms DOMContentLoaded: 593 ms load: 610 ms Perl modules tab: - Initial: 18 requests 514.49 kB / 10.18 kB transferred Finish: 1.12 s DOMContentLoaded: 1.12 s load: 1.12 s - Reload: 18 requests 215.33 kB / 10.18 kB transferred Finish: 528 ms DOMContentLoaded: 519 ms load: 521 ms - Refresh: 30 requests 1.12 MB / 340.32 kB transferred Finish: 579 ms DOMContentLoaded: 564 ms load: 582 ms System information tab - Initial: 18 requests 28.45 kB / 5.70 kB transferred Finish: 3.13 s DOMContentLoaded: 3.11 s load: 3.11 s - Reload: 18 requests 28.45 kB / 5.70 kB transferred Finish: 1.17 s DOMContentLoaded: 1.16 s load: 1.16 s - Refresh: 30 requests 936.88 kB / 335.83 kB transferred Finish: 1.37 s DOMContentLoaded: 1.34 s load: 1.37 s (One warning in default KTD: Warning System preference 'RequireChoosingExistingAuthority' is disabled, but needs 'AutoCreateAuthorites' enabled. Otherwise catalogers can add headings that will not be linked to authorities) Koha team tab: - Initial: 18 requests 127.34 kB / 18.85 kB transferred Finish: 577 ms DOMContentLoaded: 573 ms load: 598 ms - Reload: 18 requests 127.34 kB / 18.86 kB transferred Finish: 632 ms DOMContentLoaded: 627 ms load: 630 ms - Refresh: 30 requests 1.04 MB / 349 kB transferred Finish: 664 ms DOMContentLoaded: 621 ms load: 672 ms Licenses tab: - Initial: 18 requests 41.74 kB / 8.21 kB transferred Finish: 510 ms DOMContentLoaded: 487 ms load: 494 ms - Reload: 18 requests 41.74 kB / 8.21 kB transferred Finish: 511 ms DOMContentLoaded: 494 ms load: 495 ms - Refresh: 30 requests 950.17 kB / 338.34 kB transferred Finish: 522 ms DOMContentLoaded: 506 ms load: 527 ms Translations tab: - Initial: 18 requests 31.09 kB / 7.35 kB transferred Finish: 497 ms DOMContentLoaded: 492 ms load: 493 ms - Reload: 18 requests 31.09 kB / 7.35 kB transferred Finish: 499 ms DOMContentLoaded: 496 ms load: 497 ms - Refresh: 29 requests 889.17 kB / 337.48 kB transferred Finish: 510 ms DOMContentLoaded: 504 ms load: 516 ms Timeline tab: - Initial: 18 requests 554.09 kB / 35.05 kB transferred Finish: 591 ms DOMContentLoaded: 563 ms load: 591 ms - Reload: 18 requests 554.09 kB / 35.06 kB transferred Finish: 576 ms DOMContentLoaded: 547 ms load: 574 ms - Refresh: 30 requests 1.46 MB / 365.19 kB transferred Finish: 606 ms DOMContentLoaded: 604 ms load: 613 ms Dedications tab: - Initial: 19 requests 159.28 kB / 29.19 kB transferred Finish: 509 ms DOMContentLoaded: 501 ms load: 508 ms - Reload: 18 requests 27.39 kB / 5.82 kB transferred Finish: 487 ms DOMContentLoaded: 473 ms load: 474 ms - Refresh: 30 requests 935.83 kB / 335.96 kB transferred Finish: 518 ms DOMContentLoaded: 504 ms load: 524 ms -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- David, that's great, thank you so much for this analysis. I think the biggest improvement for me here is the much shorter time to first render. With this patch, whenever you click the "About" main menu item (default server information tab), it's no longer a slog. If others agree with this approach (Katrin, Martin, Tomas, Joubu?), I'll pick this back up to finish and tidy up the patch for submission. If not, or there are other better alternative suggestions, please do say. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is a great improvement; It's something I've always intended to do but never hit the top of the pile. Yes please, do the final polishing you see fit Pedro, I think this, and the subsequent bugs that apply on top will really help system administrators with spotted issues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161883|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162208&action=edit Bug 32693: Update tab_item html helper tab_item html helper now allows for a boolean tablink option to set if the the tab item is a link or not -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162209&action=edit Bug 32693: Update tab_items tab_items are now linktabs tab_items are now styled active depending if the URL param 'tab' matches the tab name or not -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162210&action=edit Bug 32693: Update tab_panels Each tab panel's content has now been moved to its own BLOCK. Each tab panel's content is now only loaded if said tab is the one being viewed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162211&action=edit Bug 32693: Preparation: About script: docdir docdir is used in both team + history tabs was previously being loaded in team and additionally used in history but because now we're only loading one tab at a time, we need to move this -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162212&action=edit Bug 32693: Preparation: About script: Move template params These template params are only used in the default first 'about' tab but were being added further down in the script -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162213&action=edit Bug 32693: Preparation: About script: versions versions is being used in both 'team' and 'about' tabs, needs to be moved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162214&action=edit Bug 32693: About script: Process only the tab being queried -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162208|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 162219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162219&action=edit Bug 32693: Update tab_item html helper tab_item html helper now allows for a boolean tablink option to set if the the tab item is a link or not Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162209|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 162220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162220&action=edit Bug 32693: Update tab_items tab_items are now linktabs tab_items are now styled active depending if the URL param 'tab' matches the tab name or not Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162210|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 162221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162221&action=edit Bug 32693: Update tab_panels Each tab panel's content has now been moved to its own BLOCK. Each tab panel's content is now only loaded if said tab is the one being viewed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162211|0 |1 is obsolete| | --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 162222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162222&action=edit Bug 32693: Preparation: About script: docdir docdir is used in both team + history tabs was previously being loaded in team and additionally used in history but because now we're only loading one tab at a time, we need to move this Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162212|0 |1 is obsolete| | --- Comment #20 from David Nind <david@davidnind.com> --- Created attachment 162223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162223&action=edit Bug 32693: Preparation: About script: Move template params These template params are only used in the default first 'about' tab but were being added further down in the script Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162213|0 |1 is obsolete| | --- Comment #21 from David Nind <david@davidnind.com> --- Created attachment 162224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162224&action=edit Bug 32693: Preparation: About script: versions versions is being used in both 'team' and 'about' tabs, needs to be moved Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162214|0 |1 is obsolete| | --- Comment #22 from David Nind <david@davidnind.com> --- Created attachment 162225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162225&action=edit Bug 32693: About script: Process only the tab being queried Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #23 from David Nind <david@davidnind.com> --- Have signed off. I hope this was reading for testing! I repeated the timings from comment #6, and things seem to load even faster (particularly the system information tab: 2.37s, 599ms, and 970ms respectively). All the tabs look OK and display as expected for me (tested using Firefox and Chromium). Improving the page titles and breadcrumb would be a bonus (instead of just 'About Koha'), but I think that could be a separate bug - happy to create it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart+koha@gmail. |y.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Severity|minor |enhancement --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- About is slow. But this feels much more as enh than bugfix. Correct me if I am mistaken.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #25 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #24)
About is slow. But this feels much more as enh than bugfix. Correct me if I am mistaken..
Agreed. Yes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162219|0 |1 is obsolete| | Attachment #162220|0 |1 is obsolete| | Attachment #162221|0 |1 is obsolete| | Attachment #162222|0 |1 is obsolete| | Attachment #162223|0 |1 is obsolete| | Attachment #162224|0 |1 is obsolete| | Attachment #162225|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 162660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162660&action=edit Bug 32693: Update tab_item html helper tab_item html helper now allows for a boolean tablink option to set if the the tab item is a link or not Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 162661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162661&action=edit Bug 32693: Update tab_items tab_items are now linktabs tab_items are now styled active depending if the URL param 'tab' matches the tab name or not Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 162662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162662&action=edit Bug 32693: Update tab_panels Each tab panel's content has now been moved to its own BLOCK. Each tab panel's content is now only loaded if said tab is the one being viewed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 162663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162663&action=edit Bug 32693: Preparation: About script: docdir docdir is used in both team + history tabs was previously being loaded in team and additionally used in history but because now we're only loading one tab at a time, we need to move this Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 162664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162664&action=edit Bug 32693: Preparation: About script: Move template params These template params are only used in the default first 'about' tab but were being added further down in the script Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #31 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 162665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162665&action=edit Bug 32693: Preparation: About script: versions versions is being used in both 'team' and 'about' tabs, needs to be moved Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #32 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 162666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162666&action=edit Bug 32693: About script: Process only the tab being queried Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement improves release notes| |the 'About Koha' page | |loading time. Instead of | |loading all the tabs at | |once, the content is loaded | |when the tab is selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 32693: Update tab_item html helper Applying: Bug 32693: Update tab_items Applying: Bug 32693: Update tab_panels Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/about.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/about.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/about.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 32693: Update tab_panels hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-32693-Update-tabpanels-_ghrc9c6.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162660|0 |1 is obsolete| | --- Comment #35 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165251&action=edit Bug 32693: Update tab_item html helper tab_item html helper now allows for a boolean tablink option to set if the the tab item is a link or not Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162661|0 |1 is obsolete| | --- Comment #36 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165252&action=edit Bug 32693: Update tab_items tab_items are now linktabs tab_items are now styled active depending if the URL param 'tab' matches the tab name or not Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162662|0 |1 is obsolete| | --- Comment #37 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165253&action=edit Bug 32693: Update tab_panels Each tab panel's content has now been moved to its own BLOCK. Each tab panel's content is now only loaded if said tab is the one being viewed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162663|0 |1 is obsolete| | --- Comment #38 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165254&action=edit Bug 32693: Preparation: About script: docdir docdir is used in both team + history tabs was previously being loaded in team and additionally used in history but because now we're only loading one tab at a time, we need to move this Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162664|0 |1 is obsolete| | --- Comment #39 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165255&action=edit Bug 32693: Preparation: About script: Move template params These template params are only used in the default first 'about' tab but were being added further down in the script Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162665|0 |1 is obsolete| | --- Comment #40 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165256&action=edit Bug 32693: Preparation: About script: versions versions is being used in both 'team' and 'about' tabs, needs to be moved Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162666|0 |1 is obsolete| | --- Comment #41 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165257&action=edit Bug 32693: About script: Process only the tab being queried Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33703 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 [Bug 33703] Entering dates should be more flexible accepting different entry formats -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #43 from Jonathan Druart <jonathan.druart@gmail.com> --- It broke t/db_dependent/www/history.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #44 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 166421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166421&action=edit Bug 32693: Fix history.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Follow-up for history.t pushed (soon). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #46 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@ptfs-europe. | |com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #47 from Aude Charillon <aude.charillon@ptfs-europe.com> --- No update to the Manual needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37260 [Bug 37260] Problem with connection to broker not displayed on the about page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37509 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37509 [Bug 37509] (Bug 32693 follow-up) Elasticsearch status info missing from 'Server information' -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org