[Bug 26949] New: Upgrade TinyMCE in the staff interface from 5.0.16 to 5.5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 Bug ID: 26949 Summary: Upgrade TinyMCE in the staff interface from 5.0.16 to 5.5.1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The version of TinyMCE we use in the staff client is a little over a year old now. As long as we are talking about issues with it (like Bug 26942) I think it's worthwhile to get it up to date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- This patch is too large to attach. Remote branch is here: https://gitlab.com/koha-dev/koha-dev/-/tree/bug-26949-tinymce-upgrade -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Hi Owen. I have tested (I managed to figure out how to checkout a remote branch from a different repository!). Everything seems to work as it did before. However, a couple of things I noticed: - Nothing happens when I click on the Visual aids and Help icons: this behavour is also on master as well). - On the About Koha > Licenses page the licence for TinyMCE still shows as v5.0.016. - Select the Display location for news: this is probably not related to this bug, but there is some odd behavour happening: . When you add a new news item, All is an option . When you go to edit the news item the option list displays as empty and there is no All option in the drop down list (still shows in the list of all news item as All) . If you change it to something else, save, then go to edit again, All reappears as an option So for the bug itself, I'm signing off. I don't know how to sign off a change for a remote branch in another repository, but I'm happy to sign off. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Remove branch is updated to remove the "Visual aid" and "Help" buttons which don't work. The about page is updated to reflect the correct version and copyright information. https://gitlab.com/koha-dev/koha-dev/-/tree/bug-26949-tinymce-upgrade ---------------------- Bug 26949: Upgrade TinyMCE in the staff interface from 5.0.16 to 5.5.1 This patch upgrades TinyMCE in the staff interface from 5.0.16 to 5.5.1. Other than the required TinyMCE package files, the only other change is to the internationalization include file, which is updated to include the latest set of strings for translation. To test, apply the patch and clear your browser cache if necessary. Test that the TinyMCE editor works in the staff interface: - In system preferences, with the UseWYSIWYGinSystemPreferences preference enabled: IntranetCirculationHomeHTML, IntranetmainUserblock, IntranetReportsHomeHTML, etc. - News, with the NewsToolEditor preference set to "WYSIWYG." - Administration -> Libraries, in the "OPAC info" field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 --- Comment #4 from David Nind <david@davidnind.com> --- Hi Owen. I've retested and everything seems okay. The only thing I noticed was that on the Administration > Libraries input form the Visual Aids and Help buttons are back, everywhere else I could fine those buttons are not there. I assume to sign off, I just change the status to signed off? David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- I've updated the remote branch again, this time with the upgrade taking us to TinyMCE version 5.9.2.
https://gitlab.com/koha-dev/koha-dev/-/tree/bug-26949-tinymce-upgrade
---------------------- Other than the required TinyMCE package files, the only other change is to the internationalization include file, which is updated to include the latest set of strings for translation. To test, apply the patch and clear your browser cache if necessary. Test that the TinyMCE editor works in the staff interface: - In system preferences, with the UseWYSIWYGinSystemPreferences preference enabled: IntranetCirculationHomeHTML, IntranetmainUserblock, IntranetReportsHomeHTML, etc. - Additional contents, with the AdditionalContentsEditor preference set to "WYSIWYG." - Administration -> Libraries, in the "OPAC info" field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 --- Comment #6 from David Nind <david@davidnind.com> --- Hi Owen. I've retested and happy to sign-off. The only minor thing noted was the version number for TinyMCE needs updating in the about page. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 --- Comment #7 from David Nind <david@davidnind.com> --- Awesome - thanks for fixing Owen. Happy to ad my sign off. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- The remote branch has been updated to add David's signoff. Thanks David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Upgrade TinyMCE in the |Upgrade TinyMCE in the |staff interface from 5.0.16 |staff interface from 5.0.16 |to 5.5.1 |to 5.9.2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- No problems spotted, can you please add my sign-offs as well? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #9)
No problems spotted, can you please add my sign-offs as well? :)
Remote branch updated to add Katrin's signoff. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31558 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 [Bug 31558] Upgrade of TinyMCE broke image drag and drop -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40123 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org