[Bug 42397] New: ILL batches logged under 'ILL' action_logs modulename cause conflict with ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 Bug ID: 42397 Summary: ILL batches logged under 'ILL' action_logs modulename cause conflict with ILL requests Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com, pedro.amorim@openfifth.co.uk, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edith.speller@ukhsa.gov.uk, | |jeremy.evans@ukhsa.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197493&action=edit Bug 42397: Add 'ILL_BATCHES' action_logs modulename Update ILL/Batch.pm and ILL/Batch/Status.pm to utilize this new modulename instead -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197494&action=edit Bug 42397: Add and update ILL batch related tests Add new tests to assert the usage of the new ILL_BATCHES action_logs modulename. Update existing tests to utilize real log_something instead of mocking it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197495&action=edit Bug 42397: Atomicupdate 1) Enable ILLModule and IllLog system preferences. 2) Install a metadata enrichment plugin that supports ILL batches (restart plack if needed), e.g.: https://github.com/openfifth/koha-plugin-api-pubmed/releases 3) Visit ILL module: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 4) Click the 'New ILL requests batch' button 5) Enter any name, cardnumber '42' and any library. Click 'Continue' 6) Add a pubmedid (e.g. '123') and click process identifiers. 7) Click 'Add items to batch' and 'Finish and view batch'. 8) Visit the ILL request we just created: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 9) Confirm it explodes with a nasty 500 error 10) Apply patches, updatedatabase and restart plack. 11) Repeat 8). Confirm it no longer explodes 12) Click' ILL request log'. Confirm it shows the correct log(s) relative to this ILL request 13) Visit the log viewer and query for 'Interlibrary loans': http://localhost:8081/cgi-bin/koha/tools/viewlog.pl?src=&user=&modules=ILL&actions=&object=&info=&interfaces=&from=&to=&output=screen&basename=Export&report_name=&do_it=1 14) Confirm only ILL requests are shown, do the same for ILL batches: http://localhost:8081/cgi-bin/koha/tools/viewlog.pl?do_it=1&src=&user=&modules=ILL_BATCHES&actions=&object=&info=&interfaces=&from=&to=&output=screen&basename=Export&report_name=&do_it=1 15) Confirm only ILL batches are shown 16) Run all ILL batch relevant tests: prove t/db_dependent/Koha/ILL/Batch* -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197495|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197496&action=edit Bug 42397: Atomicupdate 1) Enable ILLModule and IllLog system preferences. 2) Install a metadata enrichment plugin that supports ILL batches (restart plack if needed), e.g.: https://github.com/openfifth/koha-plugin-api-pubmed/releases 3) Visit ILL module: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 4) Click the 'New ILL requests batch' button 5) Enter any name, cardnumber '42' and any library. Click 'Continue' 6) Add a pubmedid (e.g. '123') and click process identifiers. 7) Click 'Add items to batch' and 'Finish and view batch'. 8) Visit the ILL request we just created: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 9) Confirm it explodes with a nasty 500 error 10) Apply patches, updatedatabase and restart plack. 11) Repeat 8). Confirm it no longer explodes 12) Click' ILL request log'. Confirm it shows the correct log(s) relative to this ILL request 13) Visit the log viewer and query for 'Interlibrary loans': http://localhost:8081/cgi-bin/koha/tools/viewlog.pl?src=&user=&modules=ILL&actions=&object=&info=&interfaces=&from=&to=&output=screen&basename=Export&report_name=&do_it=1 14) Confirm only ILL requests are shown, do the same for ILL batches: http://localhost:8081/cgi-bin/koha/tools/viewlog.pl?do_it=1&src=&user=&modules=ILL_BATCHES&actions=&object=&info=&interfaces=&from=&to=&output=screen&basename=Export&report_name=&do_it=1 15) Confirm only ILL batches are shown 16) Run all ILL batch relevant tests: prove t/db_dependent/Koha/ILL/Batch* -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197493|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197494|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 197727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197727&action=edit Bug 42397: Add 'ILL_BATCHES' action_logs modulename Update ILL/Batch.pm and ILL/Batch/Status.pm to utilize this new modulename instead Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 197728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197728&action=edit Bug 42397: Add and update ILL batch related tests Add new tests to assert the usage of the new ILL_BATCHES action_logs modulename. Update existing tests to utilize real log_something instead of mocking it. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 197729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197729&action=edit Bug 42397: Atomicupdate 1) Enable ILLModule and IllLog system preferences. 2) Install a metadata enrichment plugin that supports ILL batches (restart plack if needed), e.g.: https://github.com/openfifth/koha-plugin-api-pubmed/releases 3) Visit ILL module: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 4) Click the 'New ILL requests batch' button 5) Enter any name, cardnumber '42' and any library. Click 'Continue' 6) Add a pubmedid (e.g. '123') and click process identifiers. 7) Click 'Add items to batch' and 'Finish and view batch'. 8) Visit the ILL request we just created: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 9) Confirm it explodes with a nasty 500 error 10) Apply patches, updatedatabase and restart plack. 11) Repeat 8). Confirm it no longer explodes 12) Click' ILL request log'. Confirm it shows the correct log(s) relative to this ILL request 13) Visit the log viewer and query for 'Interlibrary loans': http://localhost:8081/cgi-bin/koha/tools/viewlog.pl?src=&user=&modules=ILL&actions=&object=&info=&interfaces=&from=&to=&output=screen&basename=Export&report_name=&do_it=1 14) Confirm only ILL requests are shown, do the same for ILL batches: http://localhost:8081/cgi-bin/koha/tools/viewlog.pl?do_it=1&src=&user=&modules=ILL_BATCHES&actions=&object=&info=&interfaces=&from=&to=&output=screen&basename=Export&report_name=&do_it=1 15) Confirm only ILL batches are shown 16) Run all ILL batch relevant tests: prove t/db_dependent/Koha/ILL/Batch* Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m --- Comment #8 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi Lisette, would you be available to QA here when convenient? Thank you in advance! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Lisette Scheer <lisette@bywatersolutions.com> --- Worked great, thanks. It's not new so I won't fail over it, but adding the JSON diff from the coding guidelines would be great. https://wiki.koha-community.org/wiki/Coding_Guidelines#ACTN1:_New_additions_... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197727|0 |1 is obsolete| | Attachment #197728|0 |1 is obsolete| | Attachment #197729|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 --- Comment #10 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 200657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200657&action=edit Bug 42397: Add 'ILL_BATCHES' action_logs modulename Update ILL/Batch.pm and ILL/Batch/Status.pm to utilize this new modulename instead Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 --- Comment #11 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 200658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200658&action=edit Bug 42397: Add and update ILL batch related tests Add new tests to assert the usage of the new ILL_BATCHES action_logs modulename. Update existing tests to utilize real log_something instead of mocking it. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 --- Comment #12 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 200659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200659&action=edit Bug 42397: Atomicupdate 1) Enable ILLModule and IllLog system preferences. 2) Install a metadata enrichment plugin that supports ILL batches (restart plack if needed), e.g.: https://github.com/openfifth/koha-plugin-api-pubmed/releases 3) Visit ILL module: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 4) Click the 'New ILL requests batch' button 5) Enter any name, cardnumber '42' and any library. Click 'Continue' 6) Add a pubmedid (e.g. '123') and click process identifiers. 7) Click 'Add items to batch' and 'Finish and view batch'. 8) Visit the ILL request we just created: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 9) Confirm it explodes with a nasty 500 error 10) Apply patches, updatedatabase and restart plack. 11) Repeat 8). Confirm it no longer explodes 12) Click' ILL request log'. Confirm it shows the correct log(s) relative to this ILL request 13) Visit the log viewer and query for 'Interlibrary loans': http://localhost:8081/cgi-bin/koha/tools/viewlog.pl?src=&user=&modules=ILL&actions=&object=&info=&interfaces=&from=&to=&output=screen&basename=Export&report_name=&do_it=1 14) Confirm only ILL requests are shown, do the same for ILL batches: http://localhost:8081/cgi-bin/koha/tools/viewlog.pl?do_it=1&src=&user=&modules=ILL_BATCHES&actions=&object=&info=&interfaces=&from=&to=&output=screen&basename=Export&report_name=&do_it=1 15) Confirm only ILL batches are shown 16) Run all ILL batch relevant tests: prove t/db_dependent/Koha/ILL/Batch* Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 --- Comment #13 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue where release notes| |ILL batch activity was | |incorrectly mixed with ILL | |request logs, causing a 500 | |error when viewing affected | |ILL requests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.02 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #15 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Not reproduced on 25.11, not backporting unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes an issue where |This fixes an issue where release notes|ILL batch activity was |ILL batch activity was |incorrectly mixed with ILL |incorrectly mixed with ILL |request logs, causing a 500 |request logs, causing a 500 |error when viewing affected |error when viewing affected |ILL requests. |ILL requests. | | | |It also adds "Interlibrary | |loan batches" as a module | |to the log viewer. --- Comment #16 from David Nind <david@davidnind.com> --- Updates to the manual required: 1. "Interlibrary loan batches" is a new module available in the log viewer tool. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42397 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate --- Comment #17 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #15)
Not reproduced on 25.11, not backporting unless requested
Hi Baptiste, it is reproducible on 25.11: 1) Enable ILLModule and IllLog system preferences. 2) Install a metadata enrichment plugin that supports ILL batches (restart plack if needed), e.g.: https://github.com/openfifth/koha-plugin-api-pubmed/releases 3) Visit ILL module: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 4) Click the 'New ILL requests batch' button 5) Enter any name, cardnumber '42' and any library. Click 'Continue' 6) Add a pubmedid (e.g. '123') and click process identifiers. 7) Click 'Add items to batch' and 'Finish and view batch'. 8) Visit the ILL request we just created: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 9) Confirm it explodes with a nasty 500 error Please backport! Thank you! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org