[Bug 12040] New: Add STMP authentication parameters to runreports.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Bug ID: 12040 Summary: Add STMP authentication parameters to runreports.pl Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: cnighswonger@foundations.edu QA Contact: testopia@bugs.koha-community.org Created attachment 26872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26872&action=edit Patch to add auth params This patch adds three params to allow for SMTP authentication -username -> Username to pass to the SMTP server for authentication -password -> Password to pass to the SMTP server for authentication -method -> Method is the type of authentication. Ie. LOGIN, DIGEST-MD5, etc. See the misc/cronjobs/CONFIGURE.gmail for an example of the use of these params. I'm not quite sure how to approach constructing an automated test for this as any test will require a working SMTP account on a server requiring authentication. As for testing manually using a Gmail account: 1. Set up your sendmail as shown in misc/cronjobs/CONFIGURE.gmail 2. Before applying this patch, run misc/cronjobs/runreports.pl on your favorite report including the proper email parameters against your gmail account. 3. Note the failure message stating the authentication requirement. 4. Apply this patch, and return the script including the additional parameters and specifying "LOGIN" for the method. 5. Note the successful send. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored Assignee|gmcharlt@gmail.com |cnighswonger@foundations.ed | |u -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26872|0 |1 is obsolete| | --- Comment #1 from Chris Nighswonger <cnighswonger@foundations.edu> --- Comment on attachment 26872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26872 Patch to add auth params Yikes! Monday strikes again. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 --- Comment #2 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 26873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26873&action=edit Patch to add auth params -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- This may overlap / cause rebase needs with bug 12031. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26873|0 |1 is obsolete| | --- Comment #4 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 26874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26874&action=edit Rebased patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26874|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26875&action=edit [SIGNED OFF] Bug 12040 - Add 3 parameters for SMTP authentication -username -> Username to pass to the SMTP server for authentication -password -> Password to pass to the SMTP server for authentication -method -> Method is the type of authentication. Ie. LOGIN, DIGEST-MD5, etc. Test Plan --------- As for testing manually using a Gmail account: 1. Set up your sendmail as shown in misc/cronjobs/CONFIGURE.gmail 2. Before applying this patch, run misc/cronjobs/runreports.pl on your favorite report including the proper email parameters against your gmail account. 3. Note the failure message stating the authentication requirement. 4. Apply this patch, and return the script including the additional parameters and specifying "LOGIN" for the method. 5. Note the successful send. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Note: My Mail/Sendmail.pm was in /usr/share/perl5/Mail/Sendmail.pm I tested the case with the patch applied, with and without expected parameters. The parameters don't exist before, so I don't see how to pass values for them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 --- Comment #6 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to M. Tompsett from comment #5)
expected parameters. The parameters don't exist before, so I don't see how to pass values for them.
Sorry. Running 'perldoc runreport.pl' should show them up along with all other available params. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26875|0 |1 is obsolete| | --- Comment #7 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 26876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26876&action=edit Fixup documentation of new params -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26876|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26877&action=edit [SIGNED OFF] Bug 12040 - Add 3 parameters for SMTP authentication -username -> Username to pass to the SMTP server for authentication -password -> Password to pass to the SMTP server for authentication -method -> Method is the type of authentication. Ie. LOGIN, DIGEST-MD5, etc. Test Plan --------- As for testing manually using a Gmail account: 1. Set up your sendmail as shown in misc/cronjobs/CONFIGURE.gmail 2. Before applying this patch, run misc/cronjobs/runreports.pl on your favorite report including the proper email parameters against your gmail account. 3. Note the failure message stating the authentication requirement. 4. Apply this patch, and return the script including the additional parameters and specifying "LOGIN" for the method. 5. Note the successful send. 6. perldoc misc/cronjobs/runreport.pl 7. Run the koha qa test tool. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Note: My Mail/Sendmail.pm was in /usr/share/perl5/Mail/Sendmail.pm I tested the case with the patch applied, with and without expected parameters. The parameters don't exist before, so I don't see how to pass values for them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26877|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27016&action=edit Bug 12040 - Add 3 parameters for SMTP authentication -username -> Username to pass to the SMTP server for authentication -password -> Password to pass to the SMTP server for authentication -method -> Method is the type of authentication. Ie. LOGIN, DIGEST-MD5, etc. Test Plan --------- As for testing manually using a Gmail account: 1. Set up your sendmail as shown in misc/cronjobs/CONFIGURE.gmail 2. Before applying this patch, run misc/cronjobs/runreports.pl on your favorite report including the proper email parameters against your gmail account. 3. Note the failure message stating the authentication requirement. 4. Apply this patch, and return the script including the additional parameters and specifying "LOGIN" for the method. 5. Note the successful send. 6. perldoc misc/cronjobs/runreport.pl 7. Run the koha qa test tool. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Note: My Mail/Sendmail.pm was in /usr/share/perl5/Mail/Sendmail.pm I tested the case with the patch applied, with and without expected parameters. The parameters don't exist before, so I don't see how to pass values for them. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Chris! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org