[Bug 7033] New: Make all strings translatable in marc21_field_007.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7033 Bug #: 7033 Summary: Make all strings translatable in marc21_field_007.tt Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: fcapovilla@live.ca QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com Created attachment 5894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5894 Make all strings translatable in marc21_field_007.tt This patch adds _("") around javascript strings that couldn't be translated by the translate.pl script. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7033 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored AssignedTo|gmcharlt@gmail.com |fcapovilla@live.ca --- Comment #1 from Frédérick Capovilla <fcapovilla@live.ca> 2011-10-14 20:26:57 UTC --- Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7033 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-18 05:39:16 UTC --- I have tested this on current master using following steps: - apply patch - perl translate update de-DE - check for new strings, like "b- Braille" I was not able to find the new strings in the updated po file. Not sure what the problem is, as the patch looks logical to me. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7033 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5894|0 |1 is obsolete| | --- Comment #3 from Frédérick Capovilla <fcapovilla@live.ca> 2011-10-18 14:59:26 UTC --- Created attachment 5955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5955 Make all strings translatable in marc21_field_007.tt (corrected) It seems the translate script doesn't like when quotes are mixed in multiline javascript strings. Adding line-breaks so the translation is on its own line seems to fix the problem. Corrected patch attached. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7033 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Cataloging |I18N/L10N Patch Status|Failed QA |Needs Signoff AssignedTo|fcapovilla@live.ca |frederic@tamil.fr -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7033 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5955|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-19 19:44:28 UTC --- Created attachment 5994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5994 [SIGNED-OFF] Make all strings translatable in marc21_field_007.tt http://bugs.koha-community.org/show_bug.cgi?id=7033 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test plan: - apply patch - update po files using 'perl translate update <language-code> - check po files for new strings from 007 plugin - translate some / all of them - update templates with changed po files 'perl translate install <language-code> - verify 007 still works and got translated -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7033 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7033 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |Rel_3_8 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:40:12 UTC --- Updating version : This ENH could be in Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7033 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |master --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:05:52 UTC --- Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7033 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA AssignedTo|frederic@tamil.fr |fcapovilla@live.ca QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-14 13:10:31 UTC --- Lot of work. Did you run code over the code? ;) If so, I could QA that for you.. QA Comment: This large patch only extensively covers the marc21 007 template. Looks good to me. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7033 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed Severity|enhancement |minor --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-17 16:11:09 UTC --- Patch pushed, please test. I also think it's a bug, not an ENH, so I set the severity accordingly and add to rel_3_6 to have chris_n applying the patch if needed Note I haven't signed this patch, as I can't test it properly (my test DB is unimarc) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7033 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.ed | |u --- Comment #9 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-11-17 22:47:55 UTC --- In the future, please include "Bug XXXX" in the first line of the commit message. Thanks, Chris 3.4.x/3.6.x Release Maintainer -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7033 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This was included in the 3.6 branch prior to 3.6.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org