[Bug 42083] New: Email and SMS messages from patron record should have distinct permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 Bug ID: 42083 Summary: Email and SMS messages from patron record should have distinct permissions Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Depends on: 40933, 29393 Bug 29393 added the ability to send email from a patron's record. 40933 expanded that to SMS. But they currently share a single permission. It would be preferable for those to be two distinct permissions. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 [Bug 29393] Ability to send emails from patron details page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 [Bug 40933] Add SMS support under Add message feature -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 195239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195239&action=edit Bug 42083: Create distinct permissions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 195240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195240&action=edit Bug 42083: atomicupdate for permissions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 195241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195241&action=edit Bug 42083: Implement distinct permissions To test: 1 - have an staff account with 'send_messages_to_borrowers' permission but not top level 'borrowers' permission 2 - have a value in SMSSendDriver system preference 3 - log in under your staff account and confirm you can send both email and SMS messages from the Add Message button on a patron record 4 - apply patch, updatedatabase, restart_all 5 - confirm your staff account now has 'send_messages_to_borrowers_email' permission rather than 'send_messages_to_borrowers' 6 - confirm your staff account can now only send email messages from the Add Message button on a patron record 7 - add 'send_messages_to_borrowers_sms' permission to your staff account 8 - confirm your staff account can now send both email and sms messages from the Add Message button on a patron record 9 - remove 'send_messages_to_borrowers_email' from your staff account 10 - confirm your staff account can now only send sms messages from the Add Message button on a patron record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 195242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195242&action=edit Bug 42083: add exec to atomicupdate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195239|0 |1 is obsolete| | Attachment #195240|0 |1 is obsolete| | Attachment #195241|0 |1 is obsolete| | Attachment #195242|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 195329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195329&action=edit Bug 42083: Create distinct permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 195330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195330&action=edit Bug 42083: atomicupdate for permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 195331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195331&action=edit Bug 42083: Implement distinct permissions To test: 1 - have an staff account with 'send_messages_to_borrowers' permission but not top level 'borrowers' permission 2 - have a value in SMSSendDriver system preference 3 - log in under your staff account and confirm you can send both email and SMS messages from the Add Message button on a patron record 4 - apply patch, updatedatabase, restart_all 5 - confirm your staff account now has 'send_messages_to_borrowers_email' permission rather than 'send_messages_to_borrowers' 6 - confirm your staff account can now only send email messages from the Add Message button on a patron record 7 - add 'send_messages_to_borrowers_sms' permission to your staff account 8 - confirm your staff account can now send both email and sms messages from the Add Message button on a patron record 9 - remove 'send_messages_to_borrowers_email' from your staff account 10 - confirm your staff account can now only send sms messages from the Add Message button on a patron record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39781 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39781 [Bug 39781] Cannot limit by library when creating custom patron email sent via patron details page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch removes the release notes| |'send_messages_to_borrowers | |' permission and replaces | |it with | |'send_messages_to_borrowers | |_email' and | |'send_messages_to_borrowers | |_sms,' allowing users to be | |limited to sending either | |email or SMS messages from | |a patron record. At update, | |users who previously had | |'send_messages_to_borrowers | |' permission will be given | |only | |'send_messages_to_borrowers | |_email,' as SMS messages | |are a new functionality on | |26.05 and not something to | |which users previously had | |access. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195329|0 |1 is obsolete| | --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 195507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195507&action=edit Bug 42083: Create distinct permissions Signed-off-by: Juliet Heltibridle <jheltibridle@rcplib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195330|0 |1 is obsolete| | --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 195508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195508&action=edit Bug 42083: atomicupdate for permissions Signed-off-by: Juliet Heltibridle <jheltibridle@rcplib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195331|0 |1 is obsolete| | --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 195509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195509&action=edit Bug 42083: Implement distinct permissions To test: 1 - have an staff account with 'send_messages_to_borrowers' permission but not top level 'borrowers' permission 2 - have a value in SMSSendDriver system preference 3 - log in under your staff account and confirm you can send both email and SMS messages from the Add Message button on a patron record 4 - apply patch, updatedatabase, restart_all 5 - confirm your staff account now has 'send_messages_to_borrowers_email' permission rather than 'send_messages_to_borrowers' 6 - confirm your staff account can now only send email messages from the Add Message button on a patron record 7 - add 'send_messages_to_borrowers_sms' permission to your staff account 8 - confirm your staff account can now send both email and sms messages from the Add Message button on a patron record 9 - remove 'send_messages_to_borrowers_email' from your staff account 10 - confirm your staff account can now only send sms messages from the Add Message button on a patron record Signed-off-by: Juliet Heltibridle <jheltibridle@rcplib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk Status|Signed Off |Passed QA Sponsorship status|--- |Unsponsored Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195507|0 |1 is obsolete| | Attachment #195508|0 |1 is obsolete| | Attachment #195509|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195875&action=edit Bug 42083: Create distinct permissions Signed-off-by: Juliet Heltibridle <jheltibridle@rcplib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195876&action=edit Bug 42083: atomicupdate for permissions Signed-off-by: Juliet Heltibridle <jheltibridle@rcplib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195877&action=edit Bug 42083: Implement distinct permissions To test: 1 - have an staff account with 'send_messages_to_borrowers' permission but not top level 'borrowers' permission 2 - have a value in SMSSendDriver system preference 3 - log in under your staff account and confirm you can send both email and SMS messages from the Add Message button on a patron record 4 - apply patch, updatedatabase, restart_all 5 - confirm your staff account now has 'send_messages_to_borrowers_email' permission rather than 'send_messages_to_borrowers' 6 - confirm your staff account can now only send email messages from the Add Message button on a patron record 7 - add 'send_messages_to_borrowers_sms' permission to your staff account 8 - confirm your staff account can now send both email and sms messages from the Add Message button on a patron record 9 - remove 'send_messages_to_borrowers_email' from your staff account 10 - confirm your staff account can now only send sms messages from the Add Message button on a patron record Signed-off-by: Juliet Heltibridle <jheltibridle@rcplib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195878&action=edit Bug 42083: (QA follow-up) Simplify atomicupdate migration loop Replace the O(n²) accumulate-and-re-insert pattern with a simple per-row execute inside the while loop. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 --- Comment #16 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #17 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This patch doesn’t apply cleanly to 25.05, so I’m not planning to backport it at this time. If you’re able to update it for 25.05 compatibility, I’d be happy to take another look. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org