[Bug 37070] New: Incorrect barcode generation when adding orders to basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 Bug ID: 37070 Summary: Incorrect barcode generation when adding orders to basket Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: hammat.wele@inlibro.com QA Contact: testopia@bugs.koha-community.org When the autoBarcode preference is set to « generated in the form 1, 2, 3 » and the maximum barcode is length 16 (ex 1000000000000000), when adding orders to the basket,the numbers of the copies generated are in the hexadecimal form. to reproduce: 1- Set the system preference autoBarcode to « generated in the form 1, 2, 3 » 2- Search for a biblio record 3- In the record details, click on New -> New item 4- fill the Barcode field to a number with length 16 (1000000000000000) and add the item 5- Create a suggestion 5-1- Go to Acquisitions and click on suggestions 5-2- Create a suggestion and accept it 6- Add a new order to a basket 6-1- Go to Acquisitions and find a vendor 6-2- Create a new Basket 6-3- on the Basket click on 'Add to basket' and select 'From a suggestion' 6-4- Add the order created on 5-2- to the basket 6-5- On the item form click on Add item 6-6- Select a Fund and save the order 7- In the orders table click on the record and check the item Barcode ---> the Barcode is in hexadecimal form 8- Cancel order and delete the catalog record 9- Apply the patch 10- Repeat step 6-4, 6-5, 6-6 11- Check the item Barcode ---> the Barcode is not in hexadecimal form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |hammat.wele@inlibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 --- Comment #1 from Hammat wele <hammat.wele@inlibro.com> --- When the autoBarcode preference is set to « generated in the form 1, 2, 3 » and the maximum barcode is length 16 (ex 1000000000000000), when adding orders to the basket,the numbers of the copies generated are in the hexadecimal form. to reproduce: 1- Set the system preference autoBarcode to « generated in the form 1, 2, 3 » 2- Search for a biblio record 3- In the record details, click on New -> New item 4- fill the Barcode field to a number with length 16 (1000000000000000) and add the item 5- Create a suggestion 5-1- Go to Acquisitions and click on suggestions 5-2- Create a suggestion and accept it 6- Add a new order to a basket 6-1- Go to Acquisitions and find a vendor 6-2- Create a new Basket 6-3- on the Basket click on 'Add to basket' and select 'From a suggestion' 6-4- Add the order created on 5-2- to the basket 6-5- On the item form click on Add item 6-6- Select a Fund and save the order 7- In the orders table click on the record and check the item Barcode ---> the Barcode is in hexadecimal form 8- Cancel order and delete the catalog record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 --- Comment #2 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 167634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167634&action=edit Bug 37070: Incorrect barcode generation when adding orders to basket When the autoBarcode preference is set to « generated in the form 1, 2, 3 » and the maximum barcode is length 16 (ex 1000000000000000), when adding orders to the basket,the numbers generated are in the hexadecimal form. to reproduce: 1- Set the system preference autoBarcode to « generated in the form 1, 2, 3 » 2- Search for a biblio record 3- In the record details, click on New -> New item 4- fill the Barcode field to a number with length 16 (1000000000000000) and add the item 5- Create a suggestion 5-1- Go to Acquisitions and click on suggestions 5-2- Create a suggestion and accept it 6- Add a new order to a basket 6-1- Go to Acquisitions and find a vendor 6-2- Create a new Basket 6-3- on the Basket click on 'Add to basket' and select 'From a suggestion' 6-4- Add the order created on 5-2- to the basket 6-5- On the item form click on Add item 6-6- Select a Fund and save the order 7- In the orders table click on the record and check the item Barcode ---> the Barcode is in hexadecimal form 8- Cancel order and delete the catalog record 9- Apply the patch 10- Repeat step 6-4, 6-5, 6-6 11- Check the item Barcode ---> the Barcode is not in hexadecimal form 12- run prove t/db_dependent/Barcodes.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167634|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 167776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167776&action=edit Bug 37070: Incorrect barcode generation when adding orders to basket When the autoBarcode preference is set to « generated in the form 1, 2, 3 » and the maximum barcode is length 16 (ex 1000000000000000), when adding orders to the basket,the numbers generated are in the hexadecimal form. to reproduce: 1- Set the system preference autoBarcode to « generated in the form 1, 2, 3 » 2- Search for a biblio record 3- In the record details, click on New -> New item 4- fill the Barcode field to a number with length 16 (1000000000000000) and add the item 5- Create a suggestion 5-1- Go to Acquisitions and click on suggestions 5-2- Create a suggestion and accept it 6- Add a new order to a basket 6-1- Go to Acquisitions and find a vendor 6-2- Create a new Basket 6-3- on the Basket click on 'Add to basket' and select 'From a suggestion' 6-4- Add the order created on 5-2- to the basket 6-5- On the item form click on Add item 6-6- Select a Fund and save the order 7- In the orders table click on the record and check the item Barcode ---> the Barcode is in hexadecimal form 8- Cancel order and delete the catalog record 9- Apply the patch 10- Repeat step 6-4, 6-5, 6-6 11- Check the item Barcode ---> the Barcode is not in hexadecimal form 12- run prove t/db_dependent/Barcodes.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 --- Comment #4 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 172423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172423&action=edit Bug 37070: Incorrect barcode generation when adding orders to basket When the autoBarcode preference is set to « generated in the form 1, 2, 3 » and the maximum barcode is length 16 (ex 1000000000000000), when adding orders to the basket,the numbers generated are in the hexadecimal form. to reproduce: 1- Set the system preference autoBarcode to « generated in the form 1, 2, 3 » 2- Search for a biblio record 3- In the record details, click on New -> New item 4- fill the Barcode field to a number with length 16 (1000000000000000) and add the item 5- Create a suggestion 5-1- Go to Acquisitions and click on suggestions 5-2- Create a suggestion and accept it 6- Add a new order to a basket 6-1- Go to Acquisitions and find a vendor 6-2- Create a new Basket 6-3- on the Basket click on 'Add to basket' and select 'From a suggestion' 6-4- Add the order created on 5-2- to the basket 6-5- On the item form click on Add item 6-6- Select a Fund and save the order 7- In the orders table click on the record and check the item Barcode ---> the Barcode is in hexadecimal form 8- Cancel order and delete the catalog record 9- Apply the patch 10- Repeat step 6-4, 6-5, 6-6 11- Check the item Barcode ---> the Barcode is not in hexadecimal form 12- run prove t/db_dependent/Barcodes.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> bsoletes: 167776 - Bug 37070: Incorrect barcode generation when adding orders to basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 --- Comment #5 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 172424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172424&action=edit Bug 37070: (QA follow-up) Fix qa script issues Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167776|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Always love some unit tests :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder if this would not also affect the other spots a barcode is calculated? So we could change this to cataloguing and remove the "to basket". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldstable |Needs documenting --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not backport to 23.11.x in case of side-effects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37070 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org