[Bug 25492] New: Your Account Menu button does nothing on mobile devices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 Bug ID: 25492 Summary: Your Account Menu button does nothing on mobile devices Change sponsored?: --- Product: Koha Version: 19.11 Hardware: Other OS: Other Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jyorio@equinoxinitiative.org QA Contact: testopia@bugs.koha-community.org Replicated with Koha 19.11.04 and 19.11.05 Steps to reproduce: 1) Bring up the OPAC on a mobile device with a smaller screen (e.g. cell phone) or using an emulator 2) Log into an account 3) Find the button labeled "Your account menu" 4) Click it. 5) Nothing happens. ****** I didn't see any errors in the browser console or in the Koha logs. I tested this with 18.11.05 and clicking the button expands the menu as you'd expect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18084 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Bisecting: 0 revisions left to test after this (roughly 0 steps) [fed5158d66abafbe482a3625fa010c160c82a529] Bug 18084: Language selector hidden in user menu on mobile interfaces Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084 [Bug 18084] Language selector is hidden in user menu on mobile interfaces -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 105302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105302&action=edit Bug 25492: Your Account Menu button does nothing on mobile devices This patch removes some redundant code from the OPAC JavaScript which was causing problems with the show/hide action on two controls which are shown only at narrower browser widths: The "Your account" menu shown when the user is on a user-related page, and the "Refine your search" menu shown on the search results page. To test, apply the patch and go to the OPAC. Narrow your browser width to below 768 pixels. - Perform a search. - On the search results page you should see a "Refine your search" link at the top of the results. Clicking it should expand and collapse the facets menu. - Log in to the OPAC. - On the "Your summary" page there should be a "Your account menu" link at the top of the main part of the page. Clicking it should expand and collapse the account menu. - Verify that these menus display correctly when you widen and narrow the browser window. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|Other |All Severity|minor |major OS|Other |All -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105302|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 105358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105358&action=edit Bug 25492: Your Account Menu button does nothing on mobile devices This patch removes some redundant code from the OPAC JavaScript which was causing problems with the show/hide action on two controls which are shown only at narrower browser widths: The "Your account" menu shown when the user is on a user-related page, and the "Refine your search" menu shown on the search results page. To test, apply the patch and go to the OPAC. Narrow your browser width to below 768 pixels. - Perform a search. - On the search results page you should see a "Refine your search" link at the top of the results. Clicking it should expand and collapse the facets menu. - Log in to the OPAC. - On the "Your summary" page there should be a "Your account menu" link at the top of the main part of the page. Clicking it should expand and collapse the account menu. - Verify that these menus display correctly when you widen and narrow the browser window. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105358|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105427&action=edit Bug 25492: Your Account Menu button does nothing on mobile devices This patch removes some redundant code from the OPAC JavaScript which was causing problems with the show/hide action on two controls which are shown only at narrower browser widths: The "Your account" menu shown when the user is on a user-related page, and the "Refine your search" menu shown on the search results page. To test, apply the patch and go to the OPAC. Narrow your browser width to below 768 pixels. - Perform a search. - On the search results page you should see a "Refine your search" link at the top of the results. Clicking it should expand and collapse the facets menu. - Log in to the OPAC. - On the "Your summary" page there should be a "Your account menu" link at the top of the main part of the page. Clicking it should expand and collapse the account menu. - Verify that these menus display correctly when you widen and narrow the browser window. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.01 |20.11.00, 20.05.01, released in| |19.11.07 Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.01, |20.11.00, 20.05.01, released in|19.11.07 |19.11.07, 19.05.12 Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 25830 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 25831 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org