[Bug 18577] New: Importing a batch using a framework not fully set up causes and endless loop
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 Bug ID: 18577 Summary: Importing a batch using a framework not fully set up causes and endless loop Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt@gmail.com Reporter: bob-ewart@bobsown.com QA Contact: testopia@bugs.koha-community.org Importing a batch using a framework code that is defined but not set up causes the import to go into an endless loop. Create a new framework code but don't set what it is based on. Then import a batch using that framework. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 Bob Ewart <bob-ewart@bobsown.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart@bobsown.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Version|16.11 |unspecified -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 64597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64597&action=edit Bug 18577 - Importing a batch using a framework not fully set up causes and endless loop To test: 1 - Create a new framework - don't set it up 2 - Stage some records for import 3 - Manage the import, note your new framwork is in the list 4 - Apply patch 5 - Reload the page 6 - Note the framework is no longer an option -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |nick@bywatersolutions.com CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64597|0 |1 is obsolete| | --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 64615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64615&action=edit Bug 18577 - Importing a batch using a framework not fully set up causes and endless loop To test: 1 - Create a new framework - don't set it up 2 - Stage some records for import 3 - Manage the import, note your new framwork is in the list 4 - Apply patch 5 - Reload the page 6 - Note the framework is no longer an option Followed test plan, worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- QA: I think you should add a foreign key constraint on marc_subfield_structure.frameworkcode, so that the DBIx schema can be generated by update_dbix_class_files.pl. Is there any reason why you didn't do that ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Julian Maurice from comment #3)
QA:
I think you should add a foreign key constraint on marc_subfield_structure.frameworkcode, so that the DBIx schema can be generated by update_dbix_class_files.pl. Is there any reason why you didn't do that ?
Because the 'default' framework breaks the constraint - it doesn't exist in biblio_frameworks, it is just relied upon to be there, adding it is a larger change than I wanted to make here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Nick Clemens from comment #4)
Because the 'default' framework breaks the constraint - it doesn't exist in biblio_frameworks, it is just relied upon to be there, adding it is a larger change than I wanted to make here Ah that's true, I had forgotten that. Passing QA then
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64615|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 64908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64908&action=edit Bug 18577 - Importing a batch using a framework not fully set up causes and endless loop To test: 1 - Create a new framework - don't set it up 2 - Stage some records for import 3 - Manage the import, note your new framwork is in the list 4 - Apply patch 5 - Reload the page 6 - Note the framework is no longer an option Followed test plan, worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why do not we have this constraint at DB level? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #7)
Why do not we have this constraint at DB level?
... Read the other comments! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64985&action=edit Bug 18577: Add FIXME about the missing FK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.10. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org