[Bug 19077] New: When loading patrons matching on userid updates to matched patrons are rejected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19077 Bug ID: 19077 Summary: When loading patrons matching on userid updates to matched patrons are rejected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campbell@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com A while back the import_borrowers script was altered to allow matching by userid, to allow updating borrowers by the id, unfortunately in parallel was a change to ensure duplicate userids were not added. Both changes were applied but the latter had the side effect of rendering the first useless. This patch adds a test that we are not matching on userid to the check userid for uniqueness To test Without the patch a import record matching on userid will be rejected With the patch it will update the db record when matching on another key non-unique userids will still be rejected a version of the patch has been submitted for inclusion in the enhanced version of patron load in bug 12598 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19077 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 65828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65828&action=edit Add test to not reject update if matching on userid test by confirming that if matching by userid a matched record is updated, howver if matching by another criteria a record with a duplicate userid should still be rejected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Colin, with and without the patch I receive an internal server error when I try to match on username/uderid: Use of uninitialized value $uploadborrowers in concatenation (.) or string at /home/vagrant/kohaclone/tools/import_borrowers.pl line 113. Use of uninitialized value $uploadborrowers in concatenation (.) or string at /home/vagrant/kohaclone/tools/import_borrowers.pl line 113. Can't call method "unblessed" on unblessed reference at /home/vagrant/kohaclone/tools/import_borrowers.pl line 255, <$fh> line 2. Can you help? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19077 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #2)
Hi Colin, with and without the patch I receive an internal server error when I try to match on username/uderid:
Use of uninitialized value $uploadborrowers in concatenation (.) or string at /home/vagrant/kohaclone/tools/import_borrowers.pl line 113. Use of uninitialized value $uploadborrowers in concatenation (.) or string at /home/vagrant/kohaclone/tools/import_borrowers.pl line 113. Can't call method "unblessed" on unblessed reference at /home/vagrant/kohaclone/tools/import_borrowers.pl line 255, <$fh> line 2.
Can you help?
Should be fixed by commit 6f595e4c95c22ba444f49c61c9d101483309871f Bug 17829: (follow-up) Fix import patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Colin, after Jonathan's fix the update using userid for matching works for me without the patch. Can you verify? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19077 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Closing, reopen if it is still needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org