[Bug 38894] New: Longoverdue cron should follow HomeOrHoldingBranch as well as CircControl when using --library flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 Bug ID: 38894 Summary: Longoverdue cron should follow HomeOrHoldingBranch as well as CircControl when using --library flag Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Depends on: 9596 Marking this Critical as it will lead to circ rules getting applied in unexpected ways. Bug 9596 taught the longoverdue cron to limit by library, following the CircControl system preference. Elsewhere in circulation (due dates, fines, etc), when CircControl is set to "the item's library," then it is further modified by HomeOrHoldingBranch, which determines whether we mean "the item's home" or "the item's holding." Currently, if CircControl is set to "the item's library," it is *always* interpretted as the item's homebranch. This will not work for many libraries. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 [Bug 9596] Allow longoverdue.pl to be configured per library on the command line -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 176534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176534&action=edit Bug 38894: Use HomeOrHoldingBranch with longoverdue cronjob To test: 1: have 4 items, 2 with homebranch = Library A and 2 with homebranch = Library B 2: Logged into Library A, check out 1 Library A item and 1 Library B item, both with due dates in the past enough for the longoverdue cron 3: set yourself to Library B, check out 1 Library A item and 1 Library B item, both with due dates in the past enough for the longoverdue cron 4: Run longoverdue cron with --verbose, without --confirm, and without --Library. see that it would act on all 4 items 5: Set CircControl to "the library the item is from" 6: Set HomeOrHoldingBranch to "the item's home library" 7: Run longoverdue cron with --verbose and --library="A" (where A is the code for your Library A), wihout --confirm 8: See the cron wants to act on the items with homebranch = A 9: Set HomeOrHoldingBranch to "the item's holding library" 10: Run longoverdue cron with --verbose and --library="A" (where A is the code for your Library A), wihout --confirm 11: See the cron is still trying to act on the two items with homebranch = A 12: Apply patch, restart all 13: Run longoverdue cron with --verbose and --library="A" (where A is the code for your Library A), wihout --confirm 14: See the cron is now trying to act on the two items with holdingbranch = A 15: Set HomeOrHoldingBranch to "the item's home library" 16: Run longoverdue cron with --verbose and --library="A" (where A is the code for your Library A), wihout --confirm 17: See the cron wants to act on the items with homebranch = A -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38893 [Bug 38893] Longoverdue cronjob gives error when run with "--library" flag and CircControl syspref set to "The library you are logged in at" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176534|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176888&action=edit Bug 38894: Use HomeOrHoldingBranch with longoverdue cronjob To test: 1: Add 4 items, 2 with homebranch = Library A and 2 with homebranch = Library B 2: Logged into Library A, check out 1 Library A item and 1 Library B item, both with due dates in the past enough for the longoverdue cron 3: Set yourself to Library B, check out 1 Library A item and 1 Library B item, both with due dates in the past enough for the longoverdue cron 4: Run longoverdue cron with --verbose, without --confirm, and without --Library. see that it would act on all 4 items 5: Set CircControl to "the library the item is from" 6: Set HomeOrHoldingBranch to "the item's home library" 7: Run longoverdue cron with --verbose and --library="A" (where A is the code for your Library A), wihout --confirm 8: See the cron wants to act on the items with homebranch = A 9: Set HomeOrHoldingBranch to "the item's holding library" 10: Run longoverdue cron with --verbose and --library="A" (where A is the code for your Library A), wihout --confirm 11: See the cron is still trying to act on the two items with homebranch = A 12: Apply patch, restart all 13: Run longoverdue cron with --verbose and --library="A" (where A is the code for your Library A), wihout --confirm 14: See the cron is now trying to act on the two items with holdingbranch = A 15: Set HomeOrHoldingBranch to "the item's home library" 16: Run longoverdue cron with --verbose and --library="A" (where A is the code for your Library A), wihout --confirm 17: See the cron wants to act on the items with homebranch = A Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Quick QA of this one, all working well and scripts are happy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- A summary of this change might be helpful! Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |When the longoverdue cron release notes| |is limited by library, it | |follows the CircControl | |system preference. When | |CircControl is set to "the | |item's library," this patch | |allows the | |HomeOrHoldingBranch system | |preference to further | |specify either the item's | |homebranch or the item's | |holdingbranch. This makes | |the longoverdue cron | |consistent with the | |application or circulation | |and fine rules. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38894 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org