[Bug 27031] New: Update header.inc to use Koha plugin for intranetbookbag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 Bug ID: 27031 Summary: Update header.inc to use Koha plugin for intranetbookbag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org header.inc is still using the [% intranetbookbag %] instead of using Koha.Preference('intranetbookbag'). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update header.inc to use |Update header.inc to use |Koha plugin for |Koha plugin for system |intranetbookbag |preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26791 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update header.inc to use |Koha.Preference() could be |Koha plugin for system |used more often in |preferences |header.inc and | |js_includes.inc Severity|enhancement |minor Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 114694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114694&action=edit Bug 27031: Use Koha.Preference() more often in header.inc and js_includes.inc This patch uses the Koha.Preference() macro more often in key includes. (In the longer term, it will help reduce dependency in problematic C4::Auth code.) Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/mainpage.pl 2. Note "Cart" link in nav bar 3. Click "Cart" and note "Your cart is currently empty" text 4. Click "More" and note "Course Reserves" in dropdown menu 5. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 6. Click "Select all" above search results 7. Click "Add to cart" 8. Note "Cart" now has 3 displaying next to it 9. Click "Cart" 10. Note there are three titles in the cart 11. Click "Empty and close" and click "OK" to confirm 12. Note "Cart (0)" now appears in the top nav 13. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=IntranetNav 14. Save the following content in the system preference: <li><a href="/index.html">New Home</a></li> 15. Refresh the page 16. Note "New Home" appears in the top nav between "Cart" and "More" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha.Preference() could be |Koha.Preference() should be |used more often in |used more often in |header.inc and |header.inc and |js_includes.inc |js_includes.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26791 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 [Bug 26791] Build Mojolicious controller replacement for export.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114694|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 114753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114753&action=edit Bug 27031: Use Koha.Preference() more often in header.inc and js_includes.inc This patch uses the Koha.Preference() macro more often in key includes. (In the longer term, it will help reduce dependency in problematic C4::Auth code.) Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/mainpage.pl 2. Note "Cart" link in nav bar 3. Click "Cart" and note "Your cart is currently empty" text 4. Click "More" and note "Course Reserves" in dropdown menu 5. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 6. Click "Select all" above search results 7. Click "Add to cart" 8. Note "Cart" now has 3 displaying next to it 9. Click "Cart" 10. Note there are three titles in the cart 11. Click "Empty and close" and click "OK" to confirm 12. Note "Cart (0)" now appears in the top nav 13. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=IntranetNav 14. Save the following content in the system preference: <li><a href="/index.html">New Home</a></li> 15. Refresh the page 16. Note "New Home" appears in the top nav between "Cart" and "More" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27324 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 [Bug 27324] Use Koha.Preference() for intranetbookbag everywhere -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The patch itself is ok, but I wonder if we should remove all remaining instances of the variable and also the code from Auth.pm. I have filed bug 27324 for a possible follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114753|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 114766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114766&action=edit Bug 27031: Use Koha.Preference() more often in header.inc and js_includes.inc This patch uses the Koha.Preference() macro more often in key includes. (In the longer term, it will help reduce dependency in problematic C4::Auth code.) Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/mainpage.pl 2. Note "Cart" link in nav bar 3. Click "Cart" and note "Your cart is currently empty" text 4. Click "More" and note "Course Reserves" in dropdown menu 5. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 6. Click "Select all" above search results 7. Click "Add to cart" 8. Note "Cart" now has 3 displaying next to it 9. Click "Cart" 10. Note there are three titles in the cart 11. Click "Empty and close" and click "OK" to confirm 12. Note "Cart (0)" now appears in the top nav 13. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=IntranetNav 14. Save the following content in the system preference: <li><a href="/index.html">New Home</a></li> 15. Refresh the page 16. Note "New Home" appears in the top nav between "Cart" and "More" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.02 released in| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Doesn't apply cleanly to 20.05, please rebase if needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org