[Bug 12568] New: Improve visibility of successful renewal via opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Bug ID: 12568 Summary: Improve visibility of successful renewal via opac Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Currently, when a patron renews an item via the opac, the only feedback the patron receives when a renewal is successful is an updated value for the due date of the item. This subtle indication of success may go unnoticed by some patrons. We should add a more prominent way to indicate an item was renewed successfully. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29674&action=edit Bug 12568 - Improve visibility of successful renewal via opac Currently, when a patron renews an item via the opac, the only feedback the patron receives when a renewal is successful is an updated value for the due date of the item. This subtle indication of success may go unnoticed by some patrons. We should add a more prominent way to indicate an item was renewed successfully. Test Plan: 1) Apply this patch 2) From the OPAC, renew some items 3) Note the "Renewed!" message in the "Renew" column of the checkouts table -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This doesn't work for me. After I submit some renewals and the page reloads I don't see any messages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Cathi Wiggins <cwiggins@ci.arcadia.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cwiggins@ci.arcadia.ca.us --- Comment #3 from Cathi Wiggins <cwiggins@ci.arcadia.ca.us> --- I don't think we need more messages to appear on the screen that then disappear or are ignored, the fact that the renewal was successful just needs to be more clear on the patron's summary tab in the OPAC or the patron's Check Out tab in the Staff Client with the text saying 'RENEWED' instead of 'NOT RENEWABLE'. Also if there must be text below that, then could it say just '1 renewal remaining' or '0 renewal remaining' instead of '1 of 1...' or '0 of 1...' which is confusing and not helpful. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29926&action=edit Demonstration Video Not sure what's going wrong for you. I just applied the patch to a fresh install and made this video. No changes to the patch were needed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Cathi Wiggins <cwiggins@ci.arcadia.ca.us> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29674|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 30008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30008&action=edit Bug 12568 - Improve visibility of successful renewal via opac Currently, when a patron renews an item via the opac, the only feedback the patron receives when a renewal is successful is an updated value for the due date of the item. This subtle indication of success may go unnoticed by some patrons. We should add a more prominent way to indicate an item was renewed successfully. Test Plan: 1) Apply this patch 2) From the OPAC, renew some items 3) Note the "Renewed!" message in the "Renew" column of the checkouts table Signed-off-by: Cathi Wiggins <cwiggins@ci.arcadia.ca.us> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but the new message is not showing up for me, I have double checked: Patch is applied, looking at bootstrap, looking at English templates... I don't see where this is going wrong. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Asked Bernardo to give it a try too - he can't see the new message either. Please take a look. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Problem seems to be related with '|' to concat/split itemnumbers, Changing that to '_' or ':' works perl -e ' use Data::Dumper; $a="10_20"; @b = split ("_", $a) ; print Dumper \@b;' $VAR1 = [ '10', '20' ]; perl -e ' use Data::Dumper; $a="10"; @b = split ("_", $a) ; print Dumper \@b;' $VAR1 = [ '10' ]; perl -e ' use Data::Dumper; $a="10|20"; @b = split ("|", $a) ; print Dumper \@b;' $VAR1 = [ '1', '0', '|', '2', '0' ]; -------------------> BAD ! perl -e ' use Data::Dumper; $a="10:20"; @b = split (":", $a) ; print Dumper \@b;' $VAR1 = [ '10', '20' ]; Now, when fixed the button/message is a bit large and ugly, that's another problem :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30085&action=edit Bug 12568 [QA Followup] - Use ':' as separator instead of '|' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #9)
Problem seems to be related with '|' to concat/split itemnumbers, Changing that to '_' or ':' works
Thanks for finding that out! Followup attached!
Now, when fixed the button/message is a bit large and ugly, that's another problem :)
Well, the idea *is* to make the renewal very prominent ; ) This is also the standard bootstrap style alert which we have been preferring in the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Kyle M Hall from comment #11)
Well, the idea *is* to make the renewal very prominent ; ) This is also the standard bootstrap style alert which we have been preferring in the bootstrap theme.
Yes, and it looks better on a screen as wide as that of your video :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30008|0 |1 is obsolete| | Attachment #30085|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30181&action=edit [PASSED QA] Bug 12568 - Improve visibility of successful renewal via opac Currently, when a patron renews an item via the opac, the only feedback the patron receives when a renewal is successful is an updated value for the due date of the item. This subtle indication of success may go unnoticed by some patrons. We should add a more prominent way to indicate an item was renewed successfully. Test Plan: 1) Apply this patch 2) From the OPAC, renew some items 3) Note the "Renewed!" message in the "Renew" column of the checkouts table Signed-off-by: Cathi Wiggins <cwiggins@ci.arcadia.ca.us> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script. Makes successful renewals more visible to the user in the OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30182&action=edit [PASSED QA] Bug 12568 [QA Followup] - Use ':' as separator instead of '|' Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed by Module Maintainer CC| |chris@bigballofwax.co.nz --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to MM_OPAC/bug_12568 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12677 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed by Module Maintainer |Pushed to Master CC| |tomascohen@gmail.com --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11703 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11703 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org