[Bug 12852] New: The "preview" param is never used in serials/claims.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 Bug ID: 12852 Summary: The "preview" param is never used in serials/claims.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org This was managed in bug 5342. For a better readability, I moved it in its own bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31278&action=edit Bug 12852: The "preview" param can be removed serials/claims.pl This case (preview=1) never appened. This patch remove all occurrences in the pl and the tt files. Test plan: Verify you don't manage to find a place where preview is set to 1 on the claim serials page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Depends on| |5342 Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31489&action=edit Bug 12852: Some unused stuffs more These parameters are never used. GetBookSeller takes a string (bookseller name) in parameter, not an id! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31831&action=edit Bug 12852: C4::Bookseller should not be imported anymore This script does not depend on C4::Bookseller anymore. The import can be removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12896 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12969 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi@cineca.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31278|0 |1 is obsolete| | --- Comment #4 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 31838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31838&action=edit Bug 12852: The "preview" param can be removed serials/claims.pl I've applied the patch against master 3.17.00.025 Firstly I've applied 5342. Everything is OK. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31489|0 |1 is obsolete| | --- Comment #5 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 31839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31839&action=edit Bug 12852: Some unused stuffs more -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31831|0 |1 is obsolete| | --- Comment #6 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 31840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31840&action=edit Bug 12852: C4::Bookseller should not be imported anymore -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31838|0 |1 is obsolete| | Attachment #31839|0 |1 is obsolete| | Attachment #31840|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32275&action=edit [PASSED QA] Bug 12852: The "preview" param can be removed serials/claims.pl This case (preview=1) never appened. This patch remove all occurrences in the pl and the tt files. Test plan: Verify you don't manage to find a place where preview is set to 1 on the claim serials page. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32276&action=edit [PASSED QA] Bug 12852: Some unused stuffs more These parameters are never used. GetBookSeller takes a string (bookseller name) in parameter, not an id! Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32277&action=edit [PASSED QA] Bug 12852: C4::Bookseller should not be imported anymore This script does not depend on C4::Bookseller anymore. The import can be removed. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.01 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org