[Bug 28946] New: 500 error when choosing patron for purchase suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 Bug ID: 28946 Summary: 500 error when choosing patron for purchase suggestion Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jstallings@tsas.org QA Contact: testopia@bugs.koha-community.org Running 21.05.02 on Debian stretch 9.13. When selecting "set to patron" or "select manager" when entering a purchase suggestion from the staff console, a 500 error rather than a search box appears in the popup. This issue seems related to bug 26738, where suggestion managers and patrons were unable to be saved, but I'm unable to get even that far. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- What error you have in the Koha log files? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I get this error in master: The method Koha::Patron::Categories->search_limited is not covered by tests! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 --- Comment #3 from jstallings@tsas.org --- As above, "The method Koha::Patron::Categories->search_limited is not covered by tests!" Full plack-error.log: https://pastebin.com/1hZnCGnD Nothing in intranet or other logs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Version|21.05 |unspecified Depends on| |23590, 23271 Severity|normal |major Keywords| |rel_21_05_candidate Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271 [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 [Bug 23590] Add the ability to change the manager of a suggestion and notify the new manager -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 124725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124725&action=edit Bug 28946: (bug 23271 follow-up) Missing occurrence in add_user_search.pl commit f6e0b04f48e8f0a02dbb8d48152646257d9accba Bug 23271: Replace search_limited with search_with_library_limits We were modifying the occurrences of: Koha::Patron::Categories->search_limited; with: Koha::Patron::Categories->search_with_library_limits; But between the patch submission and the push, another occurrence has been added by bug 23590. Test plan: Create a new suggestion from staff and click "select manager" Without the patch, notice the error: The method Koha::Patron::Categories->search_limited is not covered by tests! With the patch applied everything is working correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124725|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124751&action=edit Bug 28946: (bug 23271 follow-up) Missing occurrence in add_user_search.pl commit f6e0b04f48e8f0a02dbb8d48152646257d9accba Bug 23271: Replace search_limited with search_with_library_limits We were modifying the occurrences of: Koha::Patron::Categories->search_limited; with: Koha::Patron::Categories->search_with_library_limits; But between the patch submission and the push, another occurrence has been added by bug 23590. Test plan: Create a new suggestion from staff and click "select manager" Without the patch, notice the error: The method Koha::Patron::Categories->search_limited is not covered by tests! With the patch applied everything is working correctly Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 23271 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org