[Bug 6916] New: Selecting the acq date of an item should take you to the invoice page for it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 Bug #: 6916 Summary: Selecting the acq date of an item should take you to the invoice page for it Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: robin@catalyst.net.nz QAContact: koha-bugs@lists.koha-community.org Currently it takes you to the basket rather than the invoice, making it harder to see those details. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|henridamien@koha-fr.org |robin@catalyst.net.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> 2011-09-26 23:43:04 UTC --- Created attachment 5601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5601 Bug 6916 - item's acq date now takes you to its invoice When viewing an item's details, selecting the accession date for it now takes you to the invoice for that item. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5601|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-08 20:00:29 UTC --- Created attachment 5805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5805 [SIGNED-OFF] Bug 6916 - item's acq date now takes you to its invoice When viewing an item's details, selecting the accession date for it now takes you to the invoice for that item. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This works as advertised. 1) Order and receive an item in acquisition 2) Search for it in staff and go to the 'items' tab 3) Click on the 'receive date' link -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |Rel_3_8 --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:40:12 UTC --- Updating version : This ENH could be in Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |master --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:05:54 UTC --- Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5805|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-26 11:28:43 UTC --- Created attachment 6062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6062 Bug 6916 - item's acq date now takes you to its invoice When viewing an item's details, selecting the accession date for it now takes you to the invoice for that item. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This works as advertised. 1) Order and receive an item in acquisition 2) Search for it in staff and go to the 'items' tab 3) Click on the 'receive date' link Fixed conflict in moredetail.pl. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-26 11:29:47 UTC --- Retested patch and fixed a conflict. Waiting for QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-14 14:33:33 UTC --- What could I be doing wrong if I see the accession date but it it not linked at all? I already changed AcqCreateItem to receiving an order. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-14 14:48:17 UTC --- Hi Marcel, I am not sure how this can happen and how much influence AcqCreateItem has here. It should link correctly, whether you create the item on order or on receive. Perhaps Robin has an idea. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-16 13:13:31 UTC --- Found it! Actually, this patch hits an existing bug in moredetail.pl, depending on the value of pref AcqCreateItem. If this pref is set to placing an order, it works because there are records in aqorders_items. If it is set to receiving an order or cataloging the record, it does not work since there are no records in aqorders_items. Problem is in: my $order = GetOrderFromItemnumber( $item->{'itemnumber'} ); my $basket = GetBasket( $order->{'basketno'} ); $item->{'booksellerid'} = $basket->{'booksellerid'}; $item->{'ordernumber'} = $order->{'ordernumber'}; $item->{'basketno'} = $order->{'basketno'}; $item->{'booksellerinvoicenumber'} = $order->{'booksellerinvoicenumber'}; $item->{'datereceived'} = $order->{'datereceived'}; Depending on AcqCreateItem $order is filled or not. If not, $basket is empty too, the remaining lines are useless. Although this report was not opened to resolve this bug initially, I hope Robin can send a follow up to fix this issue too. Note that the order number could be found too via biblionumber. So, it could be fixed in GetOrderFromItemnumber. Hoping that and realizing that this patch did not introduce the bug, I am setting status to Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6062|0 |1 is obsolete| | --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-16 13:15:04 UTC --- Created attachment 6316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6316 Signed patch QA Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_8 Patch Status|Passed QA |Patch Pushed --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-17 16:06:19 UTC --- patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Patch Status|Patch Pushed |Needs Signoff Resolution|FIXED | AssignedTo|robin@catalyst.net.nz |m.de.rooy@rijksmuseum.nl QAContact|m.de.rooy@rijksmuseum.nl |ian.walls@bywatersolutions. | |com --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-24 10:55:19 UTC --- Robin, I was hoping that you would send the follow up, but you closed the bug now. So I am really hoping now that you will sign off my follow up ;) If the accession date is null or the pref is not placing an order, the situation is not solved yet. So therefore this follow up. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6316|0 |1 is obsolete| | --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-24 10:56:35 UTC --- Created attachment 6388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6388 Follow up patch Changed the SQL statement in GetOrderFromItemnumber so that it works also if syspref AcqCreateItem is not equal to placing an order. Returned hash now only includes fields from aqorders. This function is used in moredetail.pl and Items.pm (function MoveItemFromBiblio). Modified moredetail template so that label is shown always. Added nbsp to prevent mixup of columns when date is null. Test this by checking Items tab in normal view staff and by attaching an item in normal view staff (actually moving an item). Check moredetail again while changing syspref AcqCreateItem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 --- Comment #14 from Robin Sheat <robin@catalyst.net.nz> 2011-11-24 12:02:03 UTC --- Whoops, sorry. After KohaCon I made a list of things to catch up on, and I'd noted beside this "look at it." I then skim read it, saw it had been pushed, and thought my note was just to test and close. You are right though, the followup should go in. I'll have a look at it soon, unless someone beats me to the punch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6388|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-27 16:30:09 UTC --- Created attachment 6436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6436 [SIGND-OFF] Bug 6916: follow up Changed the SQL statement in GetOrderFromItemnumber so that it works also if syspref AcqCreateItem is not equal to placing an order. Returned hash now only includes fields from aqorders. This function is used in moredetail.pl and Items.pm (function MoveItemFromBiblio). Modified moredetail template so that label is shown always. Added nbsp to prevent mixup of columns when date is null. Test this by checking Items tab in normal view staff and by attaching an item in normal view staff (actually moving an item). Check moredetail again while changing syspref AcqCreateItem. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked that acquisition date is correctly linked for items created with AcqCreateItem set to 'on order' and 'on receive'. As items cataloged with 'in cataloguing' are not linked to acquisitions, there is no link for that settings. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA --- Comment #16 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-12 17:25:12 UTC --- I suspect there's something wrong with this follow-up: if you have a record with 2 items, bought from 2 different orders, this patch will make moredetail fail: tested case: * create basket A, add an order from empty biblio, recieve it in "PARCEL A" * create basket B, add an order from existing biblio, choose the previously added biblio, recieve it in "PARCEL B" * go to moredetail page => both items are linked to "PARCEL A", which is wrong (in my tests, AcqCreateItem is set to ordering) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 - low Patch Status|Failed QA |--- --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-14 13:53:14 UTC --- Paul, Good catch. This situation with two items from different baskets will not work now. Currently, the functionality only works for AcqCreateItem==ordering. In that case you have item numbers in aqorders_items. You do not have any items in that table if AcqCreateItem!=ordering. So, in that case there will never be a working URL. The followup resolves this in most cases (but not for your case). The problem is that when you create the item later, you actually cannot say where it came from. You could [pragmatically] say if it is the second item, take the second order (could be wrong). The routine GetOrderFromItemNumber should therefore use aqorder_items for pref==ordering and do another trick otherwise. Will leave this report open for fixing it later (no priority). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6436|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #18 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-22 12:38:31 UTC --- Closing this report for now. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7235 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-22 12:52:30 UTC --- Hi Marcel, there is a patch from Srdjan to add more information about the acquisition process to the moredetail page (bug 7235). I wrote a follow up adding checks on permissions and existence of data in a follow up that I hope will make things more consistent. I am adding the bug as see also, perhaps you want to take a look? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org