[Bug 20520] New: Re-indent moremember.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Bug ID: 20520 Summary: Re-indent moremember.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 20518 I would like to re-indent moremember.tt and remove trailing spaces. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Bug 20520 depends on bug 20518, which changed state. Bug 20518 Summary: Don't show "Messages" header and link on patron details if there are no messages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75432&action=edit Bug 20520: Re-indent moremember.tt This patch reindents the template for the patron detail page, moremember.tt: - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, view the patron detail page. There should be no visible difference before and after the applying the patch. HTML validation before and after the patch should return the same results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 [Bug 20779] Style refresh for patron detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Conflicts. Please fix, and I'll retest. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75432|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75488&action=edit Bug 20520: Re-indent moremember.tt This patch reindents the template for the patron detail page, moremember.tt: - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, view the patron detail page. There should be no visible difference before and after the applying the patch. HTML validation before and after the patch should return the same results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Was there any real benefit to changing HTML comments to Template Toolkit comments? Nasty /div mismatches in some cases, as far as I could read. Also, layering issues with things not nested properly. Indentation really cleaned this up nicely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75488|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 75500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75500&action=edit Bug 20520: Re-indent moremember.tt This patch reindents the template for the patron detail page, moremember.tt: - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, view the patron detail page. There should be no visible difference before and after the applying the patch. HTML validation before and after the patch should return the same results. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to M. Tompsett from comment #4)
Was there any real benefit to changing HTML comments to Template Toolkit comments?
The comments are for people editing the template, so there's not any reason to add to the file size of the generated HTML by outputting them there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75500|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 75745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75745&action=edit Bug 20520: Re-indent moremember.tt This patch reindents the template for the patron detail page, moremember.tt: - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, view the patron detail page. There should be no visible difference before and after the applying the patch. HTML validation before and after the patch should return the same results. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75745|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76484&action=edit Bug 20520: Re-indent moremember.tt This patch reindents the template for the patron detail page, moremember.tt: - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, view the patron detail page. There should be no visible difference before and after the applying the patch. HTML validation before and after the patch should return the same results. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02, cosmetic code tidy up only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement and does not apply easily on 17.11.x. Not pushed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org