[Bug 33657] New: Barcode list field in Inventory report doesn't honor BarcodeSeparators system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 Bug ID: 33657 Summary: Barcode list field in Inventory report doesn't honor BarcodeSeparators system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: michael.hafen@washk12.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Barcode list field in |Barcode list field in |Inventory report doesn't |Inventory report shouldn't |honor BarcodeSeparators |be split on space |system preference | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe BarcodeSeparators could be at play here (or should be), so it might be a configuration issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Try changing the default \s\r\n to \r\n - that should give you the result you want. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WORKSFORME |FIXED --- Comment #3 from Michael Hafen <michael.hafen@washk12.org> --- That would effect the file upload field, as per the code. The barcode list field is processed separately from the upload field, and does not reference the BarcodeSeparators system preference. I have already removed the \s from the BarcodeSeparators system preference. Looking at the page again, the field hint states that there should be one barcode per line. I don't think the BarcodeSeparators system preference should be applied to the field, and I also thing the field should split on space. I could understand stripping space from the beginning and/or the end of a barcode, but that's not what is currently done. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 --- Comment #4 from Michael Hafen <michael.hafen@washk12.org> --- I meant that the BarcodeSeparators system preference should not be applied to the barcode list field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Looking at the page again, the field hint states that there should be one barcode per line. I don't think the BarcodeSeparators system preference should be applied to the field, and I also thing the field should split on space.
Should or should not? One per line seems save or using BarcodeSeparators seems the safest bet as we can't rule out libraries using spaces within their barcodes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 --- Comment #6 from Michael Hafen <michael.hafen@washk12.org> --- Yes, I meant should not. The BarcodeSeparators sys pref should not apply, since it seems the barcode list field is already separated (one barcode per line). And the field should not be split on space, as you say, since space in a barcode is valid (many of my libraries have such barcodes). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|REOPENED |RESOLVED --- Comment #7 from Michael Hafen <michael.hafen@washk12.org> --- I think I jumped the gun here. I read the regexp as a character class, but it's not. The field is split on space followed by a new line. Having actually tested it, I see that there isn't a problem in practice. I'm still not sure about that regexp, but it does work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org